REGRESSION (r224301?): LayoutTest http/tests/workers/service/registration-task-queue...
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Jan 2018 18:20:30 +0000 (18:20 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Jan 2018 18:20:30 +0000 (18:20 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179342
<rdar://problem/35478161>

Reviewed by Youenn Fablet.

* TestExpectations:
Unmark the test as flaky.

* http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
* http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html:
* http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:
Update test to register a scriptURL that actually fails. When registration succeeds, the test
logs lines indicating that registration succeeded unexpectedly. Also, when registration
succeeds, the registration of the top frame are no longer guaranteed to be resolved before
the ones of the subframe (because it involves things like network loads).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt
LayoutTests/http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html
LayoutTests/http/tests/workers/service/resources/registration-task-queue-scheduling-1.js

index 061e5bd..909ce6c 100644 (file)
@@ -1,5 +1,24 @@
 2018-01-10  Chris Dumez  <cdumez@apple.com>
 
+        REGRESSION (r224301?): LayoutTest http/tests/workers/service/registration-task-queue-scheduling-1.html is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=179342
+        <rdar://problem/35478161>
+
+        Reviewed by Youenn Fablet.
+
+        * TestExpectations:
+        Unmark the test as flaky.
+
+        * http/tests/workers/service/registration-task-queue-scheduling-1-expected.txt:
+        * http/tests/workers/service/resources/registration-task-queue-scheduling-1-second-window.html:
+        * http/tests/workers/service/resources/registration-task-queue-scheduling-1.js:
+        Update test to register a scriptURL that actually fails. When registration succeeds, the test
+        logs lines indicating that registration succeeded unexpectedly. Also, when registration
+        succeeds, the registration of the top frame are no longer guaranteed to be resolved before
+        the ones of the subframe (because it involves things like network loads).
+
+2018-01-10  Chris Dumez  <cdumez@apple.com>
+
         Unreviewed, skip http/tests/workers/service/other_resources folder.
 
         It is a resources folder and does not contain tests.
index a1c3069..fda6b52 100644 (file)
@@ -164,7 +164,6 @@ imported/w3c/web-platform-tests/service-workers/service-worker/navigation-preloa
 imported/w3c/web-platform-tests/service-workers/service-worker/shared-worker-controlled.https.html [ Skip ]
 imported/w3c/web-platform-tests/service-workers/service-worker/claim-shared-worker-fetch.https.html [ Skip ]
 
-webkit.org/b/179342 http/tests/workers/service/registration-task-queue-scheduling-1.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/about-blank-replacement.https.html [ Pass Failure ]
 webkit.org/b/179248 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-within-sw.https.html [ Pass Failure ]
 imported/w3c/web-platform-tests/service-workers/service-worker/fetch-event-respond-with-response-body-with-invalid-chunk.https.html [ Pass Failure ]
index 206772f..bfd830e 100644 (file)
@@ -4,7 +4,7 @@ if (!window.opener)
        alert("This HTML file should not be opened directly")
 
 for (var i = 0; i < 1000; ++i) {
-       navigator.serviceWorker.register("empty-worker.js", { })
+       navigator.serviceWorker.register("http://127.0.0.1:8000/workers/service/resources/empty-worker.js", { })
        .then(function(r) {
                alert("Popup window resolved successfully (unexpected)")
                opener.postMessage("done", "*");
@@ -13,4 +13,4 @@ for (var i = 0; i < 1000; ++i) {
        })
 }
 
-</script>
\ No newline at end of file
+</script>
index dc49498..9d93492 100644 (file)
@@ -37,22 +37,21 @@ function responded()
        if (window.popupTimestamp < window.thisTimestamp)
                alert("Popup should not have popped up before this main window");
        else
-               alert("Done");
+               alert("PASS");
        
        finishSWTest();
 }
 
 for (var i = 0; i < 1000; ++i) {
-       navigator.serviceWorker.register("resources/empty-worker.js", { })
+       navigator.serviceWorker.register("http://localhost:8000/workers/service/resources/empty-worker.js", { })
        .then(function(r) {
                console.log("Original window resolved successfully (unexpected)")
                finishSWTest();
        }, function(e) {
-               if (e+"" != "UnknownError: Script URL http://127.0.0.1:8000/workers/service/resources/empty-worker.js fetched with 41 characters, but we're not using the result yet") {
+               if (e.name != "SecurityError") {
                        alert("Unexpected error received from server: " + e);
                        finishSWTest();
                }
-               
                responded();
        })
 }