Remove Chromium EWS bots from the queue status server
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Apr 2013 23:11:24 +0000 (23:11 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 10 Apr 2013 23:11:24 +0000 (23:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.

* QueueStatusServer/app.yaml:
* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):
* QueueStatusServer/templates/activebots.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@148146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/QueueStatusServer/app.yaml
Tools/QueueStatusServer/config/queues.py
Tools/QueueStatusServer/model/queues.py
Tools/QueueStatusServer/model/queues_unittest.py
Tools/QueueStatusServer/templates/activebots.html

index a78e4fa..0bb8339 100644 (file)
@@ -1,3 +1,23 @@
+2013-04-10  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Remove Chromium EWS bots from the queue status server
+        https://bugs.webkit.org/show_bug.cgi?id=113988
+
+        Reviewed by Benjamin Poulain.
+
+        Removed Chromium EWS bots. Also updated it to use webkit-queues.appspot.com.
+
+        * QueueStatusServer/app.yaml:
+        * QueueStatusServer/config/queues.py:
+        * QueueStatusServer/model/queues.py:
+        (Queue.short_name):
+        (Queue.display_name):
+        * QueueStatusServer/model/queues_unittest.py:
+        (QueueTest.test_short_name):
+        (QueueTest.test_display_name):
+        (QueueTest.test_name_with_underscores):
+        * QueueStatusServer/templates/activebots.html:
+
 2013-04-10  Ojan Vafai  <ojan@chromium.org>
 
         Change all instances of test-results.appspot.com to webkit-test-results.appspot.com
index be760c0..1477a3a 100644 (file)
@@ -1,4 +1,4 @@
-application: webkit-commit-queue
+application: webkit-queues
 version: 108593 # Bugzilla bug ID of last major change
 runtime: python
 api_version: 1
index 99bf34f..7368af1 100644 (file)
@@ -30,9 +30,6 @@
 all_queue_names = [
     "commit-queue",
     "style-queue",
-    "chromium-ews",  # aka cr-linux-ews
-    "cr-linux-debug-ews",
-    "cr-android-ews",
     "qt-ews",
     "qt-wk2-ews",
     "gtk-ews",
index b32f69e..bd2c7d7 100644 (file)
@@ -68,18 +68,12 @@ class Queue(object):
 
     # For use in status bubbles or table headers
     def short_name(self):
-        # HACK: chromium-ews is incorrectly named.
-        short_name = self._name.replace("chromium-ews", "Cr-Linux-ews")
-        short_name = short_name.replace("-ews", "")
+        short_name = self._name.replace("-ews", "")
         short_name = short_name.replace("-queue", "")
         return self._caplitalize_after_dash(short_name.capitalize())
 
     def display_name(self):
-        # HACK: chromium-ews is incorrectly named.
-        display_name = self._name.replace("chromium-ews", "cr-linux-ews")
-
-        display_name = display_name.replace("-", " ")
-        display_name = display_name.replace("cr", "chromium")
+        display_name = self._name.replace("-", " ")
         display_name = display_name.title()
         display_name = display_name.replace("Ews", "EWS")
         return display_name
index 654c8a6..2a6bd70 100644 (file)
@@ -47,7 +47,6 @@ class QueueTest(unittest.TestCase):
 
     def test_short_name(self):
         self._assert_short_name("mac-ews", "Mac")
-        self._assert_short_name("chromium-ews", "Cr-Linux")
         self._assert_short_name("commit-queue", "Commit")
         self._assert_short_name("style-queue", "Style")
 
@@ -56,7 +55,6 @@ class QueueTest(unittest.TestCase):
 
     def test_display_name(self):
         self._assert_display_name("mac-ews", "Mac EWS")
-        self._assert_display_name("chromium-ews", "Chromium Linux EWS")
         self._assert_display_name("commit-queue", "Commit Queue")
         self._assert_display_name("style-queue", "Style Queue")
 
@@ -65,7 +63,6 @@ class QueueTest(unittest.TestCase):
 
     def test_name_with_underscores(self):
         self._assert_name_with_underscores("mac-ews", "mac_ews")
-        self._assert_name_with_underscores("chromium-ews", "chromium_ews")
         self._assert_name_with_underscores("commit-queue", "commit_queue")
 
     def test_style_queue_is_ews(self):
index d47f45d..8c79d73 100644 (file)
@@ -1,7 +1,7 @@
 <!DOCTYPE html>
 <html>
 <head>
-<title>WebKit Queue Status</title>
+<title>WebKit Queues</title>
 <link type="text/css" rel="stylesheet" href="/stylesheets/dashboard.css" />
 <style>
 /* Override the generic table styles from dashboard.css */
@@ -11,7 +11,7 @@ td {
 </style>
 </head>
 <body>
-<h1>WebKit Queue Status</h1>
+<h1>WebKit Queues</h1>
 <table>
     <thead>
         <tr>