Remove unnecessary flushing of Butterfly pointer in functionCpuClflush()
authormsaboff@apple.com <msaboff@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Jan 2018 00:47:15 +0000 (00:47 +0000)
committermsaboff@apple.com <msaboff@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 4 Jan 2018 00:47:15 +0000 (00:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181263

Reviewed by Mark Lam.

Flushing the butterfly pointer provides no benefit and slows this function.

* tools/JSDollarVM.cpp:
(JSC::functionCpuClflush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/tools/JSDollarVM.cpp

index bafcd90..4f87717 100644 (file)
@@ -1,3 +1,15 @@
+2018-01-03  Michael Saboff  <msaboff@apple.com>
+
+        Remove unnecessary flushing of Butterfly pointer in functionCpuClflush()
+        https://bugs.webkit.org/show_bug.cgi?id=181263
+
+        Reviewed by Mark Lam.
+
+        Flushing the butterfly pointer provides no benefit and slows this function.
+
+        * tools/JSDollarVM.cpp:
+        (JSC::functionCpuClflush):
+
 2018-01-03  Saam Barati  <sbarati@apple.com>
 
         Fix BytecodeParser op_catch assert to work with useProfiler=1
index 1b61ad9..6bb92f1 100644 (file)
@@ -1118,7 +1118,6 @@ static EncodedJSValue JSC_HOST_CALL functionCpuClflush(ExecState* exec)
         case ALL_INT32_INDEXING_TYPES:
         case ALL_CONTIGUOUS_INDEXING_TYPES:
         case ALL_DOUBLE_INDEXING_TYPES:
-            toFlush.append(bitwise_cast<char*>(object) + JSObject::butterflyOffset());
             toFlush.append(bitwise_cast<char*>(object->butterfly()) + Butterfly::offsetOfVectorLength());
             toFlush.append(bitwise_cast<char*>(object->butterfly()) + Butterfly::offsetOfPublicLength());
         }