NetworkStorageSession::createDefaultSession is only implemented by Soup
authorkseo@webkit.org <kseo@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Jul 2013 23:41:23 +0000 (23:41 +0000)
committerkseo@webkit.org <kseo@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Jul 2013 23:41:23 +0000 (23:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=118679

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Remove NetworkStorageSession::createDefaultSession() because
NetworkStorageSession::defaultStorageSession() returns the default
session.

No new tests, no behavior change.

* platform/network/NetworkStorageSession.h:
* platform/network/soup/NetworkStorageSessionSoup.cpp:

Source/WebKit/efl:

Replace NetworkStorageSession::createDefaultSession() with
NetworkStorageSession::defaultStorageSession().

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(EWKPrivate::storageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@152672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/NetworkStorageSession.h
Source/WebCore/platform/network/soup/NetworkStorageSessionSoup.cpp
Source/WebKit/efl/ChangeLog
Source/WebKit/efl/ewk/ewk_view.cpp

index 273c531..c0c8c69 100644 (file)
@@ -1,3 +1,19 @@
+2013-07-15  Kwang Yul Seo  <skyul@company100.net>
+
+        NetworkStorageSession::createDefaultSession is only implemented by Soup
+        https://bugs.webkit.org/show_bug.cgi?id=118679
+
+        Reviewed by Alexey Proskuryakov.
+
+        Remove NetworkStorageSession::createDefaultSession() because
+        NetworkStorageSession::defaultStorageSession() returns the default
+        session.
+
+        No new tests, no behavior change.
+
+        * platform/network/NetworkStorageSession.h:
+        * platform/network/soup/NetworkStorageSessionSoup.cpp:
+
 2013-07-15  Ryosuke Niwa  <rniwa@webkit.org>
 
         compositionstart event should contain the text to be replaced
index 033249a..4128caa 100644 (file)
@@ -45,7 +45,6 @@ class NetworkStorageSession {
     WTF_MAKE_NONCOPYABLE(NetworkStorageSession); WTF_MAKE_FAST_ALLOCATED;
 public:
     static NetworkStorageSession& defaultStorageSession();
-    static PassOwnPtr<NetworkStorageSession> createDefaultSession(const String& identifierBase = String());
     static PassOwnPtr<NetworkStorageSession> createPrivateBrowsingSession(const String& identifierBase);
 
     static void switchToNewTestingSession();
index dd56e2b..26cae76 100644 (file)
@@ -52,12 +52,6 @@ NetworkStorageSession& NetworkStorageSession::defaultStorageSession()
     return *defaultSession();
 }
 
-PassOwnPtr<NetworkStorageSession> NetworkStorageSession::createDefaultSession(const String&)
-{
-    ASSERT(isMainThread());
-    return adoptPtr(new NetworkStorageSession(ResourceHandle::defaultSession()));
-}
-
 PassOwnPtr<NetworkStorageSession> NetworkStorageSession::createPrivateBrowsingSession(const String&)
 {
     ASSERT_NOT_REACHED();
index ae9d60f..2488180 100644 (file)
@@ -1,3 +1,17 @@
+2013-07-15  Kwang Yul Seo  <skyul@company100.net>
+
+        NetworkStorageSession::createDefaultSession is only implemented by Soup
+        https://bugs.webkit.org/show_bug.cgi?id=118679
+
+        Reviewed by Alexey Proskuryakov.
+
+        Replace NetworkStorageSession::createDefaultSession() with
+        NetworkStorageSession::defaultStorageSession().
+
+        * ewk/ewk_view.cpp:
+        (_ewk_view_priv_new):
+        (EWKPrivate::storageSession):
+
 2013-07-09  Ryuan Choi  <ryuan.choi@samsung.com>
 
         [EFL] Add ewk_view_device_pixel_ratio_set
index 6dcb694..b5d62ed 100644 (file)
@@ -269,7 +269,7 @@ struct _Ewk_View_Private_Data {
 #if ENABLE(NAVIGATOR_CONTENT_UTILS) || ENABLE(CUSTOM_SCHEME_HANDLER)
     OwnPtr<WebCore::NavigatorContentUtilsClientEfl> navigatorContentUtilsClient;
 #endif
-    OwnPtr<WebCore::NetworkStorageSession> storageSession;
+    WebCore::NetworkStorageSession* storageSession;
     struct {
         Ewk_Menu menu;
         WebCore::PopupMenuClient* menuClient;
@@ -849,7 +849,7 @@ static Ewk_View_Private_Data* _ewk_view_priv_new(Ewk_View_Smart_Data* smartData)
 
     priv->history = ewk_history_new(static_cast<WebCore::BackForwardListImpl*>(priv->page->backForwardList()));
 
-    priv->storageSession = WebCore::NetworkStorageSession::createDefaultSession();
+    priv->storageSession = &WebCore::NetworkStorageSession::defaultStorageSession();
 
     priv->pageClient = adoptPtr(new PageClientEfl(smartData->self));
 
@@ -4772,7 +4772,7 @@ WebCore::NetworkStorageSession* storageSession(const Evas_Object* ewkView)
 {
     EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, 0);
     EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, 0);
-    return priv->storageSession.get();
+    return priv->storageSession;
 }
 
 } // namespace EWKPrivate