Remove ChromeClient::scrollbarsModeDidChange
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Aug 2017 18:19:33 +0000 (18:19 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 Aug 2017 18:19:33 +0000 (18:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=175805

Patch by Alex Christensen <achristensen@webkit.org> on 2017-08-22
Reviewed by Daniel Bates.

Source/WebCore:

No change in behavior.  It was never called, and no implementations did anything.

* loader/EmptyClients.h:
* page/Chrome.cpp:
(WebCore::Chrome::scrollbarsModeDidChange const): Deleted.
* page/Chrome.h:
* page/ChromeClient.h:
* platform/HostWindow.h:

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.
* WebProcess/WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebChromeClient.h:

Source/WebKitLegacy/win:

* WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 files changed:
Source/WebCore/ChangeLog
Source/WebCore/loader/EmptyClients.h
Source/WebCore/page/Chrome.cpp
Source/WebCore/page/Chrome.h
Source/WebCore/page/ChromeClient.h
Source/WebCore/platform/HostWindow.h
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp
Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.h
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/WebCoreSupport/WebChromeClient.h
Source/WebKitLegacy/win/ChangeLog
Source/WebKitLegacy/win/WebCoreSupport/WebChromeClient.h

index 4372047..7245050 100644 (file)
@@ -1,3 +1,19 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        No change in behavior.  It was never called, and no implementations did anything.
+
+        * loader/EmptyClients.h:
+        * page/Chrome.cpp:
+        (WebCore::Chrome::scrollbarsModeDidChange const): Deleted.
+        * page/Chrome.h:
+        * page/ChromeClient.h:
+        * platform/HostWindow.h:
+
 2017-08-22  Devin Rousso  <webkit@devinrousso.com>
 
         Web Inspector: provide way for ShaderPrograms to be enabled/disabled
index 1dd6b5a..31c4243 100644 (file)
@@ -122,7 +122,6 @@ class EmptyChromeClient : public ChromeClient {
     PlatformPageClient platformPageClient() const final { return 0; }
     void contentsSizeChanged(Frame&, const IntSize&) const final { }
 
-    void scrollbarsModeDidChange() const final { }
     void mouseDidMoveOverElement(const HitTestResult&, unsigned) final { }
 
     void setToolTip(const String&, TextDirection) final { }
index f4e72ff..b0855c6 100644 (file)
@@ -137,11 +137,6 @@ void Chrome::scrollRectIntoView(const IntRect& rect) const
     m_client.scrollRectIntoView(rect);
 }
 
-void Chrome::scrollbarsModeDidChange() const
-{
-    m_client.scrollbarsModeDidChange();
-}
-
 void Chrome::setWindowRect(const FloatRect& rect) const
 {
     m_client.setWindowRect(rect);
index 7a59a51..0208b31 100644 (file)
@@ -81,7 +81,6 @@ public:
     IntRect rootViewToAccessibilityScreen(const IntRect&) const override;
 #endif
     PlatformPageClient platformPageClient() const override;
-    void scrollbarsModeDidChange() const override;
     void setCursor(const Cursor&) override;
     void setCursorHiddenUntilMouseMoves(bool) override;
 
index 9a4c58a..8cf1899 100644 (file)
@@ -178,7 +178,6 @@ public:
 #endif    
 
     virtual PlatformPageClient platformPageClient() const = 0;
-    virtual void scrollbarsModeDidChange() const = 0;
 
 #if ENABLE(CURSOR_SUPPORT)
     virtual void setCursor(const Cursor&) = 0;
index 0e65a3d..28c6d82 100644 (file)
@@ -66,9 +66,6 @@ public:
     // Method for retrieving the native client of the page.
     virtual PlatformPageClient platformPageClient() const = 0;
     
-    // To notify WebKit of scrollbar mode changes.
-    virtual void scrollbarsModeDidChange() const = 0;
-
     // Request that the cursor change.
     virtual void setCursor(const Cursor&) = 0;
 
index 00b82e5..5459a48 100644 (file)
@@ -1,3 +1,14 @@
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::scrollbarsModeDidChange const): Deleted.
+        * WebProcess/WebCoreSupport/WebChromeClient.h:
+
 2017-08-22  Chris Dumez  <cdumez@apple.com>
 
         Add sanity check for source origin in WebLoaderStrategy::startPingLoad()
index da73c3f..05c8f87 100644 (file)
@@ -640,11 +640,6 @@ void WebChromeClient::unavailablePluginButtonClicked(Element& element, RenderEmb
 #endif // ENABLE(NETSCAPE_PLUGIN_API)
 }
 
-void WebChromeClient::scrollbarsModeDidChange() const
-{
-    notImplemented();
-}
-
 void WebChromeClient::mouseDidMoveOverElement(const HitTestResult& hitTestResult, unsigned modifierFlags)
 {
     RefPtr<API::Object> userData;
index 3683288..d44afd8 100644 (file)
@@ -124,7 +124,6 @@ private:
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
 
-    void scrollbarsModeDidChange() const final;
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
 
     void setToolTip(const String&, WebCore::TextDirection) final;
index b53a1cf..b16ccee 100644 (file)
@@ -1,5 +1,14 @@
 2017-08-22  Alex Christensen  <achristensen@webkit.org>
 
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebCoreSupport/WebChromeClient.h:
+
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
         Remove ChromeClient::hasOpenedPopup
         https://bugs.webkit.org/show_bug.cgi?id=175804
 
index 7c68d98..62af77d 100644 (file)
@@ -110,7 +110,6 @@ private:
 
     void setStatusbarText(const String&) override;
 
-    void scrollbarsModeDidChange() const final { }
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
index 65ba772..f3b4d5e 100644 (file)
@@ -1,5 +1,14 @@
 2017-08-22  Alex Christensen  <achristensen@webkit.org>
 
+        Remove ChromeClient::scrollbarsModeDidChange
+        https://bugs.webkit.org/show_bug.cgi?id=175805
+
+        Reviewed by Daniel Bates.
+
+        * WebCoreSupport/WebChromeClient.h:
+
+2017-08-22  Alex Christensen  <achristensen@webkit.org>
+
         Remove ChromeClient::hasOpenedPopup
         https://bugs.webkit.org/show_bug.cgi?id=175804
 
index a88dc22..67dcc31 100644 (file)
@@ -101,7 +101,6 @@ public:
     PlatformPageClient platformPageClient() const final;
     void contentsSizeChanged(WebCore::Frame&, const WebCore::IntSize&) const final;
 
-    void scrollbarsModeDidChange() const final { }
     void mouseDidMoveOverElement(const WebCore::HitTestResult&, unsigned modifierFlags) final;
     bool shouldUnavailablePluginMessageBeButton(WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;
     void unavailablePluginButtonClicked(WebCore::Element&, WebCore::RenderEmbeddedObject::PluginUnavailabilityReason) const final;