WebCore:
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Mar 2010 04:40:40 +0000 (04:40 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 26 Mar 2010 04:40:40 +0000 (04:40 +0000)
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] REGRESSION: Some LayoutTests fail after r56567
        https://bugs.webkit.org/show_bug.cgi?id=36630

        Fix boolean logic goofup. This was a last minute code review
        change that didn't get tested on Windows before commit.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setIsDirectional):

LayoutTests:
2010-03-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] REGRESSION: Some LayoutTests fail after r56567
        https://bugs.webkit.org/show_bug.cgi?id=36630

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@56598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium/test_expectations.txt
WebCore/ChangeLog
WebCore/editing/SelectionController.cpp

index 7c87a78..c8656d3 100644 (file)
@@ -1,3 +1,12 @@
+2010-03-25  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] REGRESSION: Some LayoutTests fail after r56567
+        https://bugs.webkit.org/show_bug.cgi?id=36630
+
+        * platform/chromium/test_expectations.txt:
+
 2010-03-25  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by Darin Adler.
index 23337f1..1912bee 100644 (file)
@@ -2844,20 +2844,6 @@ BUG_JAPHET WIN : http/tests/xmlhttprequest/xmlhttprequest-50ms-download-dispatch
 // Caused by http://trac.webkit.org/changeset/56380
 BUG39062 : websocket/tests/long-invalid-header.html = TEXT
 
-// Caused by http://trac.webkit.org/changeset/56567
-BUG_WK36630 LINUX WIN : editing/selection/5195166-1.html = TEXT
-BUG_WK36630 LINUX WIN : editing/selection/extend-after-mouse-selection.html = TEXT
-BUG_WK36630 LINUX WIN : editing/selection/extend-selection-after-double-click.html = TEXT
-BUG_WK36630 LINUX WIN : editing/selection/extend-selection.html = TEXT
-BUG_WK36630 LINUX WIN : editing/selection/shrink-selection-after-shift-pagedown.html = TEXT
-BUG_WK36630 LINUX WIN : editing/deleting/delete-line-009.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/deleting/delete-line-010.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/selection/5195166-2.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/selection/extend-by-character-004.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/selection/extend-by-character-005.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/unsupported-content/list-delete-001.html = IMAGE+TEXT
-BUG_WK36630 LINUX WIN : editing/unsupported-content/list-delete-003.html = IMAGE+TEXT
-
 // Due to the differences in iniialization checks in KURL and googleurl.
 // Note: this test was also marked as flaky on WIN RELESE above, BUG31342.
 BUG_39423 : security/block-test.html = TIMEOUT
index 498a2fc..7660f06 100644 (file)
@@ -1,3 +1,16 @@
+2010-03-25  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Eric Seidel.
+
+        [chromium] REGRESSION: Some LayoutTests fail after r56567
+        https://bugs.webkit.org/show_bug.cgi?id=36630
+
+        Fix boolean logic goofup. This was a last minute code review
+        change that didn't get tested on Windows before commit.
+
+        * editing/SelectionController.cpp:
+        (WebCore::SelectionController::setIsDirectional):
+
 2010-03-25  Dan Bernstein  <mitz@apple.com>
 
         Reviewed by Darin Adler.
index 1dd846d..1dc8e9f 100644 (file)
@@ -236,7 +236,7 @@ void SelectionController::nodeWillBeRemoved(Node *node)
 void SelectionController::setIsDirectional(bool isDirectional)
 {
     Settings* settings = m_frame ? m_frame->settings() : 0;
-    m_isDirectional = !settings || (settings->editingBehavior() == EditingMacBehavior && isDirectional);
+    m_isDirectional = !settings || settings->editingBehavior() != EditingMacBehavior || isDirectional;
 }
 
 void SelectionController::willBeModified(EAlteration alter, EDirection direction)