Web Inspector: Settings: sticky header disappears when over scrolling
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Jun 2019 20:00:01 +0000 (20:00 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Jun 2019 20:00:01 +0000 (20:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=198833

Reviewed by Joseph Pecoraro.

* UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings .navigation-bar):
(.content-view.settings > .settings-view): Added.
(.content-view.settings): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@246410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/SettingsTabContentView.css

index eaecae1..5c0b8ff 100644 (file)
@@ -1,3 +1,15 @@
+2019-06-13  Devin Rousso  <drousso@apple.com>
+
+        Web Inspector: Settings: sticky header disappears when over scrolling
+        https://bugs.webkit.org/show_bug.cgi?id=198833
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/SettingsTabContentView.css:
+        (.content-view.settings .navigation-bar):
+        (.content-view.settings > .settings-view): Added.
+        (.content-view.settings): Deleted.
+
 2019-06-10  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Timelines: imported recordings do not have JavaScript call trees
index c23f74e..ebfab86 100644 (file)
  * THE POSSIBILITY OF SUCH DAMAGE.
  */
 
-.content-view.settings {
-    padding-bottom: 6vh;
-    overflow-y: auto;
-}
-
 .content-view.settings .navigation-bar {
-    position: sticky;
-    top: 0;
-    z-index: 1;
     background-color: white;
 }
 
     color: var(--selected-background-color)
 }
 
+.content-view.settings > .settings-view {
+    height: 100%;
+    overflow-y: auto;
+    padding-bottom: calc(var(--console-prompt-min-height) + 10px);
+}
+
 .content-view.settings > .settings-view > .separator {
     height: 1em;
 }