Try to normalize variation ranges
authormmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2017 00:37:36 +0000 (00:37 +0000)
committermmaxfield@apple.com <mmaxfield@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 30 Mar 2017 00:37:36 +0000 (00:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170119

Unreviewed.

Addressing post-review comment.

* platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::isGXVariableFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@214585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp

index b8ac6ac..1863be5 100644 (file)
@@ -3,6 +3,18 @@
         Try to normalize variation ranges
         https://bugs.webkit.org/show_bug.cgi?id=170119
 
+        Unreviewed.
+
+        Addressing post-review comment.
+
+        * platform/graphics/cocoa/FontCacheCoreText.cpp:
+        (WebCore::isGXVariableFont):
+
+2017-03-29  Myles C. Maxfield  <mmaxfield@apple.com>
+
+        Try to normalize variation ranges
+        https://bugs.webkit.org/show_bug.cgi?id=170119
+
         Reviewed by Simon Fraser.
 
         TrueType GX-style variation fonts use one particular scale for values on their
index e3a9588..0a4968f 100644 (file)
@@ -441,7 +441,7 @@ static inline bool isGXVariableFont(CTFontRef font)
         // "The returned set will contain unboxed values, which can be extracted like so:"
         // "CTFontTableTag tag = (CTFontTableTag)(uintptr_t)CFArrayGetValueAtIndex(tags, index);"
         CTFontTableTag tableTag = static_cast<CTFontTableTag>(reinterpret_cast<uintptr_t>(CFArrayGetValueAtIndex(tables.get(), i)));
-        if (tableTag == 'stat')
+        if (tableTag == 'STAT')
             return false;
     }
     return true;