[ews-app] Generate status-bubble hover-over messages (Follow-up fix)
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Mar 2019 21:46:08 +0000 (21:46 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Mar 2019 21:46:08 +0000 (21:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195680
<rdar://problem/48903534>

Unreviewed infrastructure fix.

* BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
(StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-app/ews/views/statusbubble.py
Tools/ChangeLog

index bbe9990..5604915 100644 (file)
@@ -83,19 +83,19 @@ class StatusBubble(View):
 
         elif build.result == Buildbot.EXCEPTION:
             bubble['state'] = 'error'
-            bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+            bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         elif build.result == Buildbot.RETRY:
             bubble['state'] = 'provisional-fail'
-            bubble['details_message'] += ('Build is being retried. Recent messages:\n\n'
+            bubble['details_message'] = ('Build is being retried. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         elif build.result == Buildbot.CANCELLED:
             bubble['state'] = 'provisional-fail'
-            bubble['details_message'] += ('Build was cancelled. Recent messages:\n\n'
+            bubble['details_message'] = ('Build was cancelled. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
         else:
             bubble['state'] = 'error'
-            bubble['details_message'] += ('An unexpected error occured. Recent messages:\n\n'
+            bubble['details_message'] = ('An unexpected error occured. Recent messages:\n\n'
                 + self._steps_messages(build) + '\n\n' + self._iso_time(build.complete_at))
 
         if 'details_message' in bubble:
index c7fd39b..0eeab6c 100644 (file)
@@ -1,3 +1,14 @@
+2019-03-21  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-app] Generate status-bubble hover-over messages (Follow-up fix)
+        https://bugs.webkit.org/show_bug.cgi?id=195680
+        <rdar://problem/48903534>
+
+        Unreviewed infrastructure fix.
+
+        * BuildSlaveSupport/ews-app/ews/views/statusbubble.py:
+        (StatusBubble._build_bubble): Do not append to details_message in the cases in which it wasn't defined earlier.
+
 2019-03-21  Andy Estes  <aestes@apple.com>
 
         [iOS] Apple Pay should be available in documents with no user agent scripts