[ews-build] Buildbot should include builder_display_name in the build events
authoraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Feb 2019 01:47:03 +0000 (01:47 +0000)
committeraakash_jain@apple.com <aakash_jain@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Feb 2019 01:47:03 +0000 (01:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195045

Reviewed by Dewei Zhu.

* BuildSlaveSupport/ews-build/events.py:
(Events.buildStarted): Included builder_display_name in event data. Also renamed
buildername to builder_name to be consistent in naming style.
(Events.buildFinished): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/BuildSlaveSupport/ews-build/events.py
Tools/ChangeLog

index 2b94ed0..709df42 100644 (file)
@@ -109,6 +109,9 @@ class Events(service.BuildbotService):
         if not build.get('properties'):
             build['properties'] = yield self.master.db.builds.getBuildProperties(build.get('buildid'))
 
+        builder = yield self.master.db.builders.getBuilder(build.get('builderid'))
+        builder_display_name = builder.get('description')
+
         data = {
             "type": self.type_prefix + "build",
             "status": "started",
@@ -120,7 +123,8 @@ class Events(service.BuildbotService):
             "started_at": build.get('started_at'),
             "complete_at": build.get('complete_at'),
             "state_string": build.get('state_string'),
-            "buildername": self.getBuilderName(build),
+            "builder_name": self.getBuilderName(build),
+            "builder_display_name": builder_display_name,
         }
 
         self.sendData(data)
@@ -132,6 +136,9 @@ class Events(service.BuildbotService):
         if not build.get('steps'):
             build['steps'] = yield self.master.db.steps.getSteps(build.get('buildid'))
 
+        builder = yield self.master.db.builders.getBuilder(build.get('builderid'))
+        builder_display_name = builder.get('description')
+
         data = {
             "type": self.type_prefix + "build",
             "status": "finished",
@@ -143,7 +150,8 @@ class Events(service.BuildbotService):
             "started_at": build.get('started_at'),
             "complete_at": build.get('complete_at'),
             "state_string": build.get('state_string'),
-            "buildername": self.getBuilderName(build),
+            "builder_name": self.getBuilderName(build),
+            "builder_display_name": builder_display_name,
             "steps": build.get('steps'),
         }
 
index b337822..c993ff4 100644 (file)
@@ -1,3 +1,15 @@
+2019-02-27  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews-build] Buildbot should include builder_display_name in the build events
+        https://bugs.webkit.org/show_bug.cgi?id=195045
+
+        Reviewed by Dewei Zhu.
+
+        * BuildSlaveSupport/ews-build/events.py:
+        (Events.buildStarted): Included builder_display_name in event data. Also renamed
+        buildername to builder_name to be consistent in naming style.
+        (Events.buildFinished): Ditto.
+
 2019-02-27  Chris Dumez  <cdumez@apple.com>
 
         Flaky API Test: TestWebKitAPI.ProcessSwap.SessionStorage