2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 02:35:38 +0000 (02:35 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 11 Apr 2011 02:35:38 +0000 (02:35 +0000)
        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebProcess.pro:
2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Eric Seidel.

        Require no undefined symbols during compilation.

        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
        https://bugs.webkit.org/show_bug.cgi?id=54896

        Add -Wl,--no-undefined to catch missing symbols early.

        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
        * WebKitTestRunner/qt/WebKitTestRunner.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess.pro
Tools/ChangeLog
Tools/WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro
Tools/WebKitTestRunner/qt/WebKitTestRunner.pro

index d0554cd..9fc53d2 100644 (file)
@@ -1,3 +1,16 @@
+2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Require no undefined symbols during compilation.
+
+        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
+        https://bugs.webkit.org/show_bug.cgi?id=54896
+        
+        Add -Wl,--no-undefined to catch missing symbols early.
+
+        * WebProcess.pro:
+
 2011-04-09  Geoffrey Garen  <ggaren@apple.com>
 
         Not reviewed.
index 08521de..cd28c26 100644 (file)
@@ -27,7 +27,7 @@ linux-* {
     QMAKE_RPATHDIR = \$\$ORIGIN/../lib $$QMAKE_RPATHDIR
     MY_RPATH = $$join(QMAKE_RPATHDIR, ":")
 
-    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\'
+    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\' -Wl,--no-undefined
     QMAKE_RPATHDIR =
 } else {
     QMAKE_RPATHDIR = $$OUTPUT_DIR/lib $$QMAKE_RPATHDIR
index f1e56a6..5678a21 100644 (file)
@@ -1,3 +1,17 @@
+2011-04-10  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>
+
+        Reviewed by Eric Seidel.
+
+        Require no undefined symbols during compilation.
+
+        [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
+        https://bugs.webkit.org/show_bug.cgi?id=54896
+
+        Add -Wl,--no-undefined to catch missing symbols early.
+
+        * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
+        * WebKitTestRunner/qt/WebKitTestRunner.pro:
+
 2011-04-10  Kevin Ollivier  <kevino@theolliviers.com>
 
         [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
index 07859b4..0bac510 100644 (file)
@@ -80,3 +80,6 @@ unix:!mac:!symbian:!embedded {
 TARGET = WTRInjectedBundle
 DESTDIR = $$OUTPUT_DIR/lib
 !CONFIG(standalone_package): CONFIG -= app_bundle
+linux-* {
+    QMAKE_LFLAGS += -Wl,--no-undefined
+}
index e30bfd9..eb6602f 100644 (file)
@@ -57,7 +57,7 @@ linux-* {
     QMAKE_RPATHDIR = \$\$ORIGIN/../lib $$QMAKE_RPATHDIR
     MY_RPATH = $$join(QMAKE_RPATHDIR, ":")
 
-    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\'
+    QMAKE_LFLAGS += -Wl,-z,origin \'-Wl,-rpath,$${MY_RPATH}\' -Wl,--no-undefined
     QMAKE_RPATHDIR =
 } else {
     QMAKE_RPATHDIR = $$OUTPUT_DIR/lib $$QMAKE_RPATHDIR