Rename DOMSelection to Selection
authorarv@chromium.org <arv@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Mar 2012 05:34:33 +0000 (05:34 +0000)
committerarv@chromium.org <arv@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 Mar 2012 05:34:33 +0000 (05:34 +0000)
https://bugs.webkit.org/show_bug.cgi?id=79688

Reviewed by Adam Barth.

Source/WebCore:

No new tests. Existing tests have been updated to cover this.

* page/DOMSelection.idl:
* page/DOMWindow.idl:

LayoutTests:

* fast/dom/Window/window-properties-expected.txt:
* fast/dom/dom-constructors-expected.txt:
* fast/dom/dom-constructors.html:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/win/fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@109306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/dom/Window/window-properties-expected.txt
LayoutTests/fast/dom/dom-constructors-expected.txt
LayoutTests/fast/dom/dom-constructors.html
LayoutTests/platform/gtk/fast/dom/Window/window-properties-expected.txt
LayoutTests/platform/mac/fast/dom/Window/window-properties-expected.txt
LayoutTests/platform/mac/fast/dom/Window/window-property-descriptors-expected.txt
LayoutTests/platform/mac/fast/dom/prototype-inheritance-2-expected.txt
LayoutTests/platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt
LayoutTests/platform/qt/fast/dom/Window/window-properties-expected.txt
LayoutTests/platform/win/fast/dom/Window/window-properties-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/page/DOMSelection.idl
Source/WebCore/page/DOMWindow.idl

index e70b97e..8d0e63c 100644 (file)
@@ -1,3 +1,21 @@
+2012-02-29  Erik Arvidsson  <arv@chromium.org>
+
+        Rename DOMSelection to Selection
+        https://bugs.webkit.org/show_bug.cgi?id=79688
+
+        Reviewed by Adam Barth.
+
+        * fast/dom/Window/window-properties-expected.txt:
+        * fast/dom/dom-constructors-expected.txt:
+        * fast/dom/dom-constructors.html:
+        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
+        * platform/mac/fast/dom/Window/window-properties-expected.txt:
+        * platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
+        * platform/mac/fast/dom/prototype-inheritance-2-expected.txt:
+        * platform/qt-5.0-wk2/fast/dom/Window/window-properties-expected.txt:
+        * platform/qt/fast/dom/Window/window-properties-expected.txt:
+        * platform/win/fast/dom/Window/window-properties-expected.txt:
+
 2012-02-29  Joshua Bell  <jsbell@chromium.org>
 
         IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
index ef71682..34e04a4 100644 (file)
@@ -2494,7 +2494,7 @@ window.unescape [function]
 window.webkitConvertPointFromNodeToPage [function]
 window.webkitConvertPointFromPageToNode [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
+window.getSelection() [object Selection]
 window.getSelection().addRange [function]
 window.getSelection().anchorNode [null]
 window.getSelection().anchorOffset [number]
index e9ff449..0381652 100644 (file)
@@ -115,7 +115,7 @@ FAIL TryAllocate('BarInfo') should be exception. Was no constructor.
 PASS TryAllocate('CanvasGradient') is 'exception'
 PASS TryAllocate('CanvasPattern') is 'exception'
 FAIL TryAllocate('Console') should be exception. Was no constructor.
-FAIL TryAllocate('DOMSelection') should be exception. Was no constructor.
+PASS TryAllocate('Selection') is 'exception'
 PASS TryAllocate('Window') is 'exception'
 FAIL TryAllocate('History') should be exception. Was no constructor.
 FAIL TryAllocate('HTMLOptionsCollection') should be exception. Was no constructor.
index 8106dc4..1b3250f 100644 (file)
@@ -47,7 +47,7 @@ var objects_exception = [
     'NodeFilter', 'NodeList', 'Plugin',
     'PluginArray', 'Range', 'Rect', 'StyleSheet', 'StyleSheetList',
     'TextEvent', 'UIEvent', 'WheelEvent', 'XPathResult', 'BarInfo',
-    'CanvasGradient', 'CanvasPattern', 'Console', 'DOMSelection',
+    'CanvasGradient', 'CanvasPattern', 'Console', 'Selection',
     'Window', 'History', 'HTMLOptionsCollection', 'Location',
     'Navigator', 'NodeIterator', 'RGBColor', 'Screen', 'TreeWalker',
     'XPathExpression', 'Worker'
index 838856b..52d6e20 100644 (file)
@@ -2101,6 +2101,23 @@ window.SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN [number]
 window.SVGViewElement.prototype [printed above as window.Element.prototype]
 window.SVGZoomEvent [object SVGZoomEventConstructor]
 window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
 window.SharedWorker [object SharedWorkerConstructor]
 window.SharedWorker.length [number]
 window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2685,31 +2702,5 @@ window.webkitPeerConnection.prototype.send [function]
 window.webkitPostMessage [function]
 window.webkitRequestAnimationFrame [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
 
index 0733d83..d1fe827 100644 (file)
@@ -2110,6 +2110,23 @@ window.SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN [number]
 window.SVGViewElement.prototype [printed above as window.Element.prototype]
 window.SVGZoomEvent [object SVGZoomEventConstructor]
 window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
 window.SharedWorker [object SharedWorkerConstructor]
 window.SharedWorker.length [number]
 window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2705,31 +2722,5 @@ window.webkitConvertPointFromPageToNode [function]
 window.webkitPostMessage [function]
 window.webkitRequestAnimationFrame [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
 
index 3074353..94e4a8a 100644 (file)
@@ -311,6 +311,7 @@ PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGUseElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGVKernElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGViewElement') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'SVGZoomEvent') is 'object'
+PASS typeof Object.getOwnPropertyDescriptor(window, 'Selection') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'SharedWorker') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'Storage') is 'object'
 PASS typeof Object.getOwnPropertyDescriptor(window, 'StorageEvent') is 'object'
index b64c30c..84aa79b 100644 (file)
@@ -269,7 +269,6 @@ Never found HTMLHRElement
 Never found HTMLHeadingElement
 Never found HTMLIFrameElement
 Never found HTMLImageElement
-Never found HTMLIsIndexElement
 Never found HTMLKeygenElement
 Never found HTMLLIElement
 Never found HTMLLabelElement
@@ -448,6 +447,7 @@ Never found SVGUnitTypes
 Never found SVGUseElement
 Never found SVGVKernElement
 Never found SVGViewElement
+Never found Selection
 Never found SharedWorker
 Never found StyleSheet
 Never found TextMetrics
index 65516a7..f2219f4 100644 (file)
@@ -2044,6 +2044,23 @@ window.SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN [number]
 window.SVGViewElement.prototype [printed above as window.Element.prototype]
 window.SVGZoomEvent [object SVGZoomEventConstructor]
 window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
 window.SharedWorker [object SharedWorkerConstructor]
 window.SharedWorker.length [number]
 window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2580,31 +2597,5 @@ window.webkitConvertPointFromPageToNode [function]
 window.webkitPostMessage [function]
 window.webkitRequestAnimationFrame [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
 
index c02ec5c..f1d7570 100644 (file)
@@ -2060,6 +2060,23 @@ window.SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN [number]
 window.SVGViewElement.prototype [printed above as window.Element.prototype]
 window.SVGZoomEvent [object SVGZoomEventConstructor]
 window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
 window.SharedWorker [object SharedWorkerConstructor]
 window.SharedWorker.length [number]
 window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2608,31 +2625,5 @@ window.webkitConvertPointFromPageToNode [function]
 window.webkitPostMessage [function]
 window.webkitRequestAnimationFrame [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
 
index c11df12..e1b4075 100644 (file)
@@ -1991,6 +1991,23 @@ window.SVGViewElement.SVG_ZOOMANDPAN_UNKNOWN [number]
 window.SVGViewElement.prototype [printed above as window.Element.prototype]
 window.SVGZoomEvent [object SVGZoomEventConstructor]
 window.SVGZoomEvent.prototype [printed above as window.Event.prototype]
+window.Selection [object SelectionConstructor]
+window.Selection.prototype [object SelectionPrototype]
+window.Selection.prototype.addRange [function]
+window.Selection.prototype.collapse [function]
+window.Selection.prototype.collapseToEnd [function]
+window.Selection.prototype.collapseToStart [function]
+window.Selection.prototype.containsNode [function]
+window.Selection.prototype.deleteFromDocument [function]
+window.Selection.prototype.empty [function]
+window.Selection.prototype.extend [function]
+window.Selection.prototype.getRangeAt [function]
+window.Selection.prototype.modify [function]
+window.Selection.prototype.removeAllRanges [function]
+window.Selection.prototype.selectAllChildren [function]
+window.Selection.prototype.setBaseAndExtent [function]
+window.Selection.prototype.setPosition [function]
+window.Selection.prototype.toString [function]
 window.SharedWorker [object SharedWorkerConstructor]
 window.SharedWorker.length [number]
 window.SharedWorker.prototype [object SharedWorkerPrototype]
@@ -2507,31 +2524,5 @@ window.unescape [function]
 window.webkitConvertPointFromNodeToPage [function]
 window.webkitConvertPointFromPageToNode [function]
 window.window [printed above as window]
-window.getSelection() [object DOMSelection]
-window.getSelection().addRange [function]
-window.getSelection().anchorNode [null]
-window.getSelection().anchorOffset [number]
-window.getSelection().baseNode [null]
-window.getSelection().baseOffset [number]
-window.getSelection().collapse [function]
-window.getSelection().collapseToEnd [function]
-window.getSelection().collapseToStart [function]
-window.getSelection().containsNode [function]
-window.getSelection().deleteFromDocument [function]
-window.getSelection().empty [function]
-window.getSelection().extend [function]
-window.getSelection().extentNode [null]
-window.getSelection().extentOffset [number]
-window.getSelection().focusNode [null]
-window.getSelection().focusOffset [number]
-window.getSelection().getRangeAt [function]
-window.getSelection().isCollapsed [boolean]
-window.getSelection().modify [function]
-window.getSelection().rangeCount [number]
-window.getSelection().removeAllRanges [function]
-window.getSelection().selectAllChildren [function]
-window.getSelection().setBaseAndExtent [function]
-window.getSelection().setPosition [function]
-window.getSelection().toString [function]
-window.getSelection().type [string]
+window.getSelection() [printed above as window.Selection.prototype]
 
index 4d2994e..c7e26c1 100644 (file)
@@ -1,3 +1,15 @@
+2012-02-29  Erik Arvidsson  <arv@chromium.org>
+
+        Rename DOMSelection to Selection
+        https://bugs.webkit.org/show_bug.cgi?id=79688
+
+        Reviewed by Adam Barth.
+
+        No new tests. Existing tests have been updated to cover this.
+
+        * page/DOMSelection.idl:
+        * page/DOMWindow.idl:
+
 2012-02-29  Joshua Bell  <jsbell@chromium.org>
 
         IndexedDB: IDBDatabase.objectStoreNames and IDObjectStore.indexNames results should be sorted
index cd4b593..1f7d3da 100644 (file)
@@ -33,7 +33,7 @@ module window {
     // https://developer.mozilla.org/En/DOM/Selection
     interface [
         JSGenerateIsReachable=ImplFrame,
-        OmitConstructor
+        InterfaceName=Selection
     ] DOMSelection {
         readonly attribute Node anchorNode;
         readonly attribute long anchorOffset;
index 2d86916..dbdc800 100644 (file)
@@ -393,6 +393,7 @@ module window {
         attribute ProcessingInstructionConstructor ProcessingInstruction;
         attribute [Conditional=SHADOW_DOM, V8EnabledAtRuntime=shadowDOM] ShadowRootConstructor WebKitShadowRoot;
 
+        attribute DOMSelectionConstructor Selection;
         attribute DOMWindowConstructor Window;
 
         // FIXME: Should these Canvas constructors move to html/DOMWindowHTML with the rest of canvas?