IndexedDB: rename some instances of open to registerFrontendCallbacks
authordgrogan@chromium.org <dgrogan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jun 2012 21:59:30 +0000 (21:59 +0000)
committerdgrogan@chromium.org <dgrogan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jun 2012 21:59:30 +0000 (21:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=88611

Source/WebCore:

We should still make the change in the WebKit API.

Reviewed by Tony Chang.

No new tests, just a method rename.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::registerFrontendCallbacks):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):

Source/WebKit/chromium:

Reviewed by Tony Chang.

* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::open):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 files changed:
Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBDatabase.cpp
Source/WebCore/Modules/indexeddb/IDBDatabase.h
Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp
Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h
Source/WebCore/Modules/indexeddb/IDBDatabaseBackendInterface.h
Source/WebCore/Modules/indexeddb/IDBRequest.cpp
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp
Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h
Source/WebKit/chromium/src/WebIDBDatabaseImpl.cpp
Source/WebKit/chromium/src/WebIDBDatabaseImpl.h

index 0703901..f409079 100644 (file)
@@ -1,3 +1,27 @@
+2012-06-08  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: rename some instances of open to registerFrontendCallbacks
+        https://bugs.webkit.org/show_bug.cgi?id=88611
+
+        We should still make the change in the WebKit API.
+
+        Reviewed by Tony Chang.
+
+        No new tests, just a method rename.
+
+        * Modules/indexeddb/IDBDatabase.cpp:
+        (WebCore::IDBDatabase::registerFrontendCallbacks):
+        * Modules/indexeddb/IDBDatabase.h:
+        (IDBDatabase):
+        * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
+        (WebCore::IDBDatabaseBackendImpl::registerFrontendCallbacks):
+        * Modules/indexeddb/IDBDatabaseBackendImpl.h:
+        (IDBDatabaseBackendImpl):
+        * Modules/indexeddb/IDBDatabaseBackendInterface.h:
+        (IDBDatabaseBackendInterface):
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::onSuccess):
+
 2012-06-08  Dana Jansens  <danakj@chromium.org>
 
         [chromium] Skip willDraw() and didDraw() on fully occluded layers
index 2f2b72a..2c1088f 100644 (file)
@@ -237,9 +237,9 @@ void IDBDatabase::onVersionChange(const String& version)
     enqueueEvent(IDBVersionChangeEvent::create(version, eventNames().versionchangeEvent));
 }
 
-void IDBDatabase::open()
+void IDBDatabase::registerFrontendCallbacks()
 {
-    m_backend->open(m_databaseCallbacks);
+    m_backend->registerFrontendCallbacks(m_databaseCallbacks);
 }
 
 void IDBDatabase::enqueueEvent(PassRefPtr<Event> event)
index 6656352..b097b73 100644 (file)
@@ -86,7 +86,7 @@ public:
     virtual const AtomicString& interfaceName() const;
     virtual ScriptExecutionContext* scriptExecutionContext() const;
 
-    void open();
+    void registerFrontendCallbacks();
     void enqueueEvent(PassRefPtr<Event>);
     bool dispatchEvent(PassRefPtr<Event> event, ExceptionCode& ec) { return EventTarget::dispatchEvent(event, ec); }
     virtual bool dispatchEvent(PassRefPtr<Event>);
index 9980c02..ada85c1 100644 (file)
@@ -321,7 +321,7 @@ PassRefPtr<IDBTransactionBackendInterface> IDBDatabaseBackendImpl::transaction(D
     return IDBTransactionBackendImpl::create(objectStoreNames, mode, this);
 }
 
-void IDBDatabaseBackendImpl::open(PassRefPtr<IDBDatabaseCallbacks> callbacks)
+void IDBDatabaseBackendImpl::registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks> callbacks)
 {
     m_databaseCallbacksSet.add(RefPtr<IDBDatabaseCallbacks>(callbacks));
 }
index 2a6fb3b..1e79474 100644 (file)
@@ -53,8 +53,7 @@ public:
     static const int64_t InvalidId = 0;
     int64_t id() const { return m_id; }
 
-    // FIXME: Rename "open" to something more descriptive, like registerFrontEndCallbacks.
-    void open(PassRefPtr<IDBDatabaseCallbacks>);
+    void registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks>);
     void openConnection(PassRefPtr<IDBCallbacks>);
     void deleteDatabase(PassRefPtr<IDBCallbacks>);
 
index e072a0f..4248074 100644 (file)
@@ -62,7 +62,7 @@ public:
     virtual PassRefPtr<IDBTransactionBackendInterface> transaction(DOMStringList* storeNames, unsigned short mode, ExceptionCode&) = 0;
     virtual void close(PassRefPtr<IDBDatabaseCallbacks>) = 0;
 
-    virtual void open(PassRefPtr<IDBDatabaseCallbacks>) = 0;
+    virtual void registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks>) = 0;
 };
 
 } // namespace WebCore
index 5db1149..8e9b381 100644 (file)
@@ -254,7 +254,7 @@ void IDBRequest::onSuccess(PassRefPtr<IDBDatabaseBackendInterface> backend)
         return;
 
     RefPtr<IDBDatabase> idbDatabase = IDBDatabase::create(scriptExecutionContext(), backend);
-    idbDatabase->open();
+    idbDatabase->registerFrontendCallbacks();
 
     m_result = IDBAny::create(idbDatabase.release());
     enqueueEvent(createSuccessEvent());
index a40d2ee..44e33b6 100644 (file)
@@ -1,3 +1,19 @@
+2012-06-08  David Grogan  <dgrogan@chromium.org>
+
+        IndexedDB: rename some instances of open to registerFrontendCallbacks
+        https://bugs.webkit.org/show_bug.cgi?id=88611
+
+        Reviewed by Tony Chang.
+
+        * src/IDBDatabaseBackendProxy.cpp:
+        (WebKit::IDBDatabaseBackendProxy::registerFrontendCallbacks):
+        * src/IDBDatabaseBackendProxy.h:
+        (IDBDatabaseBackendProxy):
+        * src/WebIDBDatabaseImpl.cpp:
+        (WebKit::WebIDBDatabaseImpl::open):
+        * src/WebIDBDatabaseImpl.h:
+        (WebIDBDatabaseImpl):
+
 2012-06-08  Dana Jansens  <danakj@chromium.org>
 
         [chromium] Skip willDraw() and didDraw() on fully occluded layers
index 6e53549..58661eb 100644 (file)
@@ -115,7 +115,7 @@ void IDBDatabaseBackendProxy::close(PassRefPtr<IDBDatabaseCallbacks>)
     m_webIDBDatabase->close();
 }
 
-void IDBDatabaseBackendProxy::open(PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks)
+void IDBDatabaseBackendProxy::registerFrontendCallbacks(PassRefPtr<IDBDatabaseCallbacks> databaseCallbacks)
 {
     m_webIDBDatabase->open(new WebIDBDatabaseCallbacksImpl(databaseCallbacks));
 }
index b78ac69..e817edf 100644 (file)
@@ -52,7 +52,7 @@ public:
     virtual PassRefPtr<WebCore::IDBTransactionBackendInterface> transaction(WebCore::DOMStringList* storeNames, unsigned short mode, WebCore::ExceptionCode&);
     virtual void close(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
 
-    virtual void open(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
+    virtual void registerFrontendCallbacks(PassRefPtr<WebCore::IDBDatabaseCallbacks>);
 
 private:
     IDBDatabaseBackendProxy(PassOwnPtr<WebIDBDatabase>);
index 4be43dc..2662f80 100644 (file)
@@ -111,7 +111,7 @@ void WebIDBDatabaseImpl::open(WebIDBDatabaseCallbacks* callbacks)
 {
     ASSERT(!m_databaseCallbacks);
     m_databaseCallbacks = IDBDatabaseCallbacksProxy::create(adoptPtr(callbacks));
-    m_databaseBackend->open(m_databaseCallbacks);
+    m_databaseBackend->registerFrontendCallbacks(m_databaseCallbacks);
 }
 
 } // namespace WebKit
index 96571bb..190d7e2 100644 (file)
@@ -59,6 +59,7 @@ public:
     virtual WebIDBTransaction* transaction(const WebDOMStringList& names, unsigned short mode, WebExceptionCode&);
     virtual void close();
 
+    // FIXME: Rename "open" to registerFrontendCallbacks.
     virtual void open(WebIDBDatabaseCallbacks*);
 
 private: