Fix build warning.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Oct 2012 03:49:46 +0000 (03:49 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Oct 2012 03:49:46 +0000 (03:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=99788

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-18
Reviewed by Kentaro Hara.

Source/WebCore:

Use UNUSED_PARAM macro for removing -Wunused-parameter.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform):

Source/WebKit2:

Remove parameter name or use ASSERT_UNUSED macro for removing
-Wunused-parameter.

* PluginProcess/unix/PluginProcessMainUnix.cpp:
(WebKit::PluginProcessMainUnix):
* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::platformInitializeLaunchOptions):

Tools:

Use return value of mktemp() for removing -Wunused-result.

* MiniBrowser/efl/main.c:
(on_download_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@131849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLayer.cpp
Source/WebKit2/ChangeLog
Source/WebKit2/PluginProcess/unix/PluginProcessMainUnix.cpp
Source/WebKit2/UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp
Tools/ChangeLog
Tools/MiniBrowser/efl/main.c

index 025797a..0836e42 100644 (file)
@@ -1,3 +1,15 @@
+2012-10-18  Byungwoo Lee  <bw80.lee@samsung.com>
+
+        Fix build warning.
+        https://bugs.webkit.org/show_bug.cgi?id=99788
+
+        Reviewed by Kentaro Hara.
+
+        Use UNUSED_PARAM macro for removing -Wunused-parameter.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::currentTransform):
+
 2012-10-18  Benjamin Poulain  <bpoulain@apple.com>
 
         [WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
index 62606f1..32471d8 100644 (file)
@@ -619,6 +619,8 @@ TransformationMatrix RenderLayer::currentTransform(RenderStyle::ApplyTransformOr
         makeMatrixRenderable(currTransform, canRender3DTransforms());
         return currTransform;
     }
+#else
+    UNUSED_PARAM(applyOrigin);
 #endif
 
     return *m_transform;
index c3e49da..614fff6 100644 (file)
@@ -1,3 +1,18 @@
+2012-10-18  Byungwoo Lee  <bw80.lee@samsung.com>
+
+        Fix build warning.
+        https://bugs.webkit.org/show_bug.cgi?id=99788
+
+        Reviewed by Kentaro Hara.
+
+        Remove parameter name or use ASSERT_UNUSED macro for removing
+        -Wunused-parameter.
+
+        * PluginProcess/unix/PluginProcessMainUnix.cpp:
+        (WebKit::PluginProcessMainUnix):
+        * UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
+        (WebKit::PluginProcessProxy::platformInitializeLaunchOptions):
+
 2012-10-18  Ryuan Choi  <ryuan.choi@gmail.com>
 
         Attempt to fix the WebKit2/Efl build after r131841.
index 40b409c..e25f067 100644 (file)
@@ -73,9 +73,9 @@ static int webkitXError(Display* xdisplay, XErrorEvent* error)
 
 WK_EXPORT int PluginProcessMainUnix(int argc, char* argv[])
 {
-    ASSERT(argc == 2 || argc == 3);
+    ASSERT_UNUSED(argc, argc == 2 || argc == 3);
     bool scanPlugin = !strcmp(argv[1], "-scanPlugin");
-    ASSERT(argc == 2 || (argc == 3 && scanPlugin));
+    ASSERT_UNUSED(argc, argc == 2 || (argc == 3 && scanPlugin));
 
 #if PLATFORM(GTK)
     gtk_init(&argc, &argv);
index c7a8922..64c7bc4 100644 (file)
@@ -43,7 +43,7 @@ using namespace WebCore;
 
 namespace WebKit {
 
-void PluginProcessProxy::platformInitializeLaunchOptions(ProcessLauncher::LaunchOptions& launchOptions, const PluginModuleInfo& pluginInfo)
+void PluginProcessProxy::platformInitializeLaunchOptions(ProcessLauncher::LaunchOptions&, const PluginModuleInfo&)
 {
 }
 
index 55a75bf..31c7dc9 100644 (file)
@@ -1,3 +1,15 @@
+2012-10-18  Byungwoo Lee  <bw80.lee@samsung.com>
+
+        Fix build warning.
+        https://bugs.webkit.org/show_bug.cgi?id=99788
+
+        Reviewed by Kentaro Hara.
+
+        Use return value of mktemp() for removing -Wunused-result.
+
+        * MiniBrowser/efl/main.c:
+        (on_download_request):
+
 2012-10-18  Benjamin Poulain  <bpoulain@apple.com>
 
         [WK2] WebKit2 does not build without PLUGIN_PROCESS on Mac
index 71796de..c5dc495 100644 (file)
@@ -300,8 +300,7 @@ on_download_request(void *user_data, Evas_Object *webview, void *event_info)
     else {
         // Generate a unique file name since no name was suggested.
         char unique_path[] = "/tmp/downloaded-file.XXXXXX";
-        mktemp(unique_path);
-        eina_strbuf_append(destination_path, unique_path);
+        eina_strbuf_append(destination_path, mktemp(unique_path));
     }
 
     ewk_download_job_destination_set(download, eina_strbuf_string_get(destination_path));