Build fix: TimerBase::start(double, double) can't be inline and exported,
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Apr 2017 03:53:46 +0000 (03:53 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 8 Apr 2017 03:53:46 +0000 (03:53 +0000)
so make it non-inline.

* platform/Timer.cpp:
(WebCore::TimerBase::start):
* platform/Timer.h:
(WebCore::TimerBase::start): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@215140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/Timer.cpp
Source/WebCore/platform/Timer.h

index f3e0852..3de5b9e 100644 (file)
@@ -1,3 +1,13 @@
+2017-04-07  Simon Fraser  <simon.fraser@apple.com>
+
+        Build fix: TimerBase::start(double, double) can't be inline and exported,
+        so make it non-inline.
+
+        * platform/Timer.cpp:
+        (WebCore::TimerBase::start):
+        * platform/Timer.h:
+        (WebCore::TimerBase::start): Deleted.
+
 2017-04-07  Chris Dumez  <cdumez@apple.com>
 
         REGRESSION (r203941): iAd Producer widgets fail to play in iBooks
index ceea692..18fa9e5 100644 (file)
@@ -201,6 +201,11 @@ TimerBase::~TimerBase()
 #endif
 }
 
+void TimerBase::start(double nextFireInterval, double repeatInterval)
+{
+    start(Seconds { nextFireInterval }, Seconds { repeatInterval });
+}
+
 void TimerBase::start(Seconds nextFireInterval, Seconds repeatInterval)
 {
     ASSERT(canAccessThreadLocalDataForThread(m_thread));
index 63072c7..36733da 100644 (file)
@@ -57,7 +57,7 @@ public:
     WEBCORE_EXPORT virtual ~TimerBase();
 
     WEBCORE_EXPORT void start(Seconds nextFireInterval, Seconds repeatInterval);
-    WEBCORE_EXPORT void start(double nextFireInterval, double repeatInterval) { start(Seconds { nextFireInterval }, Seconds { repeatInterval }); }
+    WEBCORE_EXPORT void start(double nextFireInterval, double repeatInterval);
 
     void startRepeating(double repeatInterval) { start(repeatInterval, repeatInterval); }
     void startRepeating(std::chrono::milliseconds repeatInterval) { startRepeating(msToSeconds(repeatInterval)); }