REGRESSION: ( r231040 ) Layout Test http/tests/security/xss-DENIED-xsl-external-entit...
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Mar 2019 22:17:40 +0000 (22:17 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Mar 2019 22:17:40 +0000 (22:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=189724
<rdar://problem/48422520>

Reviewed by Geoffrey Garen.

Copy the flaky test into a new test for which we use DumpJSConsoleLogInStdErr.
This should make the new test no longer flaky in WK1.
Run this new test for WK1 only and run the original test for WK2 only.

* TestExpectations:
* http/tests/security/xss-DENIED-xsl-external-entity-no-logging-expected.txt: Added.
* http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml: Added.
* platform/ios-wk1/TestExpectations:
* platform/mac-wk1/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging-expected.txt [new file with mode: 0644]
LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml [new file with mode: 0644]
LayoutTests/platform/ios-wk1/TestExpectations
LayoutTests/platform/mac-wk1/TestExpectations

index babe9bd..ea69b45 100644 (file)
@@ -1,3 +1,22 @@
+2019-03-07  Youenn Fablet  <youenn@apple.com>
+
+        REGRESSION: ( r231040 ) Layout Test http/tests/security/xss-DENIED-xsl-external-entity.xml is a flaky failure
+        https://bugs.webkit.org/show_bug.cgi?id=189724
+        <rdar://problem/48422520>
+
+        Reviewed by Geoffrey Garen.
+
+        Copy the flaky test into a new test for which we use DumpJSConsoleLogInStdErr.
+        This should make the new test no longer flaky in WK1.
+        Run this new test for WK1 only and run the original test for WK2 only.
+
+        * TestExpectations:
+        * http/tests/security/xss-DENIED-xsl-external-entity-no-logging-expected.txt: Added.
+        * http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml: Added.
+        * platform/ios-wk1/TestExpectations:
+        * platform/mac-wk1/TestExpectations:
+        * platform/wk2/TestExpectations:
+
 2019-03-07  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Protocol: add type checking when commands are called via invoke
index 48c948b..d25fd1b 100644 (file)
@@ -56,6 +56,8 @@ pointerevents/ios [ Skip ]
 editing/pasteboard/ios [ Skip ]
 editing/pasteboard/mac [ Skip ]
 
+http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml [ Skip ]
+
 # window.showModalDialog is only tested in DumpRenderTree on Mac.
 editing/execCommand/show-modal-dialog-during-execCommand.html [ Skip ]
 http/tests/security/cross-origin-modal-dialog-base.html [ Skip ]
diff --git a/LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging-expected.txt b/LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging-expected.txt
new file mode 100644 (file)
index 0000000..8cd59a5
--- /dev/null
@@ -0,0 +1,2 @@
+This test includes a cross-origin external entity. It passes if the load fails and thus there is no text below this line.
+
diff --git a/LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml b/LayoutTests/http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml
new file mode 100644 (file)
index 0000000..2e26a56
--- /dev/null
@@ -0,0 +1,5 @@
+<?xml version="1.0" encoding="UTF-8"?><!-- webkit-test-runner [ dumpJSConsoleLogInStdErr=true ] -->
+<?xml-stylesheet type="text/xsl" href="resources/xsl-using-external-entity.xsl"?>
+<xml>
+FAIL: XML stylesheet did not run.
+</xml>
index edd696f..345abf3 100644 (file)
@@ -3,6 +3,7 @@
 # See http://trac.webkit.org/wiki/TestExpectations for more information on this file.
 
 editing/input/focus-change-with-marked-text.html [ Pass ]
+http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml [ Pass ]
 
 # No service worker implementation for WK1
 imported/w3c/web-platform-tests/service-workers [ Skip ]
@@ -1773,7 +1774,7 @@ fetch/fetch-error-messages.html [ Crash Pass ]
 http/tests/navigation/metaredirect-subframeload.html [ Crash Pass ]
 http/tests/security/xss-DENIED-xml-external-entity.xhtml [ Pass Failure ]
 http/tests/security/xss-DENIED-xsl-external-entity-redirect.xml [ Pass Failure ]
-http/tests/security/xss-DENIED-xsl-external-entity.xml [ Pass Failure ]
+http/tests/security/xss-DENIED-xsl-external-entity.xml [ Skip ]
 imported/blink/compositing/ancestor-painted-layer-should-appear.html [ Pass ImageOnlyFailure ]
 imported/blink/compositing/invisible-subtree-compositing-and-preserves-3d.html [ Pass ImageOnlyFailure ]
 imported/blink/compositing/will-change/stacking-context-creation.html [ Pass ImageOnlyFailure ]
index 2343b51..d51e20c 100644 (file)
@@ -28,6 +28,8 @@ fast/shadow-dom/dragging-element-with-shadow-tree.html [ Pass ]
 fast/shadow-dom/dragging-element-inside-shadow-tree.html [ Pass ]
 http/tests/security/clipboard/drag-drop-html-cross-origin-iframe-in-same-origin.html [ Pass ]
 
+http/tests/security/xss-DENIED-xsl-external-entity-no-logging.xml [ Pass ]
+
 #//////////////////////////////////////////////////////////////////////////////////////////
 # End platform-specific directories.
 #//////////////////////////////////////////////////////////////////////////////////////////
@@ -92,6 +94,7 @@ webkit.org/b/178272 [ Sierra ] http/tests/media/video-play-progress.html [ Pass
 webkit.org/b/178272 [ Sierra ] http/tests/security/canvas-remote-read-remote-video-localhost.html [ Pass Timeout ]
 webkit.org/b/178272 [ Sierra ] http/tests/security/canvas-remote-read-remote-video-redirect.html [ Pass Timeout ]
 webkit.org/b/178272 [ Sierra ] http/tests/security/video-cross-origin-caching.html [ Pass Timeout ]
+http/tests/security/xss-DENIED-xsl-external-entity.xml [ Skip ]
 
 # rdar://problem/20001985
 [ Sierra ] http/tests/xmlhttprequest/range-test.html [ Failure ]