Remove 2 unnecessary virtual functions on InputType
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 5 Nov 2014 21:21:58 +0000 (21:21 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 5 Nov 2014 21:21:58 +0000 (21:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=138433

Reviewed by Andreas Kling.

Remove 2 unused virtual functions on InputType:
- valueAttributeChanged()
- updateClearButtonVisibility()

No new tests, no behavior change.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute):
(WebCore::HTMLInputElement::updateClearButtonVisibility): Deleted.
* html/HTMLInputElement.h:
* html/InputType.cpp:
(WebCore::InputType::valueAttributeChanged): Deleted.
(WebCore::InputType::updateClearButtonVisibility): Deleted.
* html/InputType.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@175639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/html/HTMLInputElement.cpp
Source/WebCore/html/HTMLInputElement.h
Source/WebCore/html/InputType.cpp
Source/WebCore/html/InputType.h

index 71ed1ec..bc06b24 100644 (file)
@@ -1,5 +1,27 @@
 2014-11-05  Chris Dumez  <cdumez@apple.com>
 
+        Remove 2 unnecessary virtual functions on InputType
+        https://bugs.webkit.org/show_bug.cgi?id=138433
+
+        Reviewed by Andreas Kling.
+
+        Remove 2 unused virtual functions on InputType:
+        - valueAttributeChanged()
+        - updateClearButtonVisibility()
+
+        No new tests, no behavior change.
+
+        * html/HTMLInputElement.cpp:
+        (WebCore::HTMLInputElement::parseAttribute):
+        (WebCore::HTMLInputElement::updateClearButtonVisibility): Deleted.
+        * html/HTMLInputElement.h:
+        * html/InputType.cpp:
+        (WebCore::InputType::valueAttributeChanged): Deleted.
+        (WebCore::InputType::updateClearButtonVisibility): Deleted.
+        * html/InputType.h:
+
+2014-11-05  Chris Dumez  <cdumez@apple.com>
+
         Re-evaluate if a repetitive timer should be throttled upon firing
         https://bugs.webkit.org/show_bug.cgi?id=138339
 
index 8759f47..a283160 100644 (file)
@@ -635,7 +635,6 @@ void HTMLInputElement::parseAttribute(const QualifiedName& name, const AtomicStr
         setFormControlValueMatchesRenderer(false);
         setNeedsValidityCheck();
         m_valueAttributeWasUpdatedAfterParsing = !m_parsingInProgress;
-        m_inputType->valueAttributeChanged();
     } else if (name == checkedAttr) {
         // Another radio button in the same group might be checked by state
         // restore. We shouldn't call setChecked() even if this has the checked
@@ -1381,11 +1380,6 @@ void HTMLInputElement::onSearch()
     dispatchEvent(Event::create(eventNames().searchEvent, true, false));
 }
 
-void HTMLInputElement::updateClearButtonVisibility()
-{
-    m_inputType->updateClearButtonVisibility();
-}
-
 void HTMLInputElement::documentDidResumeFromPageCache()
 {
     ASSERT(needsSuspensionCallback());
index a466f79..7b4faab 100644 (file)
@@ -259,8 +259,6 @@ public:
     void addSearchResult();
     void onSearch();
 
-    void updateClearButtonVisibility();
-
     virtual bool willRespondToMouseClickEvents() override;
 
 #if ENABLE(DATALIST_ELEMENT)
index c4b34b2..acaec75 100644 (file)
@@ -919,10 +919,6 @@ void InputType::requiredAttributeChanged()
 {
 }
 
-void InputType::valueAttributeChanged()
-{
-}
-
 void InputType::subtreeHasChanged()
 {
     ASSERT_NOT_REACHED();
@@ -952,10 +948,6 @@ Decimal InputType::findClosestTickMarkValue(const Decimal&)
 }
 #endif
 
-void InputType::updateClearButtonVisibility()
-{
-}
-
 bool InputType::supportsIndeterminateAppearance() const
 {
     return false;
index ba003ea..17d1253 100644 (file)
@@ -271,9 +271,7 @@ public:
     virtual void disabledAttributeChanged();
     virtual void readonlyAttributeChanged();
     virtual void requiredAttributeChanged();
-    virtual void valueAttributeChanged();
     virtual String defaultToolTip() const;
-    virtual void updateClearButtonVisibility();
 
 #if ENABLE(DATALIST_ELEMENT)
     virtual void listAttributeTargetChanged();