Test cases under fast/filesystem/workers are flaky when using JSC
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Aug 2012 22:23:12 +0000 (22:23 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 22 Aug 2012 22:23:12 +0000 (22:23 +0000)
https://bugs.webkit.org/show_bug.cgi?id=94747

Patch by Leo Yang <leoyang@rim.com> on 2012-08-22
Reviewed by Yong Li.

These test cases sometimes can't complete because the worker object
created by startWorker() has been gc'ed before the worker thread complete.
We should reference the object to avoid it being gc'ed.

* fast/filesystem/workers/async-operations.html:
* fast/filesystem/workers/file-entry-to-uri-sync.html:
* fast/filesystem/workers/file-from-file-entry-sync.html:
* fast/filesystem/workers/file-from-file-entry.html:
* fast/filesystem/workers/file-writer-empty-blob.html:
* fast/filesystem/workers/file-writer-events.html:
* fast/filesystem/workers/file-writer-gc-blob.html:
* fast/filesystem/workers/file-writer-sync-truncate-extend.html:
* fast/filesystem/workers/file-writer-sync-write-overlapped.html:
* fast/filesystem/workers/file-writer-truncate-extend.html:
* fast/filesystem/workers/file-writer-write-overlapped.html:
* fast/filesystem/workers/simple-persistent-sync.html:
* fast/filesystem/workers/simple-persistent.html:
* fast/filesystem/workers/simple-temporary-sync.html:
* fast/filesystem/workers/simple-temporary.html:
* fast/filesystem/workers/sync-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@126358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

17 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/filesystem/workers/async-operations.html
LayoutTests/fast/filesystem/workers/file-entry-to-uri-sync.html
LayoutTests/fast/filesystem/workers/file-from-file-entry-sync.html
LayoutTests/fast/filesystem/workers/file-from-file-entry.html
LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html
LayoutTests/fast/filesystem/workers/file-writer-events.html
LayoutTests/fast/filesystem/workers/file-writer-gc-blob.html
LayoutTests/fast/filesystem/workers/file-writer-sync-truncate-extend.html
LayoutTests/fast/filesystem/workers/file-writer-sync-write-overlapped.html
LayoutTests/fast/filesystem/workers/file-writer-truncate-extend.html
LayoutTests/fast/filesystem/workers/file-writer-write-overlapped.html
LayoutTests/fast/filesystem/workers/simple-persistent-sync.html
LayoutTests/fast/filesystem/workers/simple-persistent.html
LayoutTests/fast/filesystem/workers/simple-temporary-sync.html
LayoutTests/fast/filesystem/workers/simple-temporary.html
LayoutTests/fast/filesystem/workers/sync-operations.html

index 138f8af..7921def 100644 (file)
@@ -1,3 +1,31 @@
+2012-08-22  Leo Yang  <leoyang@rim.com>
+
+        Test cases under fast/filesystem/workers are flaky when using JSC
+        https://bugs.webkit.org/show_bug.cgi?id=94747
+
+        Reviewed by Yong Li.
+
+        These test cases sometimes can't complete because the worker object
+        created by startWorker() has been gc'ed before the worker thread complete.
+        We should reference the object to avoid it being gc'ed.
+
+        * fast/filesystem/workers/async-operations.html:
+        * fast/filesystem/workers/file-entry-to-uri-sync.html:
+        * fast/filesystem/workers/file-from-file-entry-sync.html:
+        * fast/filesystem/workers/file-from-file-entry.html:
+        * fast/filesystem/workers/file-writer-empty-blob.html:
+        * fast/filesystem/workers/file-writer-events.html:
+        * fast/filesystem/workers/file-writer-gc-blob.html:
+        * fast/filesystem/workers/file-writer-sync-truncate-extend.html:
+        * fast/filesystem/workers/file-writer-sync-write-overlapped.html:
+        * fast/filesystem/workers/file-writer-truncate-extend.html:
+        * fast/filesystem/workers/file-writer-write-overlapped.html:
+        * fast/filesystem/workers/simple-persistent-sync.html:
+        * fast/filesystem/workers/simple-persistent.html:
+        * fast/filesystem/workers/simple-temporary-sync.html:
+        * fast/filesystem/workers/simple-temporary.html:
+        * fast/filesystem/workers/sync-operations.html:
+
 2012-08-22  Anna Cavender  <annacc@chromium.org>
 
         Update the TextTrackCue Constructor
index fb2dbc7..8464a28 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/async-operations.js');
+worker = startWorker('../resources/async-operations.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 42ba1df..337f78a 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-entry-to-uri-sync.js');
+worker = startWorker('../resources/file-entry-to-uri-sync.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index d1cdc7e..30bf92a 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-from-file-entry-sync.js');
+worker = startWorker('../resources/file-from-file-entry-sync.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 92c4ea5..1bc9e02 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/file-from-file-entry.js');
+worker = startWorker('../resources/file-from-file-entry.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 5359db2..353c545 100644 (file)
@@ -8,7 +8,7 @@
 <div id="description"></div>
 <div id="console"></div>
 <script>
-startWorker("../resources/file-writer-empty-blob.js");
+worker = startWorker("../resources/file-writer-empty-blob.js");
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index e854867..664084d 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-events.js");
+        worker = startWorker("../resources/file-writer-events.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index 1f24449..51f0415 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-gc-blob.js");
+        worker = startWorker("../resources/file-writer-gc-blob.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index 1919b4c..f3d05f9 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-sync-truncate-extend.js");
+        worker = startWorker("../resources/file-writer-sync-truncate-extend.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index 691c228..cbbe802 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-sync-write-overlapped.js");
+        worker = startWorker("../resources/file-writer-sync-write-overlapped.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index 99854a3..c49d738 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-truncate-extend.js");
+        worker = startWorker("../resources/file-writer-truncate-extend.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index 30c7876..c059705 100644 (file)
@@ -8,7 +8,7 @@
     <div id="description"></div>
     <div id="console"></div>
     <script>
-        startWorker("../resources/file-writer-write-overlapped.js");
+        worker = startWorker("../resources/file-writer-write-overlapped.js");
     </script>
     <script src="../../js/resources/js-test-post.js"></script>
  </body>
index b9151a8..fbb4c43 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-persistent-sync.js');
+worker = startWorker('../resources/simple-persistent-sync.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 7db9341..fa57f34 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-persistent.js');
+worker = startWorker('../resources/simple-persistent.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 44ec9dc..0ac529c 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-temporary-sync.js');
+worker = startWorker('../resources/simple-temporary-sync.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 715b099..2b5bb89 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/simple-temporary.js');
+worker = startWorker('../resources/simple-temporary.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>
index 1ee0fef..4db9461 100644 (file)
@@ -4,7 +4,7 @@
 </head>
 <body>
 <script>
-startWorker('../resources/sync-operations.js');
+worker = startWorker('../resources/sync-operations.js');
 </script>
 <script src="../../js/resources/js-test-post.js"></script>
 </body>