- rolled out last two changes, they seem to cause a performance regression
authormjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Sep 2004 01:01:54 +0000 (01:01 +0000)
committermjs <mjs@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Sep 2004 01:01:54 +0000 (01:01 +0000)
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView firstRectForCharacterRange:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@7502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKit/ChangeLog
WebKit/WebView.subproj/WebHTMLView.m

index 2194aae..900d280 100644 (file)
@@ -1,5 +1,12 @@
 2004-09-09  Maciej Stachowiak  <mjs@apple.com>
 
+        - rolled out last two changes, they seem to cause a performance regression
+
+        * WebView.subproj/WebHTMLView.m:
+        (-[WebHTMLView firstRectForCharacterRange:]):
+
+2004-09-09  Maciej Stachowiak  <mjs@apple.com>
+
         - fixed build
 
         * WebView.subproj/WebHTMLView.m:
index e7eb4ee..7196e09 100644 (file)
@@ -3834,25 +3834,8 @@ static DOMRange *unionDOMRanges(DOMRange *a, DOMRange *b)
 
 - (NSRect)firstRectForCharacterRange:(NSRange)theRange
 {
-    NSLog(@"location: %d  length: %d\n", theRange.location, theRange.length);
-
-    if (![self hasMarkedText]) {
-        return NSMakeRect(0,0,0,0);
-    }
-
-    WebBridge *bridge = [self _bridge];
-
-    DOMRange *rectRange = [[bridge DOMDocument] createRange];
-    DOMRange *markedRange = [bridge markedTextDOMRange];
-    [rectRange setStart:[markedRange startContainer] :theRange.location];
-    [rectRange setEnd:[markedRange startContainer] :(theRange.location + theRange.length)];
-
-    NSRect resultRect = [self convertRect:[bridge firstRectForDOMRange:rectRange] toView:nil];
-    resultRect.origin = [[self window] convertBaseToScreen:resultRect.origin];
-
-    NSLog(@"(%d,%d) %dx%d\n", (int)resultRect.origin.x, (int)resultRect.origin.y, (int)resultRect.size.width, (int)resultRect.size.height);
-
-    return resultRect;
+    ERROR("TEXTINPUT: firstRectForCharacterRange: not yet implemented");
+    return NSMakeRect(0,0,0,0);
 }
 
 - (NSRange)selectedRange