Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting Web...
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 20 Apr 2019 00:33:20 +0000 (00:33 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 20 Apr 2019 00:33:20 +0000 (00:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=197115
<rdar://problem/49877875>

Reviewed by Joseph Pecoraro.

* inspector/agents/InspectorCPUProfilerAgent.cpp:
(WebCore::InspectorCPUProfilerAgent::willDestroyFrontendAndBackend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/agents/InspectorCPUProfilerAgent.cpp

index eec2bc9..feb0e0b 100644 (file)
@@ -1,5 +1,16 @@
 2019-04-19  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: Timelines: CPU: ensure that tracking stops when disconnecting Web Inspector
+        https://bugs.webkit.org/show_bug.cgi?id=197115
+        <rdar://problem/49877875>
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/agents/InspectorCPUProfilerAgent.cpp:
+        (WebCore::InspectorCPUProfilerAgent::willDestroyFrontendAndBackend):
+
+2019-04-19  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: REGRESSION: Elements: "Inspect Element" context menu often doesn't select that element
         https://bugs.webkit.org/show_bug.cgi?id=197091
         <rdar://problem/49953728>
index 6a2972d..cf94ca8 100644 (file)
@@ -51,6 +51,9 @@ void InspectorCPUProfilerAgent::didCreateFrontendAndBackend(FrontendRouter*, Bac
 
 void InspectorCPUProfilerAgent::willDestroyFrontendAndBackend(DisconnectReason)
 {
+    ErrorString ignored;
+    stopTracking(ignored);
+
     m_instrumentingAgents.setInspectorCPUProfilerAgent(nullptr);
 }