[ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
authormario.prada@samsung.com <mario.prada@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2013 15:17:58 +0000 (15:17 +0000)
committermario.prada@samsung.com <mario.prada@samsung.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 16 Dec 2013 15:17:58 +0000 (15:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=125587

Reviewed by Chris Fleizach.

Source/WebCore:

Exposed accessibility objects with article role with the proper
AtkRole, to be provided by the next stable release of ATK.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):

Tools:

Add mappings to DRT & WKTR for article roles.

* DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

LayoutTests:

Update test to unskip article objects and update expectations.

* accessibility/aria-mappings-expected.txt:
* platform/gtk/accessibility/roles-exposed-expected.txt:
* platform/gtk/accessibility/roles-exposed.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@160637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/aria-mappings-expected.txt
LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt
LayoutTests/platform/gtk/accessibility/roles-exposed.html
Source/WebCore/ChangeLog
Source/WebCore/accessibility/atk/WebKitAccessibleWrapperAtk.cpp
Tools/ChangeLog
Tools/DumpRenderTree/atk/AccessibilityUIElementAtk.cpp
Tools/WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp

index 12f7e01..8a1537d 100644 (file)
@@ -1,3 +1,16 @@
+2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
+        https://bugs.webkit.org/show_bug.cgi?id=125587
+
+        Reviewed by Chris Fleizach.
+
+        Update test to unskip article objects and update expectations.
+
+        * accessibility/aria-mappings-expected.txt:
+        * platform/gtk/accessibility/roles-exposed-expected.txt:
+        * platform/gtk/accessibility/roles-exposed.html:
+
 2013-11-27  Sergio Villar Senin  <svillar@igalia.com>
 
         [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
index 36d6328..61a1ebd 100644 (file)
@@ -25,7 +25,7 @@ Role for 'alertdialog' div is: AXRole: AXAlert
 
 
 role="article" is a  section of a page that consists of a composition that forms an independent part of a document, page, or site
-Role for 'article' div is: AXRole: AXDocument
+Role for 'article' div is: AXRole: AXArticle
 
 
 role="dialog" is an application window that is designed to interrupt the current processing of an application in order to prompt the user to enter information or require a response.
index 0235fb2..543c737 100644 (file)
@@ -9,6 +9,9 @@ PASS: a[href]
 PASS: address
       AXRole: AXLandmarkContentInfo
       
+PASS: article
+      AXRole: AXArticle
+      
 PASS: aside
       AXRole: AXLandmarkComplementary
       
@@ -231,6 +234,9 @@ PASS: div[role=alertdialog]
 PASS: div[role=application]
       AXRole: AXEmbedded
       
+PASS: div[role=article]
+      AXRole: AXArticle
+      
 PASS: div[role=banner]
       AXRole: AXLandmarkBanner
       
index b66a30b..1fdb694 100644 (file)
@@ -12,7 +12,7 @@
 <!-- skipped ATK: not focusable <abbr data-role="" class="ex">X</abbr>-->
 <address data-role="AXLandmarkContentInfo" class="ex">X</address>
 <!-- skipped <area> -->
-<!-- http://webkit.org/b/125493 <article data-role="AXArticle" class="ex">X</article>-->
+<article data-role="AXArticle" class="ex">X</article>
 <aside data-role="AXLandmarkComplementary" class="ex">X</aside>
 <!-- http://webkit.org/b/125491 <audio data-role="" class="ex">X</audio>-->
 <!-- skipped ATK: not focusable <b data-role="" class="ex">X</b>-->
 <div role="alert"                    data-role="AXAlert" class="ex">X</div>
 <div role="alertdialog"              data-role="AXAlert" class="ex">X</div>
 <div role="application"              data-role="AXEmbedded" class="ex">X</div>
-<!-- http://webkit.org/b/125493 <div role="article"                  data-role="AXArticle" class="ex">X</div>-->
+<div role="article"                  data-role="AXArticle" class="ex">X</div>
 <div role="banner"                   data-role="AXLandmarkBanner" class="ex">X</div>
 <div role="button"                   data-role="AXButton" class="ex">X</div>
 <div role="checkbox"                 data-role="AXCheckBox" class="ex">X</div>
index d568553..9921976 100644 (file)
@@ -1,3 +1,16 @@
+2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
+        https://bugs.webkit.org/show_bug.cgi?id=125587
+
+        Reviewed by Chris Fleizach.
+
+        Exposed accessibility objects with article role with the proper
+        AtkRole, to be provided by the next stable release of ATK.
+
+        * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+        (atkRole):
+
 2013-11-27  Sergio Villar Senin  <svillar@igalia.com>
 
         [CSS Grid Layout] Fix the preferred logical widths code to work with spanning grid items
index 361da2e..35681b3 100644 (file)
@@ -657,8 +657,11 @@ static AtkRole atkRole(AccessibilityRole role)
         return ATK_ROLE_IMAGE;
     case ListMarkerRole:
         return ATK_ROLE_TEXT;
-    case DocumentRole:
     case DocumentArticleRole:
+#if ATK_CHECK_VERSION(2, 11, 3)
+        return ATK_ROLE_ARTICLE;
+#endif
+    case DocumentRole:
         return ATK_ROLE_DOCUMENT_FRAME;
     case HeadingRole:
         return ATK_ROLE_HEADING;
index c394d06..f45b883 100644 (file)
@@ -1,3 +1,15 @@
+2013-12-16  Mario Sanchez Prada  <mario.prada@samsung.com>
+
+        [ATK] Expose accessibility objects with ATK_ROLE_ARTICLE
+        https://bugs.webkit.org/show_bug.cgi?id=125587
+
+        Reviewed by Chris Fleizach.
+
+        Add mappings to DRT & WKTR for article roles.
+
+        * DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
+        * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
 2013-12-16  Dániel Bátyai  <dbatyai.u-szeged@partner.samsung.com>
 
         [FTL] Allow EFL to build FTL with the build-jsc script.
index f1387ae..f2a4376 100644 (file)
@@ -322,6 +322,10 @@ const char* roleToString(AtkObject* object)
         return "AXWindow";
     case ATK_ROLE_UNKNOWN:
         return "AXUnknown";
+#if ATK_CHECK_VERSION(2, 11, 3)
+    case ATK_ROLE_ARTICLE:
+        return "AXArticle";
+#endif
     default:
         // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
         // our DRT isn't properly handling.
index 2f2030d..312e7cf 100644 (file)
@@ -411,6 +411,10 @@ const gchar* roleToString(AtkObject* object)
         return "AXWindow";
     case ATK_ROLE_UNKNOWN:
         return "AXUnknown";
+#if ATK_CHECK_VERSION(2, 11, 3)
+    case ATK_ROLE_ARTICLE:
+        return "AXArticle";
+#endif
     default:
         // We want to distinguish ATK_ROLE_UNKNOWN from a known AtkRole which
         // our DRT isn't properly handling.