2010-09-22 Adam Barth <abarth@webkit.org>
authorabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Sep 2010 04:19:47 +0000 (04:19 +0000)
committerabarth@webkit.org <abarth@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 23 Sep 2010 04:19:47 +0000 (04:19 +0000)
        Reviewed by John Sullivan.

        New review-page design doesn't include name of reviewer
        https://bugs.webkit.org/show_bug.cgi?id=46271

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@68120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

BugsSite/ChangeLog
BugsSite/PrettyPatch/PrettyPatch.rb
BugsSite/code-review.js

index 44cea2e..cfca68c 100644 (file)
@@ -1,5 +1,15 @@
 2010-09-22  Adam Barth  <abarth@webkit.org>
 
+        Reviewed by John Sullivan.
+
+        New review-page design doesn't include name of reviewer
+        https://bugs.webkit.org/show_bug.cgi?id=46271
+
+        * PrettyPatch/PrettyPatch.rb:
+        * code-review.js:
+
+2010-09-22  Adam Barth  <abarth@webkit.org>
+
         Fix typo in CSS.
 
         * PrettyPatch/PrettyPatch.rb:
index 67daa00..0e7c3ae 100644 (file)
@@ -312,7 +312,7 @@ body {
 }
 </style>
 <script src="https://ajax.googleapis.com/ajax/libs/jquery/1.4.2/jquery.min.js"></script> 
-<script src="code-review.js?version=12"></script> 
+<script src="code-review.js?version=13"></script> 
 EOF
 
     def self.revisionOrDescription(string)
index 8339d61..4064c89 100644 (file)
       $('<span class="commitQueue"> cq: ' + flag_control + '</span>'));
 
     details.find('#flags select').each(function() {
-      findControlForFlag(this).attr('selectedIndex', $(this).attr('selectedIndex'));
+      var requestee = $(this).parent().siblings('td:first-child').text().trim();
+      if (requestee.length) {
+        // Remove trailing ':'.
+        requestee = requestee.substr(0, requestee.length - 1);
+        requestee = ' (' + requestee + ')';
+      }
+      var control = findControlForFlag(this)
+      control.attr('selectedIndex', $(this).attr('selectedIndex'));
+      control.parent().prepend(requestee);
     });
   }