CodeBlock always visits its unlinked code twice
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Feb 2016 07:29:35 +0000 (07:29 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 22 Feb 2016 07:29:35 +0000 (07:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=154494

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2016-02-21
Reviewed by Saam Barati.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitChildren):
The unlinked code is always visited in stronglyVisitStrongReferences.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@196896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/bytecode/CodeBlock.cpp

index e45edc7..6d0414f 100644 (file)
@@ -1,3 +1,14 @@
+2016-02-21  Joseph Pecoraro  <pecoraro@apple.com>
+
+        CodeBlock always visits its unlinked code twice
+        https://bugs.webkit.org/show_bug.cgi?id=154494
+
+        Reviewed by Saam Barati.
+
+        * bytecode/CodeBlock.cpp:
+        (JSC::CodeBlock::visitChildren):
+        The unlinked code is always visited in stronglyVisitStrongReferences.
+
 2016-02-21  Brian Burg  <bburg@apple.com>
 
         Web Inspector: add 'Automation' protocol domain and generate its backend classes separately in WebKit2
index d944ae3..bb399bf 100644 (file)
@@ -2486,8 +2486,6 @@ void CodeBlock::visitChildren(SlotVisitor& visitor)
     if (m_instructions.size())
         visitor.reportExtraMemoryVisited(m_instructions.size() * sizeof(Instruction) / m_instructions.refCount());
 
-    visitor.append(&m_unlinkedCode);
-
     stronglyVisitStrongReferences(visitor);
     stronglyVisitWeakReferences(visitor);