Unreviewed, rolling out r173335.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Sep 2014 07:07:43 +0000 (07:07 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 6 Sep 2014 07:07:43 +0000 (07:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=136597

Broke webgl/1.0.2/conformance/glsl/misc/shader-varying-
packing-restrictions.html (Requested by ap on #webkit).

Reverted changeset:

"Remove statically used varyings from packing restrictions
check."
https://bugs.webkit.org/show_bug.cgi?id=136585
http://trac.webkit.org/changeset/173335

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/mac/TestExpectations
Source/ThirdParty/ANGLE/ChangeLog
Source/ThirdParty/ANGLE/src/compiler/translator/Compiler.cpp

index 2326ee0..ba5fffa 100644 (file)
@@ -1,3 +1,18 @@
+2014-09-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r173335.
+        https://bugs.webkit.org/show_bug.cgi?id=136597
+
+        Broke webgl/1.0.2/conformance/glsl/misc/shader-varying-
+        packing-restrictions.html (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "Remove statically used varyings from packing restrictions
+        check."
+        https://bugs.webkit.org/show_bug.cgi?id=136585
+        http://trac.webkit.org/changeset/173335
+
 2014-09-05  Simon Fraser  <simon.fraser@apple.com>
 
         Change this test not to use a percentage width, and to use a non-blurred
index 0056c86..23f09a0 100755 (executable)
@@ -642,6 +642,9 @@ webgl/1.0.1/conformance/limits/gl-max-texture-dimensions.html [ Pass Failure ]
 webgl/1.0.2/conformance/textures/texture-size.html [ Pass Failure ]
 webgl/1.0.2/conformance/limits/gl-max-texture-dimensions.html [ Pass Failure ]
 
+# Test is faulty, skipping for now
+webgl/1.0.2/conformance/ogles/GL/build/build_009_to_016.html [ Failure ]
+
 # Skipping all webgl conformance tests on trunk
 webgl/conformance
 
index 368f35d..9719410 100644 (file)
@@ -1,3 +1,18 @@
+2014-09-06  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r173335.
+        https://bugs.webkit.org/show_bug.cgi?id=136597
+
+        Broke webgl/1.0.2/conformance/glsl/misc/shader-varying-
+        packing-restrictions.html (Requested by ap on #webkit).
+
+        Reverted changeset:
+
+        "Remove statically used varyings from packing restrictions
+        check."
+        https://bugs.webkit.org/show_bug.cgi?id=136585
+        http://trac.webkit.org/changeset/173335
+
 2014-09-05  Roger Fong  <roger_fong@apple.com>
 
         Remove statically used varyings from packing restrictions check.
index 7025a59..c3111c1 100644 (file)
@@ -460,13 +460,7 @@ bool TCompiler::enforcePackingRestrictions()
         return false;
     }
 
-    TVariableInfoList nonStaticallyUsedVaryings;
-
-    for (TVariableInfo info : varyings) {
-        if (!info.staticUse)
-            nonStaticallyUsedVaryings.push_back(info);
-    }
-    success = packer.CheckVariablesWithinPackingLimits(maxVaryingVectors, nonStaticallyUsedVaryings);
+    success = packer.CheckVariablesWithinPackingLimits(maxVaryingVectors, varyings);
 
     if (!success) {
         infoSink.info.prefix(EPrefixError);