[Qt][WK2] setVisibleContentsRect is not thread safe
authoryael.aharon@nokia.com <yael.aharon@nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Apr 2012 14:12:51 +0000 (14:12 +0000)
committeryael.aharon@nokia.com <yael.aharon@nokia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Apr 2012 14:12:51 +0000 (14:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=85060

Reviewed by Noam Rosenthal.

Don't call WebLayerTreeRenderer::setVisibleContentsRect directly. Use bind() instead.

* UIProcess/LayerTreeHostProxy.cpp:
(WebKit::LayerTreeHostProxy::setVisibleContentsRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@115426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp

index 16f6fce..868b9d6 100644 (file)
@@ -1,3 +1,15 @@
+2012-04-27  Yael Aharon  <yael.aharon@nokia.com>
+
+        [Qt][WK2] setVisibleContentsRect is not thread safe
+        https://bugs.webkit.org/show_bug.cgi?id=85060
+
+        Reviewed by Noam Rosenthal.
+
+        Don't call WebLayerTreeRenderer::setVisibleContentsRect directly. Use bind() instead.
+
+        * UIProcess/LayerTreeHostProxy.cpp:
+        (WebKit::LayerTreeHostProxy::setVisibleContentsRect):
+
 2012-04-26  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [SOUP] Add a way to register custom uri schemes in WebKit2
index be53743..7ac0960 100644 (file)
@@ -129,7 +129,7 @@ void LayerTreeHostProxy::setContentsSize(const FloatSize& contentsSize)
 
 void LayerTreeHostProxy::setVisibleContentsRect(const IntRect& rect, float scale, const FloatPoint& trajectoryVector)
 {
-    m_renderer->setVisibleContentsRect(rect, scale);
+    dispatchUpdate(bind(&WebLayerTreeRenderer::setVisibleContentsRect, m_renderer.get(), rect, scale));
     m_drawingAreaProxy->page()->process()->send(Messages::LayerTreeHost::SetVisibleContentsRect(rect, scale, trajectoryVector), m_drawingAreaProxy->page()->pageID());
 }