[chromium] Send wheel events to main thread even if we think nothing is scrollable
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2012 04:27:18 +0000 (04:27 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Mar 2012 04:27:18 +0000 (04:27 +0000)
https://bugs.webkit.org/show_bug.cgi?id=82408

Patch by James Robinson <jamesr@chromium.org> on 2012-03-27
Reviewed by Adrienne Walker.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@112363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebCompositorInputHandlerImpl.cpp

index 2805c6c..1a4fcee 100644 (file)
@@ -1,3 +1,13 @@
+2012-03-27  James Robinson  <jamesr@chromium.org>
+
+        [chromium] Send wheel events to main thread even if we think nothing is scrollable
+        https://bugs.webkit.org/show_bug.cgi?id=82408
+
+        Reviewed by Adrienne Walker.
+
+        * src/WebCompositorInputHandlerImpl.cpp:
+        (WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
+
 2012-03-27  Nat Duca  <nduca@chromium.org>
 
         [chromium] Route monotonic clock up from compositor
index 9a14e8e..2b52d99 100644 (file)
@@ -188,7 +188,9 @@ WebCompositorInputHandlerImpl::EventDisposition WebCompositorInputHandlerImpl::h
             return DidHandle;
         }
         case CCInputHandlerClient::ScrollIgnored:
-            return DropEvent;
+            // FIXME: This should be DropEvent, but in cases where we fail to properly sync scrollability it's safer to send the
+            // event to the main thread. Change back to DropEvent once we have synchronization bugs sorted out.
+            return DidNotHandle; 
         case CCInputHandlerClient::ScrollFailed:
             return DidNotHandle;
         }