https://bugs.webkit.org/show_bug.cgi?id=138771
Reviewed by Chris Fleizach.
Source/WebCore:
Add BlockquoteRole and assigns it to blockquote elements. Make
corresponding changes to platform role mappings: ATK_ROLE_BLOCK_QUOTE
for GTK and EFL; AXGroup (which was being used already) for the Mac.
No new tests are required. Instead, updated the existing expectations
to reflect the new mapping.
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::isBlockquote):
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
Tools:
Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
* WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
LayoutTests:
Updated the expectations for GTK and EFL as there is a new role
being used. The Mac expectations were not updated because the
new role on that platform continues to be to AXGroup.
* platform/efl/accessibility/roles-exposed-expected.txt: Updated
* platform/gtk/accessibility/roles-exposed-expected.txt: Updated
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@176162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2014-11-16 Joanmarie Diggs <jdiggs@igalia.com>
+
+ AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
+ https://bugs.webkit.org/show_bug.cgi?id=138771
+
+ Reviewed by Chris Fleizach.
+
+ Updated the expectations for GTK and EFL as there is a new role
+ being used. The Mac expectations were not updated because the
+ new role on that platform continues to be to AXGroup.
+
+ * platform/efl/accessibility/roles-exposed-expected.txt: Updated
+ * platform/gtk/accessibility/roles-exposed-expected.txt: Updated
+
2014-11-16 Chris Dumez <cdumez@apple.com>
Crash when setting 'alt' CSS property to inherit or initial
AXRole: AXLandmarkComplementary
blockquote
- AXRole: AXGroup
+ AXRole: AXBlockquote
button
AXRole: AXButton
AXRole: AXLandmarkComplementary
blockquote
- AXRole: AXGroup
+ AXRole: AXBlockquote
button
AXRole: AXButton
+2014-11-16 Joanmarie Diggs <jdiggs@igalia.com>
+
+ AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
+ https://bugs.webkit.org/show_bug.cgi?id=138771
+
+ Reviewed by Chris Fleizach.
+
+ Add BlockquoteRole and assigns it to blockquote elements. Make
+ corresponding changes to platform role mappings: ATK_ROLE_BLOCK_QUOTE
+ for GTK and EFL; AXGroup (which was being used already) for the Mac.
+
+ No new tests are required. Instead, updated the existing expectations
+ to reflect the new mapping.
+
+ * accessibility/AccessibilityNodeObject.cpp:
+ (WebCore::AccessibilityNodeObject::determineAccessibilityRole):
+ * accessibility/AccessibilityObject.cpp:
+ (WebCore::AccessibilityObject::isBlockquote):
+ * accessibility/AccessibilityObject.h:
+ * accessibility/AccessibilityRenderObject.cpp:
+ (WebCore::AccessibilityRenderObject::determineAccessibilityRole):
+ * accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
+ (atkRole):
+ * accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
+ (createAccessibilityRoleMap):
+
2014-11-16 Chris Dumez <cdumez@apple.com>
Crash when setting 'alt' CSS property to inherit or initial
return TextAreaRole;
if (headingLevel())
return HeadingRole;
+ if (node()->hasTagName(blockquoteTag))
+ return BlockquoteRole;
if (node()->hasTagName(divTag))
return DivRole;
if (node()->hasTagName(pTag))
bool AccessibilityObject::isBlockquote() const
{
- return node() && node()->hasTagName(blockquoteTag);
+ return roleValue() == BlockquoteRole;
}
bool AccessibilityObject::isTextControl() const
ApplicationStatusRole,
ApplicationTimerRole,
AudioRole,
+ BlockquoteRole,
BrowserRole,
BusyIndicatorRole,
ButtonRole,
if (node && node->hasTagName(addressTag))
return LandmarkContentInfoRole;
+ if (node && node->hasTagName(blockquoteTag))
+ return BlockquoteRole;
+
#if ENABLE(VIDEO)
if (is<HTMLVideoElement>(node))
return VideoRole;
case LabelRole:
case LegendRole:
return ATK_ROLE_LABEL;
+ case BlockquoteRole:
+#if ATK_CHECK_VERSION(2, 11, 3)
+ return ATK_ROLE_BLOCK_QUOTE;
+#endif
case DivRole:
return ATK_ROLE_SECTION;
case FooterRole:
{ MathElementRole, NSAccessibilityGroupRole },
{ AudioRole, NSAccessibilityGroupRole },
{ VideoRole, NSAccessibilityGroupRole },
- { HorizontalRuleRole, NSAccessibilitySplitterRole }
+ { HorizontalRuleRole, NSAccessibilitySplitterRole },
+ { BlockquoteRole, NSAccessibilityGroupRole }
};
AccessibilityRoleMap& roleMap = *new AccessibilityRoleMap;
+2014-11-16 Joanmarie Diggs <jdiggs@igalia.com>
+
+ AX: [ATK] Expose the blockquote element using ATK_ROLE_BLOCK_QUOTE
+ https://bugs.webkit.org/show_bug.cgi?id=138771
+
+ Reviewed by Chris Fleizach.
+
+ Add mapping for ATK_ROLE_BLOCK_QUOTE in roleToString()
+
+ * WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
+
2014-11-15 Joanmarie Diggs <jdiggs@igalia.com>
AX: [ATK] Video and audio elements should be exposed using ATK's video and audio roles.
return "AXArticle";
case ATK_ROLE_AUDIO:
return "AXAudio";
+ case ATK_ROLE_BLOCK_QUOTE:
+ return "AXBlockquote";
case ATK_ROLE_DEFINITION:
return "AXDefinition";
case ATK_ROLE_LOG: