[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https...
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 01:25:52 +0000 (01:25 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 01:25:52 +0000 (01:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 4.

Add some additional temporary logging info to determine if the time out value passed to the timer is right.
Once the bug is determined and fixed, we should remove all logging added in this patch.

* UIProcess/WebAuthentication/AuthenticatorManager.cpp:
(WebKit::AuthenticatorManager::initTimeOutTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebAuthentication/AuthenticatorManager.cpp

index 07509fc..98f83e9 100644 (file)
@@ -1,3 +1,18 @@
+2018-12-18  Jiewen Tan  <jiewen_tan@apple.com>
+
+        [Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
+        https://bugs.webkit.org/show_bug.cgi?id=192061
+
+        Reviewed by Dewei Zhu.
+
+        Part 4.
+
+        Add some additional temporary logging info to determine if the time out value passed to the timer is right.
+        Once the bug is determined and fixed, we should remove all logging added in this patch.
+
+        * UIProcess/WebAuthentication/AuthenticatorManager.cpp:
+        (WebKit::AuthenticatorManager::initTimeOutTimer):
+
 2018-12-18  Sihui Liu  <sihui_liu@apple.com>
 
         Clean up IndexedDB files between tests
index c1a6832..7e9cf7f 100644 (file)
@@ -226,7 +226,7 @@ void AuthenticatorManager::initTimeOutTimer(const std::optional<unsigned>& timeO
 
     unsigned timeOutInMsValue = std::min(maxTimeOutValue, timeOutInMs.value_or(maxTimeOutValue));
     // FIXME(192061)
-    LOG_ERROR("Start timer.");
+    LOG_ERROR("Start timer. %d", timeOutInMsValue);
     m_requestTimeOutTimer.startOneShot(Seconds::fromMilliseconds(timeOutInMsValue));
 }