[Mac] Can't drag full-screen video to another monitor
authorjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Nov 2013 00:57:51 +0000 (00:57 +0000)
committerjer.noble@apple.com <jer.noble@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 23 Nov 2013 00:57:51 +0000 (00:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=124798

Reviewed by Geoffrey Garen.

Source/WebCore:

Make full screen windows movable by default. Previously, we wanted non-movable full screen
windows since they were in the same space and were just placed atop non-full screen windows.
Now that all our supported Mac platforms have explicit full screen support, we can remove this
non-movable restriction.

* platform/mac/WebCoreFullScreenWindow.mm:
(-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):

Source/WebKit2:

Make full screen windows resizable by default. This allows the window to be resized when
moved between monitors with different resolutions.

* UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@159722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/mac/WebCoreFullScreenWindow.mm
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/mac/WKView.mm

index ac36841..5ac6828 100644 (file)
@@ -1,3 +1,18 @@
+2013-11-22  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Can't drag full-screen video to another monitor
+        https://bugs.webkit.org/show_bug.cgi?id=124798
+
+        Reviewed by Geoffrey Garen.
+
+        Make full screen windows movable by default. Previously, we wanted non-movable full screen
+        windows since they were in the same space and were just placed atop non-full screen windows.
+        Now that all our supported Mac platforms have explicit full screen support, we can remove this
+        non-movable restriction.
+
+        * platform/mac/WebCoreFullScreenWindow.mm:
+        (-[WebCoreFullScreenWindow initWithContentRect:styleMask:backing:defer:]):
+
 2013-11-22  Brent Fulgham  <bfulgham@apple.com>
 
         [Win] Clean up ColorSpace handling in Windows code
index 858be09..520292c 100644 (file)
@@ -42,7 +42,6 @@
     [self setAcceptsMouseMovedEvents:YES];
     [self setReleasedWhenClosed:NO];
     [self setHasShadow:NO];
-    [self setMovable:NO];
 
     return self;
 }
index 817f379..616c300 100644 (file)
@@ -1,3 +1,16 @@
+2013-11-22  Jer Noble  <jer.noble@apple.com>
+
+        [Mac] Can't drag full-screen video to another monitor
+        https://bugs.webkit.org/show_bug.cgi?id=124798
+
+        Reviewed by Geoffrey Garen.
+
+        Make full screen windows resizable by default. This allows the window to be resized when
+        moved between monitors with different resolutions.
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView createFullScreenWindow]):
+
 2013-11-22  Benjamin Poulain  <bpoulain@apple.com>
 
         [WK2] Another build fix for NetworkProcess on iOS
index 7d11631..5779b1f 100644 (file)
@@ -3235,7 +3235,7 @@ static NSString *pathWithUniqueFilenameForPath(NSString *path)
 #else
     NSRect contentRect = [[NSScreen mainScreen] frame];
 #endif
-    return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:NSBorderlessWindowMask backing:NSBackingStoreBuffered defer:NO] autorelease];
+    return [[[WebCoreFullScreenWindow alloc] initWithContentRect:contentRect styleMask:(NSBorderlessWindowMask | NSResizableWindowMask) backing:NSBackingStoreBuffered defer:NO] autorelease];
 #else
     return nil;
 #endif