[WinCairo] Make it easier to enable/disable GStreamer.
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Sep 2014 09:45:01 +0000 (09:45 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 15 Sep 2014 09:45:01 +0000 (09:45 +0000)
https://bugs.webkit.org/show_bug.cgi?id=135766

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-09-15
Reviewed by Brent Fulgham.

Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.

Source/WebCore:

* WebCore.vcxproj/WebCoreDebugWinCairo.props: Import GStreamer property file.
* WebCore.vcxproj/WebCoreReleaseWinCairo.props: Ditto.

Source/WebKit:

* WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Import GStreamer property file.
* WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Ditto.

Source/WTF:

* WTF.vcxproj/WTFDebugWinCairo.props: Import GStreamer property file.
* WTF.vcxproj/WTFReleaseWinCairo.props: Ditto.
* wtf/Platform.h: Enable GStreamer if ENABLE(GSTREAMER_WINCAIRO) is true, otherwise use Media Foundation.

Tools:

* WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.

WebKitLibraries:

* win/tools/vsprops/GStreamerCommon.props: Add user macro ENABLE_GSTREAMER_WINCAIRO.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@173616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
Source/WTF/ChangeLog
Source/WTF/WTF.vcxproj/WTFDebugWinCairo.props
Source/WTF/WTF.vcxproj/WTFReleaseWinCairo.props
Source/WTF/wtf/Platform.h
Source/WebCore/ChangeLog
Source/WebCore/WebCore.vcxproj/WebCoreDebugWinCairo.props
Source/WebCore/WebCore.vcxproj/WebCoreReleaseWinCairo.props
Source/WebKit/ChangeLog
Source/WebKit/WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props
Source/WebKit/WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props
Tools/ChangeLog
Tools/WinLauncher/WinMain.cpp
WebKitLibraries/ChangeLog
WebKitLibraries/win/tools/vsprops/GStreamerCommon.props

index e9c675a..4ad0b57 100644 (file)
@@ -1,3 +1,16 @@
+2014-09-15  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Make it easier to enable/disable GStreamer.
+        https://bugs.webkit.org/show_bug.cgi?id=135766
+
+        Reviewed by Brent Fulgham.
+
+        Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
+
+        * WTF.vcxproj/WTFDebugWinCairo.props: Import GStreamer property file.
+        * WTF.vcxproj/WTFReleaseWinCairo.props: Ditto.
+        * wtf/Platform.h: Enable GStreamer if ENABLE(GSTREAMER_WINCAIRO) is true, otherwise use Media Foundation.
+
 2014-09-10  Jon Honeycutt  <jhoneycutt@apple.com>
 
         Re-add the request autocomplete feature
index 9819644..406c6c6 100644 (file)
@@ -7,6 +7,7 @@
     <Import Project="WTFCommon.props" />
     <Import Project="WTFCFLite.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
   </ImportGroup>
   <PropertyGroup />
   <PropertyGroup />
index c5b996f..7c37936 100644 (file)
@@ -7,6 +7,7 @@
     <Import Project="WTFCommon.props" />
     <Import Project="WTFCFLite.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
   </ImportGroup>
   <PropertyGroup />
   <ItemDefinitionGroup>
index 24521fd..0e0cede 100644 (file)
 #endif
 
 #if ENABLE(VIDEO) && PLATFORM(WIN_CAIRO)
+#if ENABLE(GSTREAMER_WINCAIRO)
+#define WTF_USE_MEDIA_FOUNDATION 0
+#define WTF_USE_GLIB 1
+#define WTF_USE_GSTREAMER 1
+#else
 #define WTF_USE_MEDIA_FOUNDATION 1
 #endif
+#endif
 
 #if PLATFORM(WIN_CAIRO)
 #define WTF_USE_TEXTURE_MAPPER 1
index 30888f1..d59e52d 100644 (file)
@@ -1,3 +1,15 @@
+2014-09-15  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Make it easier to enable/disable GStreamer.
+        https://bugs.webkit.org/show_bug.cgi?id=135766
+
+        Reviewed by Brent Fulgham.
+
+        Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
+
+        * WebCore.vcxproj/WebCoreDebugWinCairo.props: Import GStreamer property file.
+        * WebCore.vcxproj/WebCoreReleaseWinCairo.props: Ditto.
+
 2014-09-12  Sergio Villar Senin  <svillar@igalia.com>
 
         [CSS Grid Layout] Crash at CSSParser::parseGridTemplateRowsAndAreas
index fc08d3a..5f7ba75 100644 (file)
@@ -6,6 +6,7 @@
     <Import Project="$(WebKit_Libraries)\tools\vsprops\debug.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\debug_wincairo.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
     <Import Project="WebCoreCommon.props" />
     <Import Project="WebCoreCairo.props" />
     <Import Project="WebCoreCURL.props" />
index a977007..9627457 100644 (file)
@@ -5,6 +5,7 @@
     <Import Project="$(WebKit_Libraries)\tools\vsprops\common.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\release.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
     <Import Project="WebCoreCommon.props" />
     <Import Project="WebCoreCairo.props" />
     <Import Project="WebCoreCURL.props" />
index 8fefb05..f14463f 100644 (file)
@@ -1,3 +1,15 @@
+2014-09-15  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Make it easier to enable/disable GStreamer.
+        https://bugs.webkit.org/show_bug.cgi?id=135766
+
+        Reviewed by Brent Fulgham.
+
+        Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
+
+        * WebKit.vcxproj/WebKit/WebKitDebugWinCairo.props: Import GStreamer property file.
+        * WebKit.vcxproj/WebKit/WebKitReleaseWinCairo.props: Ditto.
+
 2014-09-06  Darin Adler  <darin@apple.com>
 
         Make updates suggested by new version of Xcode
index 637c472..0fcb2a7 100644 (file)
@@ -6,6 +6,7 @@
     <Import Project="$(WebKit_Libraries)\tools\vsprops\debug.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\cURL.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
     <Import Project="WebKitCommon.props" />
     <Import Project="WebKitDirectX.props" />
     <Import Project="WebKitCFLite.props" />
index 8434c4c..2f1668c 100644 (file)
@@ -6,6 +6,7 @@
     <Import Project="$(WebKit_Libraries)\tools\vsprops\release.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\WinCairo.props" />
     <Import Project="$(WebKit_Libraries)\tools\vsprops\cURL.props" />
+    <Import Project="$(WebKit_Libraries)\tools\vsprops\GStreamerCommon.props" />
     <Import Project="WebKitCFLite.props" />
     <Import Project="WebKitCommon.props" />
     <Import Project="WebKitDirectX.props" />
index 601b102..2ab944e 100644 (file)
@@ -1,3 +1,14 @@
+2014-09-15  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Make it easier to enable/disable GStreamer.
+        https://bugs.webkit.org/show_bug.cgi?id=135766
+
+        Reviewed by Brent Fulgham.
+
+        Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
+
+        * WinLauncher/WinMain.cpp: Compile fix when GStreamer is enabled.
+
 2014-09-12  Brian J. Burg  <burg@cs.washington.edu>
 
         Web Inspector: remind about rebaselining generator test results
index 10b0bc2..6c7922c 100644 (file)
 #include "WinLauncherWebHost.h"
 #include "Common.cpp"
 
+#if USE(GLIB)
+#include <glib.h>
+#endif
+
 int WINAPI wWinMain(HINSTANCE, HINSTANCE, PWSTR, int nCmdShow)
 {
 #ifdef _CRTDBG_MAP_ALLOC
index 5b4d438..34c0169 100644 (file)
@@ -1,3 +1,14 @@
+2014-09-15  peavo@outlook.com  <peavo@outlook.com>
+
+        [WinCairo] Make it easier to enable/disable GStreamer.
+        https://bugs.webkit.org/show_bug.cgi?id=135766
+
+        Reviewed by Brent Fulgham.
+
+        Make it possible to enable/disable GStreamer by editing the new user macro ENABLE_GSTREAMER_WINCAIRO.
+
+        * win/tools/vsprops/GStreamerCommon.props: Add user macro ENABLE_GSTREAMER_WINCAIRO.
+
 2014-09-08  Eva Balazsfalvi  <evab.u-szeged@partner.samsung.com>
 
         Remove FILTERS flag
index 16e12fe..198cb12 100644 (file)
@@ -1,8 +1,24 @@
-<?xml version="1.0" encoding="utf-8"?>\r
+<?xml version="1.0" encoding="utf-8"?>\r
 <Project ToolsVersion="12.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">\r
+  <ImportGroup Label="PropertySheets">\r
+    <Import Project="GStreamer32.props" Condition="$(Platform)=='Win32'" />\r
+    <Import Project="GStreamer64.props" Condition="$(Platform)=='x64'" />\r
+  </ImportGroup>\r
+  <PropertyGroup Label="UserMacros">\r
+    <ENABLE_GSTREAMER_WINCAIRO></ENABLE_GSTREAMER_WINCAIRO>\r
+  </PropertyGroup>\r
   <ItemDefinitionGroup>\r
-    <Link>\r
+    <ClCompile>\r
+      <PreprocessorDefinitions>$(ENABLE_GSTREAMER_WINCAIRO);%(PreprocessorDefinitions)</PreprocessorDefinitions>\r
+    </ClCompile>\r
+    <Link Condition="$(ENABLE_GSTREAMER_WINCAIRO)=='ENABLE_GSTREAMER_WINCAIRO'">\r
       <AdditionalDependencies>gstpbutils-1.0.lib;gstaudio-1.0.lib;gstbase-1.0.lib;gstvideo-1.0.lib;gobject-2.0.lib;gstapp-1.0.lib;glib-2.0.lib;gstreamer-1.0.lib;gsttag-1.0.lib;gio-2.0.lib;%(AdditionalDependencies)</AdditionalDependencies>\r
     </Link>\r
   </ItemDefinitionGroup>\r
+  <ItemGroup>\r
+    <BuildMacro Include="ENABLE_GSTREAMER_WINCAIRO">\r
+      <Value>$(ENABLE_GSTREAMER_WINCAIRO)</Value>\r
+      <EnvironmentVariable>true</EnvironmentVariable>\r
+    </BuildMacro>\r
+  </ItemGroup>\r
 </Project>
\ No newline at end of file