Address a small FIXME in IDB code.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Jul 2016 00:15:58 +0000 (00:15 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Jul 2016 00:15:58 +0000 (00:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=159999

Reviewed by Andy Estes.

No new tests (No behavior change).

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):

* Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
(WebCore::IDBResourceIdentifier::IDBResourceIdentifier): Deleted.
* Modules/indexeddb/shared/IDBResourceIdentifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@203481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/IDBRequest.cpp
Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.cpp
Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h

index 01325f1..cb03b1e 100644 (file)
@@ -1,5 +1,21 @@
 2016-07-20  Brady Eidson  <beidson@apple.com>
 
+        Address a small FIXME in IDB code.
+        https://bugs.webkit.org/show_bug.cgi?id=159999
+
+        Reviewed by Andy Estes.
+
+        No new tests (No behavior change).
+
+        * Modules/indexeddb/IDBRequest.cpp:
+        (WebCore::IDBRequest::IDBRequest):
+        
+        * Modules/indexeddb/shared/IDBResourceIdentifier.cpp:
+        (WebCore::IDBResourceIdentifier::IDBResourceIdentifier): Deleted.
+        * Modules/indexeddb/shared/IDBResourceIdentifier.h:
+
+2016-07-20  Brady Eidson  <beidson@apple.com>
+
         Remove some "modernFoo"s from IndexedDB code.
         https://bugs.webkit.org/show_bug.cgi?id=159985
 
index 273a674..0691b6f 100644 (file)
@@ -72,7 +72,7 @@ Ref<IDBRequest> IDBRequest::createGet(ScriptExecutionContext& context, IDBIndex&
 
 IDBRequest::IDBRequest(ScriptExecutionContext& context, IDBClient::IDBConnectionProxy& connectionProxy)
     : IDBActiveDOMObject(&context)
-    , m_resourceIdentifier(connectionProxy.serverConnectionIdentifier())
+    , m_resourceIdentifier(connectionProxy)
     , m_connectionProxy(connectionProxy)
 {
     suspendIfNeeded();
index ba5a5ce..d7e3f17 100644 (file)
@@ -52,13 +52,6 @@ IDBResourceIdentifier::IDBResourceIdentifier()
 {
 }
 
-IDBResourceIdentifier::IDBResourceIdentifier(uint64_t connectionIdentifier)
-    : m_idbConnectionIdentifier(connectionIdentifier)
-    , m_resourceNumber(nextClientResourceNumber())
-{
-}
-
-
 IDBResourceIdentifier::IDBResourceIdentifier(uint64_t connectionIdentifier, uint64_t resourceIdentifier)
     : m_idbConnectionIdentifier(connectionIdentifier)
     , m_resourceNumber(resourceIdentifier)
index fe3b013..91d7810 100644 (file)
@@ -47,10 +47,6 @@ public:
     IDBResourceIdentifier(const IDBClient::IDBConnectionProxy&, const IDBRequest&);
     explicit IDBResourceIdentifier(const IDBServer::IDBConnectionToClient&);
 
-    // FIXME: This constructor will be needed during the development of IDB-in-Workers.
-    // It should be removed when no longer necessary.
-    explicit IDBResourceIdentifier(uint64_t connectionIdentifier);
-
     static IDBResourceIdentifier deletedValue();
     WEBCORE_EXPORT bool isHashTableDeletedValue() const;