Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
authoroliver@apple.com <oliver@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Mar 2008 04:35:30 +0000 (04:35 +0000)
committeroliver@apple.com <oliver@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 Mar 2008 04:35:30 +0000 (04:35 +0000)
<http://bugs.webkit.org/show_bug.cgi?id=18030>

Reviewed by Mark Rowe

Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
<http://bugs.webkit.org/show_bug.cgi?id=18057>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/fast/events/key-events-in-frame.html-disabled [moved from LayoutTests/fast/events/key-events-in-frame.html with 100% similarity]
WebKit/mac/ChangeLog
WebKit/mac/WebView/WebHTMLView.mm

index 0b8a6a3..d6984ce 100644 (file)
@@ -1,3 +1,13 @@
+2008-03-24  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        Disable this test until we can fix 
+        Bug 18057: keyDown incorrectly propagates up the frame tree
+
+        * fast/events/key-events-in-frame.html: Removed.
+        * fast/events/key-events-in-frame.html-disabled: Added.
+
 2008-03-24  Brady Eidson  <beidson@apple.com>
 
         Made new layout test files executable, as needed for the tests to not fail!        
index d4d862d..b62895c 100644 (file)
@@ -1,3 +1,17 @@
+2008-03-24  Oliver Hunt  <oliver@apple.com>
+
+        Reviewed by Mark Rowe.
+
+        Bug 18030: REGRESSION(r31236): Space bar fails to scroll down page
+        <http://bugs.webkit.org/show_bug.cgi?id=18030>
+
+        Rollout keyDown changes from r31236 -- fix for keyDown behaviour is
+        tracked by Bug 18057: keyDown incorrectly propagates up the frame tree
+        <http://bugs.webkit.org/show_bug.cgi?id=18057>
+
+        * WebView/WebHTMLView.mm:
+        (-[WebHTMLView keyDown:]):
+
 2008-03-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
 
         Reviewed by Maciej, landed by Brady
index dd3ddb4..237e6a4 100644 (file)
@@ -3533,8 +3533,7 @@ noPromisedData:
 
     BOOL completionPopupWasOpen = _private->compController && [_private->compController popupWindowIsOpen];
     Frame* coreFrame = core([self _frame]);
-    if (!eventWasSentToWebCore && coreFrame) {
-        coreFrame->eventHandler()->keyEvent(event);
+    if (!eventWasSentToWebCore && coreFrame && coreFrame->eventHandler()->keyEvent(event)) {
         // WebCore processed a key event, bail on any preexisting complete: UI
         if (completionPopupWasOpen)
             [_private->compController endRevertingChange:YES moveLeft:NO];