[WK2] Increase the QoS of some of our WorkQueues to match the one of our processes
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jul 2015 21:15:44 +0000 (21:15 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Jul 2015 21:15:44 +0000 (21:15 +0000)
https://bugs.webkit.org/show_bug.cgi?id=146855

Reviewed by Anders Carlsson.

Increase the QoS of some of our WorkQueues to match the one of our processes. For
e.g., even though the WebContent and the Networking processes have USER_UNITIATED
QoS, the IPC between them is using a WorkQueue with DEFAULT QoS. Similarly, the
WorkQueue used for network cache reads has DEFAULT QoS.

* NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
* Platform/IPC/Connection.cpp:
(IPC::Connection::Connection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@186689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/NetworkProcess/cache/NetworkCacheStorage.cpp
Source/WebKit2/Platform/IPC/Connection.cpp

index 7700c8b..12422a9 100644 (file)
@@ -1,3 +1,20 @@
+2015-07-10  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] Increase the QoS of some of our WorkQueues to match the one of our processes
+        https://bugs.webkit.org/show_bug.cgi?id=146855
+
+        Reviewed by Anders Carlsson.
+
+        Increase the QoS of some of our WorkQueues to match the one of our processes. For
+        e.g., even though the WebContent and the Networking processes have USER_UNITIATED
+        QoS, the IPC between them is using a WorkQueue with DEFAULT QoS. Similarly, the
+        WorkQueue used for network cache reads has DEFAULT QoS.
+
+        * NetworkProcess/cache/NetworkCacheStorage.cpp:
+        (WebKit::NetworkCache::Storage::Storage):
+        * Platform/IPC/Connection.cpp:
+        (IPC::Connection::Connection):
+
 2015-07-10  Zalan Bujtas  <zalan@apple.com>
 
         Crash at WebCore::WebPage::innerFrameQuad.
index e149215..0eae027 100644 (file)
@@ -142,7 +142,7 @@ Storage::Storage(const String& baseDirectoryPath)
     : m_basePath(baseDirectoryPath)
     , m_recordsPath(makeRecordsDirectoryPath(baseDirectoryPath))
     , m_writeOperationDispatchTimer(*this, &Storage::dispatchPendingWriteOperations)
-    , m_ioQueue(WorkQueue::create("com.apple.WebKit.Cache.Storage", WorkQueue::Type::Concurrent))
+    , m_ioQueue(WorkQueue::create("com.apple.WebKit.Cache.Storage", WorkQueue::Type::Concurrent, WorkQueue::QOS::UserInitiated))
     , m_backgroundIOQueue(WorkQueue::create("com.apple.WebKit.Cache.Storage.background", WorkQueue::Type::Concurrent, WorkQueue::QOS::Background))
     , m_serialBackgroundIOQueue(WorkQueue::create("com.apple.WebKit.Cache.Storage.serialBackground", WorkQueue::Type::Serial, WorkQueue::QOS::Background))
     , m_blobStorage(makeBlobDirectoryPath(baseDirectoryPath))
index 07a93b5..3fa2008 100644 (file)
@@ -211,7 +211,7 @@ Connection::Connection(Identifier identifier, bool isServer, Client& client)
     , m_shouldExitOnSyncMessageSendFailure(false)
     , m_didCloseOnConnectionWorkQueueCallback(0)
     , m_isConnected(false)
-    , m_connectionQueue(WorkQueue::create("com.apple.IPC.ReceiveQueue"))
+    , m_connectionQueue(WorkQueue::create("com.apple.IPC.ReceiveQueue", WorkQueue::Type::Serial, WorkQueue::QOS::UserInitiated))
     , m_inSendSyncCount(0)
     , m_inDispatchMessageCount(0)
     , m_inDispatchMessageMarkedDispatchWhenWaitingForSyncReplyCount(0)