2011-04-03 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 13:53:13 +0000 (13:53 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 4 Apr 2011 13:53:13 +0000 (13:53 +0000)
        Reviewed by Ryosuke Niwa.

        Split out UnicodeBidi enum into its own header (to allow use in platform)
        https://bugs.webkit.org/show_bug.cgi?id=57722

        unicode-bidi is a CSS concept.  However the same concept is really needed throughout
        the bidi code in platform as well.  So I'm moving the enum to platform.
        The only part of the enum which doesn't make much sense to platform/ is "normal".

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSPrimitiveValueMappings.h:
        * platform/text/UnicodeBidi.h: Added.
        * rendering/style/RenderStyle.h:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Source/WebCore/WebCore.gypi
Source/WebCore/WebCore.pro
Source/WebCore/WebCore.vcproj/WebCore.vcproj
Source/WebCore/WebCore.xcodeproj/project.pbxproj
Source/WebCore/css/CSSPrimitiveValueMappings.h
Source/WebCore/platform/text/UnicodeBidi.h [new file with mode: 0644]
Source/WebCore/rendering/style/RenderStyle.h
Source/WebCore/rendering/style/RenderStyleConstants.h

index db5e0fc..4c1bca6 100644 (file)
@@ -1,3 +1,20 @@
+2011-04-03  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Ryosuke Niwa.
+
+        Split out UnicodeBidi enum into its own header (to allow use in platform)
+        https://bugs.webkit.org/show_bug.cgi?id=57722
+
+        unicode-bidi is a CSS concept.  However the same concept is really needed throughout
+        the bidi code in platform as well.  So I'm moving the enum to platform.
+        The only part of the enum which doesn't make much sense to platform/ is "normal".
+
+        * WebCore.xcodeproj/project.pbxproj:
+        * css/CSSPrimitiveValueMappings.h:
+        * platform/text/UnicodeBidi.h: Added.
+        * rendering/style/RenderStyle.h:
+        * rendering/style/RenderStyleConstants.h:
+
 2011-04-04  Andrey Adaikin  <aandrey@google.com>
 
         Reviewed by Yury Semikhatsky.
index 0492d5a..960be9e 100644 (file)
@@ -2719,6 +2719,7 @@ webcore_sources += \
        Source/WebCore/platform/text/TextStream.h \
        Source/WebCore/platform/text/transcoder/FontTranscoder.cpp \
        Source/WebCore/platform/text/transcoder/FontTranscoder.h \
+       Source/WebCore/platform/text/UnicodeBidi.h \
        Source/WebCore/platform/text/UnicodeRange.cpp \
        Source/WebCore/platform/text/UnicodeRange.h \
        Source/WebCore/platform/ThemeTypes.h \
index 2d55e1a..fd43e79 100644 (file)
             'platform/text/TextEncodingRegistry.h',
             'platform/text/TextOrientation.h',
             'platform/text/TextStream.h',
+            'platform/text/UnicodeBidi.h',
             'platform/text/UnicodeRange.h',
             'platform/text/mac/CharsetData.h',
             'plugins/PluginData.h',
index 2ac917a..4c2e19f 100644 (file)
@@ -1964,6 +1964,7 @@ HEADERS += \
     platform/text/LineEnding.h \
     platform/text/TextCheckerClient.h \
     platform/text/TextChecking.h \
+    platform/text/UnicodeBidi.h \
     platform/LinkHash.h \
     platform/Logging.h \
     platform/Language.h \
index 570d1fa..37a52e3 100755 (executable)
                                        >
                                </File>
                                <File
+                                       RelativePath="..\platform\text\UnicodeBidi.h"
+                                       >
+                               </File>
+                               <File
                                        RelativePath="..\platform\text\UnicodeRange.cpp"
                                        >
                                </File>
index ce2ba26..3797c31 100644 (file)
                A84EBD830CB8C97700079609 /* JSStyleSheetList.h in Headers */ = {isa = PBXBuildFile; fileRef = A84EBD810CB8C97700079609 /* JSStyleSheetList.h */; };
                A84EBD840CB8C97700079609 /* JSStyleSheetList.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A84EBD820CB8C97700079609 /* JSStyleSheetList.cpp */; };
                A853123D11D0471B00D4D077 /* FragmentScriptingPermission.h in Headers */ = {isa = PBXBuildFile; fileRef = A853123C11D0471B00D4D077 /* FragmentScriptingPermission.h */; settings = {ATTRIBUTES = (Private, ); }; };
+               A863E2011343412000274926 /* UnicodeBidi.h in Headers */ = {isa = PBXBuildFile; fileRef = A863E2001343412000274926 /* UnicodeBidi.h */; settings = {ATTRIBUTES = (Private, ); }; };
                A86629CF09DA2B47009633A5 /* JSUIEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = A86629C909DA2B47009633A5 /* JSUIEvent.h */; };
                A86629D009DA2B48009633A5 /* JSUIEvent.cpp in Sources */ = {isa = PBXBuildFile; fileRef = A86629CA09DA2B47009633A5 /* JSUIEvent.cpp */; };
                A86629D109DA2B48009633A5 /* JSMouseEvent.h in Headers */ = {isa = PBXBuildFile; fileRef = A86629CB09DA2B47009633A5 /* JSMouseEvent.h */; };
                A84EBD820CB8C97700079609 /* JSStyleSheetList.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSStyleSheetList.cpp; sourceTree = "<group>"; };
                A853123C11D0471B00D4D077 /* FragmentScriptingPermission.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = FragmentScriptingPermission.h; sourceTree = "<group>"; };
                A85D7A2F0879EBA9006A9172 /* QuartzCore.framework */ = {isa = PBXFileReference; lastKnownFileType = wrapper.framework; name = QuartzCore.framework; path = /System/Library/Frameworks/QuartzCore.framework; sourceTree = "<absolute>"; };
+               A863E2001343412000274926 /* UnicodeBidi.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = UnicodeBidi.h; sourceTree = "<group>"; };
                A86629C909DA2B47009633A5 /* JSUIEvent.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSUIEvent.h; sourceTree = "<group>"; };
                A86629CA09DA2B47009633A5 /* JSUIEvent.cpp */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.cpp.cpp; path = JSUIEvent.cpp; sourceTree = "<group>"; };
                A86629CB09DA2B47009633A5 /* JSMouseEvent.h */ = {isa = PBXFileReference; fileEncoding = 30; lastKnownFileType = sourcecode.c.h; path = JSMouseEvent.h; sourceTree = "<group>"; };
                                BCD3F9821326C93700098A60 /* TextOrientation.h */,
                                B2C3DA1A0D006C1D00EF6F26 /* TextStream.cpp */,
                                B2C3DA1B0D006C1D00EF6F26 /* TextStream.h */,
+                               A863E2001343412000274926 /* UnicodeBidi.h */,
                                B2C3DA1C0D006C1D00EF6F26 /* UnicodeRange.cpp */,
                                B2C3DA1D0D006C1D00EF6F26 /* UnicodeRange.h */,
                        );
                                49EECDF510503C2400099FAB /* Uint16Array.h in Headers */,
                                49EECDF210503C2400099FAB /* Uint32Array.h in Headers */,
                                49EECDEF10503C2400099FAB /* Uint8Array.h in Headers */,
+                               A863E2011343412000274926 /* UnicodeBidi.h in Headers */,
                                B2C3DA4D0D006C1D00EF6F26 /* UnicodeRange.h in Headers */,
                                E4AFCFA50DAF29A300F5F55C /* UnitBezier.h in Headers */,
                                D086FE9809D53AAB005BC74D /* UnlinkCommand.h in Headers */,
index 16412ad..b1f9aec 100644 (file)
@@ -42,6 +42,7 @@
 #include "TextOrientation.h"
 #include "TextRenderingMode.h"
 #include "ThemeTypes.h"
+#include "UnicodeBidi.h"
 
 namespace WebCore {
 
diff --git a/Source/WebCore/platform/text/UnicodeBidi.h b/Source/WebCore/platform/text/UnicodeBidi.h
new file mode 100644 (file)
index 0000000..8e0d86e
--- /dev/null
@@ -0,0 +1,40 @@
+/*
+ * Copyright (C) 2011 Google, Inc.  All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions
+ * are met:
+ * 1. Redistributions of source code must retain the above copyright
+ *    notice, this list of conditions and the following disclaimer.
+ * 2. Redistributions in binary form must reproduce the above copyright
+ *    notice, this list of conditions and the following disclaimer in the
+ *    documentation and/or other materials provided with the distribution.
+ *
+ * THIS SOFTWARE IS PROVIDED BY APPLE COMPUTER, INC. ``AS IS'' AND ANY
+ * EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
+ * PURPOSE ARE DISCLAIMED.  IN NO EVENT SHALL APPLE COMPUTER, INC. OR
+ * CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL,
+ * EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
+ * PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
+ * PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY
+ * OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef UnicodeBidi_h
+#define UnicodeBidi_h
+
+namespace WebCore {
+
+enum EUnicodeBidi {
+    UBNormal,
+    Embed,
+    Override,
+    Isolate
+};
+
+}
+
+#endif
index 8d2aa6a..7591ad5 100644 (file)
@@ -62,6 +62,7 @@
 #include "TextOrientation.h"
 #include "ThemeTypes.h"
 #include "TransformOperations.h"
+#include "UnicodeBidi.h"
 #include <wtf/Forward.h>
 #include <wtf/OwnPtr.h>
 #include <wtf/RefCounted.h>
index 67de4ba..5ad42ce 100644 (file)
@@ -119,10 +119,6 @@ enum ETableLayout {
     TAUTO, TFIXED
 };
 
-enum EUnicodeBidi {
-    UBNormal, Embed, Override, Isolate
-};
-
 // CSS Text Layout Module Level 3: Vertical writing support
 enum WritingMode {
     TopToBottomWritingMode, RightToLeftWritingMode, LeftToRightWritingMode, BottomToTopWritingMode