A few bits of minor code clean up.
authormark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Nov 2016 21:42:33 +0000 (21:42 +0000)
committermark.lam@apple.com <mark.lam@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 10 Nov 2016 21:42:33 +0000 (21:42 +0000)
https://bugs.webkit.org/show_bug.cgi?id=164523

Reviewed by Yusuke Suzuki.

* interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::dump):
- Insert a space to make the dump more legible.

* runtime/Options.h:
- Fixed some typos.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplaceUsingRegExp):
(JSC::stringProtoFuncReplaceUsingStringSearch):
- Use the VM& that is already available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@208563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/interpreter/StackVisitor.cpp
Source/JavaScriptCore/runtime/Options.h
Source/JavaScriptCore/runtime/StringPrototype.cpp

index 85abc67..cb7e1ba 100644 (file)
@@ -1,5 +1,24 @@
 2016-11-10  Mark Lam  <mark.lam@apple.com>
 
+        A few bits of minor code clean up.
+        https://bugs.webkit.org/show_bug.cgi?id=164523
+
+        Reviewed by Yusuke Suzuki.
+
+        * interpreter/StackVisitor.cpp:
+        (JSC::StackVisitor::Frame::dump):
+        - Insert a space to make the dump more legible.
+
+        * runtime/Options.h:
+        - Fixed some typos.
+
+        * runtime/StringPrototype.cpp:
+        (JSC::stringProtoFuncReplaceUsingRegExp):
+        (JSC::stringProtoFuncReplaceUsingStringSearch):
+        - Use the VM& that is already available.
+
+2016-11-10  Mark Lam  <mark.lam@apple.com>
+
         Graph::methodOfGettingAValueProfileFor() should be returning the profile for the operand node.
         https://bugs.webkit.org/show_bug.cgi?id=164600
         <rdar://problem/28828676>
index a97e215..fe9be72 100644 (file)
@@ -395,7 +395,7 @@ void StackVisitor::Frame::dump(PrintStream& out, Indenter indent, std::function<
             " ", RawPointer(reinterpret_cast<void*>(locationRawBits)), "\n");
         out.print(indent, "codeBlock: ", RawPointer(codeBlock));
         if (codeBlock)
-            out.print(*codeBlock);
+            out.print(" ", *codeBlock);
         out.print("\n");
         if (codeBlock && !isInlined) {
             indent++;
index cbb8a4b..6e14f5f 100644 (file)
@@ -153,8 +153,8 @@ typedef const char* optionString;
     v(bool, dumpBytecodeAtDFGTime, false, Normal, "dumps bytecode of JS function being DFG compiled") \
     v(bool, dumpGraphAfterParsing, false, Normal, nullptr) \
     v(bool, dumpGraphAtEachPhase, false, Normal, nullptr) \
-    v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion (note this excludes DFG graphs during FTL compilation)") \
-    v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase DFG of complitaion when compiling FTL code") \
+    v(bool, dumpDFGGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation (note this excludes DFG graphs during FTL compilation)") \
+    v(bool, dumpDFGFTLGraphAtEachPhase, false, Normal, "dumps the DFG graph at each phase of DFG compilation when compiling FTL code") \
     v(bool, dumpB3GraphAtEachPhase, false, Normal, "dumps the B3 graph at each phase of compilation") \
     v(bool, dumpAirGraphAtEachPhase, false, Normal, "dumps the Air graph at each phase of compilation") \
     v(bool, verboseDFGByteCodeParsing, false, Normal, nullptr) \
index 09a21a5..a1645bc 100644 (file)
@@ -852,7 +852,7 @@ EncodedJSValue JSC_HOST_CALL stringProtoFuncReplaceUsingRegExp(ExecState* exec)
         return JSValue::encode(jsUndefined());
 
     scope.release();
-    return replaceUsingRegExpSearch(exec->vm(), exec, string, searchValue, exec->argument(1));
+    return replaceUsingRegExpSearch(vm, exec, string, searchValue, exec->argument(1));
 }
 
 EncodedJSValue JSC_HOST_CALL stringProtoFuncReplaceUsingStringSearch(ExecState* exec)
@@ -863,7 +863,7 @@ EncodedJSValue JSC_HOST_CALL stringProtoFuncReplaceUsingStringSearch(ExecState*
     JSString* string = exec->thisValue().toString(exec);
     RETURN_IF_EXCEPTION(scope, encodedJSValue());
 
-    return replaceUsingStringSearch(exec->vm(), exec, string, exec->argument(0), exec->argument(1));
+    return replaceUsingStringSearch(vm, exec, string, exec->argument(0), exec->argument(1));
 }
 
 EncodedJSValue JIT_OPERATION operationStringProtoFuncReplaceGeneric(