Web Inspector: Do not disable network tracking while profiling cpu.
authorvsevik@chromium.org <vsevik@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Aug 2012 13:52:42 +0000 (13:52 +0000)
committervsevik@chromium.org <vsevik@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 7 Aug 2012 13:52:42 +0000 (13:52 +0000)
https://bugs.webkit.org/show_bug.cgi?id=93359

Reviewed by Yury Semikhatsky.

Removed network tracking enabling/disabling machinery.

* inspector/front-end/CPUProfileView.js:
(WebInspector.CPUProfileType.prototype.buttonClicked):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager.get this):
(WebInspector.NetworkManager.get NetworkAgent):
(WebInspector.NetworkManager):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/CPUProfileView.js
Source/WebCore/inspector/front-end/NetworkManager.js
Source/WebCore/inspector/front-end/ResourceTreeModel.js

index 51c2e57..d8cf3e1 100644 (file)
@@ -1,3 +1,21 @@
+2012-08-07  Vsevolod Vlasov  <vsevik@chromium.org>
+
+        Web Inspector: Do not disable network tracking while profiling cpu.
+        https://bugs.webkit.org/show_bug.cgi?id=93359
+
+        Reviewed by Yury Semikhatsky.
+
+        Removed network tracking enabling/disabling machinery.
+
+        * inspector/front-end/CPUProfileView.js:
+        (WebInspector.CPUProfileType.prototype.buttonClicked):
+        * inspector/front-end/NetworkManager.js:
+        (WebInspector.NetworkManager.get this):
+        (WebInspector.NetworkManager.get NetworkAgent):
+        (WebInspector.NetworkManager):
+        * inspector/front-end/ResourceTreeModel.js:
+        (WebInspector.ResourceTreeModel):
+
 2012-08-07  Alexei Filippov  <alexeif@chromium.org>
 
         Web Inspector: make the MemoryClassInfo class a not-template
index eb71ff8..3015328 100644 (file)
@@ -560,10 +560,8 @@ WebInspector.CPUProfileType.prototype = {
     {
         if (this._recording) {
             this.stopRecordingProfile();
-            WebInspector.networkManager.enableResourceTracking();
             return false;
         } else {
-            WebInspector.networkManager.disableResourceTracking();
             this.startRecordingProfile();
             return true;
         }
index fd6f61c..ecf6a59 100644 (file)
@@ -49,8 +49,6 @@ WebInspector.NetworkManager = function()
 }
 
 WebInspector.NetworkManager.EventTypes = {
-    ResourceTrackingEnabled: "ResourceTrackingEnabled",
-    ResourceTrackingDisabled: "ResourceTrackingDisabled",
     RequestStarted: "RequestStarted",
     RequestUpdated: "RequestUpdated",
     RequestFinished: "RequestFinished",
@@ -94,24 +92,6 @@ WebInspector.NetworkManager._MIMETypes = {
 }
 
 WebInspector.NetworkManager.prototype = {
-    enableResourceTracking: function()
-    {
-        function callback(error)
-        {
-            this.dispatchEventToListeners(WebInspector.NetworkManager.EventTypes.ResourceTrackingEnabled);
-        }
-        NetworkAgent.enable(callback.bind(this));
-    },
-
-    disableResourceTracking: function()
-    {
-        function callback(error)
-        {
-            this.dispatchEventToListeners(WebInspector.NetworkManager.EventTypes.ResourceTrackingDisabled);
-        }
-        NetworkAgent.disable(callback.bind(this));
-    },
-
     /**
      * @param {string} url
      * @return {WebInspector.NetworkRequest}
index e0dfbab..3616571 100644 (file)
@@ -35,7 +35,6 @@
  */
 WebInspector.ResourceTreeModel = function(networkManager)
 {
-    networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.ResourceTrackingEnabled, this._onResourceTrackingEnabled, this);
     networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdated, this._onRequestUpdated, this);
     networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestFinished, this._onRequestUpdated, this);
     networkManager.addEventListener(WebInspector.NetworkManager.EventTypes.RequestUpdateDropped, this._onRequestUpdateDropped, this);
@@ -68,11 +67,6 @@ WebInspector.ResourceTreeModel.EventTypes = {
 }
 
 WebInspector.ResourceTreeModel.prototype = {
-    _onResourceTrackingEnabled: function()
-    {
-        this._fetchResourceTree();
-    },
-
     _fetchResourceTree: function()
     {
         this._frames = {};