API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
authorbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jul 2016 05:12:14 +0000 (05:12 +0000)
committerbdakin@apple.com <bdakin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 8 Jul 2016 05:12:14 +0000 (05:12 +0000)
https://bugs.webkit.org/show_bug.cgi?id=159532
-and corresponding-
rdar://problem/27177179

Reviewed by Tim Horton.

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
(-[WebView forceRequestCandidatesForTesting]):
(-[WebView shouldRequestCandidates]):
* WebView/WebViewPrivate.h:

Tools:

* TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
(-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@202957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebView.mm
Source/WebKit/mac/WebView/WebViewPrivate.h
Tools/ChangeLog
Tools/TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm

index bd1db75..25b8d76 100644 (file)
@@ -1,3 +1,18 @@
+2016-07-07  Beth Dakin  <bdakin@apple.com>
+
+        API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=159532
+        -and corresponding-
+        rdar://problem/27177179
+
+        Reviewed by Tim Horton.
+
+        * WebView/WebView.mm:
+        (-[WebView showCandidates:forString:inRect:forSelectedRange:view:completionHandler:]):
+        (-[WebView forceRequestCandidatesForTesting]):
+        (-[WebView shouldRequestCandidates]):
+        * WebView/WebViewPrivate.h:
+
 2016-07-07  Andy Estes  <aestes@apple.com>
 
         [Content Filtering] Load blocked pages more like other error pages are loaded
index 8add540..9c9dc9c 100644 (file)
@@ -6723,6 +6723,10 @@ static WebFrame *incrementFrame(WebFrame *frame, WebFindOptions options = 0)
 {
 }
 
+- (void)forceRequestCandidatesForTesting
+{
+}
+
 - (BOOL)shouldRequestCandidates
 {
     return NO;
index 9d359c5..4041b23 100644 (file)
@@ -1069,6 +1069,7 @@ Could be worth adding to the API.
 
 @interface WebView (WebShowCandidates)
 - (void)showCandidates:(NSArray *)candidates forString:(NSString *)string inRect:(NSRect)rectOfTypedString forSelectedRange:(NSRange)range view:(NSView *)view completionHandler:(void (^)(NSTextCheckingResult *acceptedCandidate))completionBlock;
+- (void)forceRequestCandidatesForTesting;
 @end
 
 #ifdef __cplusplus
index 0b180f3..200a8b5 100644 (file)
@@ -1,3 +1,15 @@
+2016-07-07  Beth Dakin  <bdakin@apple.com>
+
+        API Test DoNotLeakWebView.ViewThatLoadsEditableArea times out on macOS Sierra
+        https://bugs.webkit.org/show_bug.cgi?id=159532
+        -and corresponding-
+        rdar://problem/27177179
+
+        Reviewed by Tim Horton.
+
+        * TestWebKitAPI/Tests/mac/ViewWithEditableAreaLeak.mm:
+        (-[DoNotLeakFrameLoadDelegate webView:didFinishLoadForFrame:]):
+
 2016-07-07  Andy Estes  <aestes@apple.com>
 
         [Content Filtering] Load blocked pages more like other error pages are loaded
index 25bce4b..4b0abf1 100644 (file)
@@ -62,6 +62,7 @@ static bool didCallShowCandidates = false;
 
 - (void)webView:(WebView *)sender didFinishLoadForFrame:(WebFrame *)frame
 {
+    [sender forceRequestCandidatesForTesting];
     didFinishLoad = true;
 }