Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Jun 2012 09:25:52 +0000 (09:25 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 14 Jun 2012 09:25:52 +0000 (09:25 +0000)
https://bugs.webkit.org/show_bug.cgi?id=89044

Patch by Min Qin <qinmin@google.com> on 2012-06-14
Reviewed by Adam Barth.

Source/WebCore:

enterFullscreen() and exitFullscreen() could both modify the player state.
This change reverts the change we made in r120213.

Just function declaration change, no test needed.

* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::enterFullscreen):

Source/WebKit/chromium:

enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state.
This reverts the change from r120213.

* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::enterFullscreen):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/MediaPlayerPrivate.h
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/WebMediaPlayerClientImpl.cpp
Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h

index 2e27585..8bb206b 100644 (file)
@@ -1,3 +1,18 @@
+2012-06-14  Min Qin  <qinmin@google.com>
+
+        Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=89044
+
+        Reviewed by Adam Barth.
+
+        enterFullscreen() and exitFullscreen() could both modify the player state.
+        This change reverts the change we made in r120213.
+
+        Just function declaration change, no test needed.
+
+        * platform/graphics/MediaPlayerPrivate.h:
+        (WebCore::MediaPlayerPrivateInterface::enterFullscreen):
+
 2012-06-14  Edaena Salinas Jasso  <edaena@apple.com>
 
         el.getAttribute('type') returns 'null' when setting el.type to null
index 58b227a..f8d40be 100644 (file)
@@ -118,7 +118,7 @@ public:
 #endif
 
 #if ENABLE(PLUGIN_PROXY_FOR_VIDEO) || USE(NATIVE_FULLSCREEN_VIDEO)
-    virtual void enterFullscreen() const { }
+    virtual void enterFullscreen() { }
     virtual void exitFullscreen() { }
 #endif
 
index 55cfc77..5bc854b 100644 (file)
@@ -1,3 +1,18 @@
+2012-06-14  Min Qin  <qinmin@google.com>
+
+        Remove the const keyword from MediaPlayerPrivate::enterFullscreen()
+        https://bugs.webkit.org/show_bug.cgi?id=89044
+
+        Reviewed by Adam Barth.
+
+        enterFullscreen() should be treated similarly as exitFullscreen() as it could alter the player state.
+        This reverts the change from r120213.
+
+        * src/WebMediaPlayerClientImpl.cpp:
+        (WebKit::WebMediaPlayerClientImpl::enterFullscreen):
+        * src/WebMediaPlayerClientImpl.h:
+        (WebMediaPlayerClientImpl):
+
 2012-06-14  Dan Alcantara  <dfalcantara@chromium.org>
 
         [chromium] Rename WebFrameClient::userAgent() to better reflect what it does
index 916efb5..95186dd 100644 (file)
@@ -370,7 +370,7 @@ void WebMediaPlayerClientImpl::pause()
 }
 
 #if USE(NATIVE_FULLSCREEN_VIDEO)
-void WebMediaPlayerClientImpl::enterFullscreen() const
+void WebMediaPlayerClientImpl::enterFullscreen()
 {
     if (m_webMediaPlayer)
         m_webMediaPlayer->enterFullscreen();
index deacfac..53a24d6 100644 (file)
@@ -139,7 +139,7 @@ public:
     virtual unsigned audioDecodedByteCount() const;
     virtual unsigned videoDecodedByteCount() const;
 #if USE(NATIVE_FULLSCREEN_VIDEO)
-    virtual void enterFullscreen() const;
+    virtual void enterFullscreen();
     virtual void exitFullscreen();
     virtual bool canEnterFullscreen() const;
 #endif