[EFL] Enable CSS_IMAGE_SET flag
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 May 2012 14:47:30 +0000 (14:47 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 31 May 2012 14:47:30 +0000 (14:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=87727

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31
Reviewed by Adam Roben.

.:

Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.

* CMakeLists.txt:

LayoutTests:

Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/efl/test_expectations.txt
Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog
Source/cmake/OptionsEfl.cmake
Source/cmake/WebKitFeatures.cmake
Source/cmakeconfig.h.cmake

index 1acaaa1..28ba5b0 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,16 @@
+2012-05-31  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] Enable CSS_IMAGE_SET flag
+        https://bugs.webkit.org/show_bug.cgi?id=87727
+
+        Reviewed by Adam Roben.
+
+        Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.
+
+        * Source/cmake/OptionsEfl.cmake:
+        * Source/cmake/WebKitFeatures.cmake:
+        * Source/cmakeconfig.h.cmake:
+
 2012-05-30  Kevin Ollivier  <kevino@theolliviers.com>
 
         [wx] Unreviewed build fix. Add needed file back to the wx build.
index cd8f479..d12d0cb 100644 (file)
@@ -1,3 +1,15 @@
+2012-05-31  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] Enable CSS_IMAGE_SET flag
+        https://bugs.webkit.org/show_bug.cgi?id=87727
+
+        Reviewed by Adam Roben.
+
+        Unskip test case associated to CSS image-set functionality now that it
+        is enabled by default on EFL port.
+
+        * platform/efl/test_expectations.txt:
+
 2012-05-31  Mario Sanchez Prada  <msanchez@igalia.com>
 
         Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.
index 4d23463..8aa2ade 100644 (file)
@@ -489,9 +489,6 @@ BUGWKEFL SKIP : fast/images/webp-image-decoding.html = FAIL
 // This tests fails by one on 32 bits machines due to rounding issues.
 BUGWKEFL : fast/css/percentage-non-integer.html = TEXT PASS
 
-// CSS image-set support not yet enabled (needs ENABLE_CSS_IMAGE_SET).
-BUGWKEFL : fast/css/image-set-parsing.html = TEXT
-
 // Test is timeouting, passes in all other platforms.
 BUGWKEFL SKIP : fast/css/device-aspect-ratio.html = FAIL
 
index 4d724aa..7d6ea1c 100644 (file)
@@ -477,6 +477,7 @@ SET(WebCore_SOURCES
     css/CSSFunctionValue.cpp
     css/CSSGradientValue.cpp
     css/CSSImageGeneratorValue.cpp
+    css/CSSImageSetValue.cpp
     css/CSSImageValue.cpp
     css/CSSImportRule.cpp
     css/CSSInheritedValue.cpp
@@ -1413,6 +1414,7 @@ SET(WebCore_SOURCES
     rendering/style/StyleBackgroundData.cpp
     rendering/style/StyleBoxData.cpp
     rendering/style/StyleCachedImage.cpp
+    rendering/style/StyleCachedImageSet.cpp
     rendering/style/StyleDeprecatedFlexibleBoxData.cpp
     rendering/style/StyleFilterData.cpp
     rendering/style/StyleFlexibleBoxData.cpp
index 0e244ac..b53c709 100644 (file)
@@ -1,3 +1,15 @@
+2012-05-31  Christophe Dumez  <christophe.dumez@intel.com>
+
+        [EFL] Enable CSS_IMAGE_SET flag
+        https://bugs.webkit.org/show_bug.cgi?id=87727
+
+        Reviewed by Adam Roben.
+
+        Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
+        CSS_IMAGE_SET flag is enabled.
+
+        * CMakeLists.txt:
+
 2012-05-31  Keyar Hood  <keyar@chromium.org>
 
         the imageSmoothingEnabled flag needs to be in the state object
index fac7677..1a75144 100644 (file)
@@ -68,6 +68,7 @@ SET(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_MODULE_PATH}/eflsymbols.filter"
 WEBKIT_OPTION_BEGIN()
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BATTERY_STATUS ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_BLOB ON)
+WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_IMAGE_SET ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DRAG_SUPPORT ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FAST_MOBILE_SCROLLING ON)
 WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS ON)
index 3913fab..2b9a778 100644 (file)
@@ -21,6 +21,7 @@ MACRO (WEBKIT_OPTION_BEGIN)
     WEBKIT_OPTION_DEFINE(ENABLE_CSS3_FLEXBOX "Toggle CSS3 Flexbox support" ON)
     WEBKIT_OPTION_DEFINE(ENABLE_CSS_FILTERS "Toggle CSS Filters support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_CSS_IMAGE_RESOLUTION "Toggle CSS image-resolution support" OFF)
+    WEBKIT_OPTION_DEFINE(ENABLE_CSS_IMAGE_SET "Toggle CSS image-set support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_CSS_SHADERS "Toggle CSS Shaders (within CSS Filters) support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_CSS_VARIABLES "Toggle CSS Variables support" OFF)
     WEBKIT_OPTION_DEFINE(ENABLE_DATALIST "Toggle HTML5 datalist support" OFF)
index 7dd8687..59b682d 100644 (file)
@@ -15,6 +15,7 @@
 #cmakedefine01 ENABLE_CLIENT_BASED_GEOLOCATION
 #cmakedefine01 ENABLE_CSS3_FLEXBOX
 #cmakedefine01 ENABLE_CSS_IMAGE_RESOLUTION
+#cmakedefine01 ENABLE_CSS_IMAGE_SET
 #cmakedefine01 ENABLE_DATALIST
 #cmakedefine01 ENABLE_DATA_TRANSFER_ITEMS
 #cmakedefine01 ENABLE_DETAILS