[Qt]ietestcenter/css3/flexbox tests fail on 32 bit
authortomz@codeaurora.org <tomz@codeaurora.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 May 2012 17:28:21 +0000 (17:28 +0000)
committertomz@codeaurora.org <tomz@codeaurora.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 11 May 2012 17:28:21 +0000 (17:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=85596

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-05-11
Reviewed by Csaba Osztrogon√°c.

Reference tests originally assumed "background: green" was identical
to the green used in the pngs used by the feature tests. On local builds
of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac
and QT bots however, it became clear this was an invalid assumption. I've
re-written the reference tests to use the original pngs as appropriate.
I have reproduced the failures on a Mac & Qt32 and verified that the newly
re-written reference tests behave properly now.

* ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
* ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/mac/test_expectations.txt:
* platform/qt/Skipped:
* platform/qt/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

23 files changed:
LayoutTests/ChangeLog
LayoutTests/ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm
LayoutTests/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm
LayoutTests/platform/chromium/test_expectations.txt
LayoutTests/platform/efl/test_expectations.txt
LayoutTests/platform/gtk/test_expectations.txt
LayoutTests/platform/mac/Skipped
LayoutTests/platform/mac/test_expectations.txt
LayoutTests/platform/qt/Skipped
LayoutTests/platform/qt/test_expectations.txt

index fe6cf6a..474d761 100644 (file)
@@ -1,3 +1,41 @@
+2012-05-11  Dave Tharp  <dtharp@codeaurora.org>
+
+        [Qt]ietestcenter/css3/flexbox tests fail on 32 bit
+        https://bugs.webkit.org/show_bug.cgi?id=85596
+
+        Reviewed by Csaba Osztrogon√°c.
+
+        Reference tests originally assumed "background: green" was identical 
+        to the green used in the pngs used by the feature tests. On local builds 
+        of QT, GTK, and chromium, this assumption seemed to hold up. On the Mac 
+        and QT bots however, it became clear this was an invalid assumption. I've 
+        re-written the reference tests to use the original pngs as appropriate.  
+        I have reproduced the failures on a Mac & Qt32 and verified that the newly 
+        re-written reference tests behave properly now.
+
+        * ietestcenter/css3/flexbox/flexbox-align-end-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-align-start-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-flex-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-flex-002-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-flex-003-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-flex-004-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-groups-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-groups-002-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-groups-003-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-groups-004-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-layout-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-layout-003-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.htm:
+        * ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.htm:
+        * platform/chromium/test_expectations.txt:
+        * platform/efl/test_expectations.txt:
+        * platform/gtk/test_expectations.txt:
+        * platform/mac/Skipped:
+        * platform/mac/test_expectations.txt:
+        * platform/qt/Skipped:
+        * platform/qt/test_expectations.txt:
+
 2012-05-11  Krzysztof Czech  <k.czech@samsung.com>
 
         [EFL] Gardening failure test cases.
index 726c875..2c7a045 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             .box
             {
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') top left repeat-x red;
                 width: 300px;
                 height: 200px;
                 z-index: -1;
index b72efe8..6eb88f4 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             .box
             {
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') bottom left repeat-x red;
                 width: 300px;
                 height: 200px;
                 position: relative;
index 5ea6398..cda1bdd 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             div
             {
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
                 width: 300px;
                 height: 100px;
             }
index c2a1856..88397ee 100644 (file)
@@ -5,7 +5,13 @@
         <link rel="author" title="Codeaurora" href="http://www.codeaurora.org/" />
         <link rel="help" href="http://www.w3.org/TR/2009/WD-css3-flexbox-20090723/"/>
         <style type="text/css">
-            div
+            .box
+            {
+                background: red;
+                width: 300px;
+                height: 100px;
+            }
+            .child
             {
                 background: green;
                 width: 300px;
@@ -15,7 +21,8 @@
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
-        <div>
+        <div class="box">
+            <div class="child"></div>
         </div>
     </body>
 </html>
index f2f986c..112d2d1 100644 (file)
                 background: green;
                 width: 300px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
+            }
+            .three
+            {
+                left: 200px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
+            <div class="child three"></div>
         </div>
     </body>
 </html>
index 880cc7e..f777083 100644 (file)
                 background: green;
                 width: 400px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
+            }
+            .three
+            {
+                left: 200px;
+            }
+            .four
+            {
+                left: 300px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
+            <div class="child three"></div>
+            <div class="child four"></div>
         </div>
     </body>
 </html>
index 510c4f1..5cbc227 100644 (file)
                 background: green;
                 width: 300px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
+            }
+            .three
+            {
+                left: 200px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
+            <div class="child three"></div>
         </div>
     </body>
 </html>
index c1b30ca..eda4644 100644 (file)
                 background: green;
                 width: 300px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
+            }
+            .three
+            {
+                left: 200px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
+            <div class="child three"></div>
         </div>
     </body>
 </html>
index 8c1d4e9..50f1949 100644 (file)
                 background: green;
                 width: 200px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
         </div>
     </body>
 </html>
index 6df94a6..3486ff7 100644 (file)
                 background: green;
                 width: 300px;
                 height: 100px;
+                position: relative;
+            }
+            .child
+            {
+                width: 100px;
+                height: 100px;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
+                position: absolute;
+            }
+            .two
+            {
+                left: 100px;
+            }
+            .three
+            {
+                left: 200px;
             }
         </style>
     </head>
     <body>
         <p>This test passes if there is no red showing.</p>
         <div>
+            <div class="child"></div>
+            <div class="child two"></div>
+            <div class="child three"></div>
         </div>
     </body>
 </html>
index 1cea257..18f1096 100644 (file)
@@ -10,7 +10,7 @@
                 border: 0px;
                 border-collapse:collapse;
                 border-spacing:0px 0px;
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') top left no-repeat green;
             }
             td
             {
index 88c8fb2..8a94513 100644 (file)
@@ -7,24 +7,26 @@
         <style type="text/css">
             .parent
             {
-                background: green;
+                background: url('../support/flexbox_300x200_red.png') no-repeat green;
                 width:500px;
                 height:500px;
                 position: relative;
             }
-            .childa
+            .box
             {
-                width:100px;
-                height:100px;
-                background: green;
-                position: absolute;
+                width:300px;
+                height:200px;
+                background: url('../support/flexbox_200x100_red.png') no-repeat green;
             }
-            .childb
+            .child
             {
                 width:100px;
                 height:100px;
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') no-repeat green;
                 position: absolute;
+            }
+            .two
+            {
                 left: 100px;
             }
         </style>
     <body>
         <p>Test passes if there is no red visible on the page.</p>
         <div class="parent">
-            <div class="childa">parent is 300x200px</div>
-            <div class="childb">two children are 100x100px</div>
+            <div class="box">
+                <div class="child">parent is 300x200px</div>
+                <div class="child two">two children are 100x100px</div>
+            </div>
         </div>
     </body>
 </html>
index 801a369..fc5b62a 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             .box
             {
-                background: green;
+                background: url('../support/flexbox_100x100g_red.png') top left no-repeat red;
                 width: 400px;
                 height: 100px;
                 position: relative;
index eb43f53..fe474d5 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             .box
             {
-                background: green;
+                background: url('../support/flexbox_100r_50g_100r_50g_100g.png') top left no-repeat green;
                 width: 400px;
                 height: 100px;
                 position: relative;
                 background: green;
                 position: absolute;
             }
-            .c1
-            {
-                left: 0px;
-            }
             .c2
             {
                 left: 150px;
@@ -36,7 +32,7 @@
     <body>
         <p>This test passes if there is no red showing.</p>
         <div class="box">
-            <div class="child c1">Box1</div>
+            <div class="child">Box1</div>
             <div class="child c2">Box2</div>
             <div class="child c3">Box3</div>
         </div>
index 3755a5a..e13d370 100644 (file)
@@ -7,7 +7,7 @@
         <style type="text/css">
             .box
             {
-                background: green;
+                background: url('../support/flexbox_100x100_green.png') top right no-repeat red;
                 width: 400px;
                 height: 100px;
                 position: relative;
                 background: green;
                 position: absolute;
             }
-            .c1
-            {
-                left: 0px;
-            }
             .c2
             {
                 left: 100px;
@@ -37,7 +33,7 @@
     <body>
         <p>This test passes if there is no red showing.</p>
         <div class="box">
-            <div class="child c1">Box1</div>
+            <div class="child">Box1</div>
             <div class="child c2">Box2</div>
             <div class="child c3">Box3</div>
         </div>
index 0f1a01d..75cf56a 100644 (file)
@@ -3982,7 +3982,7 @@ BUGWK68744 : fast/block/float/float-not-removed-from-next-sibling4.html = IMAGE
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE
 BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE
-BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
+BUGWK85213 BUGWK85832 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
 
 BUGWK85553 DEBUG : http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html = TIMEOUT
 
index 19ee8e9..bab1ffb 100644 (file)
@@ -266,7 +266,7 @@ BUGWK66873:  http/tests/loading/redirect-methods.html = TEXT
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE
 BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE
-BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
+BUGWK85213 BUGWK85832 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
 
 // Requires rebaseline after bug 85031
 BUGWK85565 : fast/block/float/016.html = IMAGE
index 6ec0a9a..858e37b 100644 (file)
@@ -294,7 +294,7 @@ BUGWK78801 : touchadjustment = FAIL
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE
 BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE
-BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
+BUGWK85213 BUGWK85832 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
 
 // These tests require subpixel layout to be enabled
 BUGWK60318 : fast/sub-pixel = FAIL
index bf22442..6536465 100644 (file)
@@ -6,13 +6,13 @@
 # are met:
 #
 # 1.  Redistributions of source code must retain the above copyright
-#     notice, this list of conditions and the following disclaimer. 
+#     notice, this list of conditions and the following disclaimer.
 # 2.  Redistributions in binary form must reproduce the above copyright
 #     notice, this list of conditions and the following disclaimer in the
-#     documentation and/or other materials provided with the distribution. 
+#     documentation and/or other materials provided with the distribution.
 # 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
 #     its contributors may be used to endorse or promote products derived
-#     from this software without specific prior written permission. 
+#     from this software without specific prior written permission.
 #
 # THIS SOFTWARE IS PROVIDED BY APPLE AND ITS CONTRIBUTORS "AS IS" AND ANY
 # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED
@@ -618,13 +618,13 @@ canvas/philip/tests/2d.path.arc.scale.1.html
 # https://bugs.webkit.org/show_bug.cgi?id=81604
 http/tests/media/video-useragent.html
 media/audio-garbage-collect.html
+
 # parser test that times out waiting for notifyDone
 # http://bugs.webkit.org/show_bug.cgi?id=81618
 fast/workers/storage/use-same-database-in-page-and-workers.html
 
 # https://bugs.webkit.org/show_bug.cgi?id=81276
-# Allowed to regress to fix a crash. 
+# Allowed to regress to fix a crash.
 fast/inline/continuation-outlines-with-layers.html
 
 # Not possible to set UA string for media requests with all Mac media engines.
@@ -830,10 +830,6 @@ fast/dom/xmlhttprequest-constructor-in-detached-document.html
 # https://bugs.webkit.org/show_bug.cgi?id=85525
 media/video-played-reset.html
 
-# [Mac] IETC flexbox reference tests have pixel differences (due to embedded color profiles?)
-# https://bugs.webkit.org/show_bug.cgi?id=85666
-ietestcenter/css3/flexbox/
-
 # https://bugs.webkit.org/show_bug.cgi?id=85969
 http/tests/loading/post-in-iframe-with-back-navigation.html
 
index 02c4514..2041dbd 100644 (file)
@@ -195,7 +195,7 @@ BUGWK85408 : svg/batik/text/longTextOnPath.svg = TEXT PASS
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE
 BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE
-BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
+BUGWK85213 BUGWK85832 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
 
 // Requires rebaseline after bug 85031
 BUGWK85565 : fast/block/float/016.html = IMAGE
index 7bd74bf..3e0ae53 100644 (file)
@@ -2535,18 +2535,6 @@ http/tests/inspector/network/network-initiator.html
 # Requires ENABLE(MEDIA_CAPTURE)
 fast/forms/file/file-input-capture.html
 
-# [Qt] ietestcenter/css3/flexbox tests fail on 32 bit
-# https://bugs.webkit.org/show_bug.cgi?id=85596
-ietestcenter/css3/flexbox/flexbox-align-end-001.htm
-ietestcenter/css3/flexbox/flexbox-align-start-001.htm
-ietestcenter/css3/flexbox/flexbox-flex-001.htm
-ietestcenter/css3/flexbox/flexbox-flex-002.htm
-ietestcenter/css3/flexbox/flexbox-flex-003.htm
-ietestcenter/css3/flexbox/flexbox-groups-001.htm
-ietestcenter/css3/flexbox/flexbox-groups-002.htm
-ietestcenter/css3/flexbox/flexbox-groups-004.htm
-ietestcenter/css3/flexbox/flexbox-layout-003.htm
-
 # REGRESSION(r116134): It made 3 inspector tests fail
 inspector/debugger/scripts-panel.html
 inspector/debugger/snippets-model.html
index e2a07f0..22adf4d 100644 (file)
@@ -50,7 +50,7 @@ BUGWK85203 : ietestcenter/css3/multicolumn/column-containing-block-003.htm = IMA
 // IETC flexbox failures
 BUGWK85211 : ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm = IMAGE
 BUGWK85212 : ietestcenter/css3/flexbox/flexbox-layout-002.htm = IMAGE
-BUGWK85213 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
+BUGWK85213 BUGWK85832 : ietestcenter/css3/flexbox/flexbox-ordinal-group-001.htm = CRASH IMAGE
 
 // Generate results for your platform(s)
 BUGWK85567 : fast/images/png-suite/test.html = IMAGE