Unreviewed, rolling out r150034.
authorrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 May 2013 02:46:25 +0000 (02:46 +0000)
committerrniwa@webkit.org <rniwa@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 17 May 2013 02:46:25 +0000 (02:46 +0000)
http://trac.webkit.org/changeset/150034
https://bugs.webkit.org/show_bug.cgi?id=116257

This work around doesn't work due to another bug NSUndoManager
has (Requested by rniwa on #webkit).

Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-16

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::registerUndoOrRedoStep):

Source/WebKit2:

* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::registerEditCommand):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@150230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/mac/PageClientImpl.mm

index 074d150..39e8907 100644 (file)
@@ -1,3 +1,15 @@
+2013-05-16  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r150034.
+        http://trac.webkit.org/changeset/150034
+        https://bugs.webkit.org/show_bug.cgi?id=116257
+
+        This work around doesn't work due to another bug NSUndoManager
+        has (Requested by rniwa on #webkit).
+
+        * WebCoreSupport/WebEditorClient.mm:
+        (WebEditorClient::registerUndoOrRedoStep):
+
 2013-05-16  Tim Horton  <timothy_horton@apple.com>
 
         PDFPlugins don't load when plugins are disabled, but they should
index 099d2e7..2045d8e 100644 (file)
@@ -544,11 +544,9 @@ void WebEditorClient::registerUndoOrRedoStep(PassRefPtr<UndoStep> step, bool isR
     NSUndoManager *undoManager = [m_webView undoManager];
     NSString *actionName = undoNameForEditAction(step->editingAction());
     WebUndoStep *webEntry = [WebUndoStep stepWithUndoStep:step];
-    [undoManager beginUndoGrouping];
     [undoManager registerUndoWithTarget:m_undoTarget.get() selector:(isRedo ? @selector(redoEditing:) : @selector(undoEditing:)) object:webEntry];
     if (actionName)
         [undoManager setActionName:actionName];
-    [undoManager endUndoGrouping];
     m_haveUndoRedoOperations = YES;
 }
 
index dc936e5..20ca377 100644 (file)
@@ -1,3 +1,15 @@
+2013-05-16  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r150034.
+        http://trac.webkit.org/changeset/150034
+        https://bugs.webkit.org/show_bug.cgi?id=116257
+
+        This work around doesn't work due to another bug NSUndoManager
+        has (Requested by rniwa on #webkit).
+
+        * UIProcess/API/mac/PageClientImpl.mm:
+        (WebKit::PageClientImpl::registerEditCommand):
+
 2013-05-16  Tim Horton  <timothy_horton@apple.com>
 
         PDFPlugins don't load when plugins are disabled, but they should
index 447cd90..28bf821 100644 (file)
@@ -286,11 +286,9 @@ void PageClientImpl::registerEditCommand(PassRefPtr<WebEditCommandProxy> prpComm
     String actionName = WebEditCommandProxy::nameForEditAction(command->editAction());
 
     NSUndoManager *undoManager = [m_wkView undoManager];
-    [undoManager beginUndoGrouping];
     [undoManager registerUndoWithTarget:m_undoTarget.get() selector:((undoOrRedo == WebPageProxy::Undo) ? @selector(undoEditing:) : @selector(redoEditing:)) object:commandObjC.get()];
     if (!actionName.isEmpty())
         [undoManager setActionName:(NSString *)actionName];
-    [undoManager endUndoGrouping];
 }
 
 void PageClientImpl::clearAllEditCommands()