REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Nov 2018 09:11:23 +0000 (09:11 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 21 Nov 2018 09:11:23 +0000 (09:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191630

Reviewed by Michael Catanzaro.

Only flip Y in GlyphToPathTranslator for ports using CG.

* platform/graphics/FontCascade.cpp:
(WebCore::GlyphToPathTranslator::GlyphToPathTranslator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/graphics/FontCascade.cpp

index 9f7f572..230131d 100644 (file)
@@ -1,3 +1,15 @@
+2018-11-21  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r237845): [cairo] Hyperlink underscore layout issue
+        https://bugs.webkit.org/show_bug.cgi?id=191630
+
+        Reviewed by Michael Catanzaro.
+
+        Only flip Y in GlyphToPathTranslator for ports using CG.
+
+        * platform/graphics/FontCascade.cpp:
+        (WebCore::GlyphToPathTranslator::GlyphToPathTranslator):
+
 2018-11-21  Alicia Boya GarcĂ­a  <aboya@igalia.com>
 
         [MSE][GStreamer] Refactor AppendPipeline deinitialization
index db4ea6e..e2d31b2 100644 (file)
@@ -1739,8 +1739,11 @@ public:
         , m_textRun(textRun)
         , m_glyphBuffer(glyphBuffer)
         , m_fontData(glyphBuffer.fontAt(m_index))
-        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()).scale(1, -1))
+        , m_translation(AffineTransform::translation(textOrigin.x(), textOrigin.y()))
     {
+#if USE(CG)
+        m_translation.flipY();
+#endif
     }
 
     bool containsMorePaths() { return m_index != m_glyphBuffer.size(); }