Remove RTCRtpTransceiver.setDirection
authoryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 22:00:22 +0000 (22:00 +0000)
committeryouenn@apple.com <youenn@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 19 Dec 2018 22:00:22 +0000 (22:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=192869

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/historical-expected.txt:

Source/WebCore:

Covered by rebased test.

* Modules/mediastream/RTCRtpTransceiver.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/webrtc/historical-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/RTCRtpTransceiver.idl

index 2fb9a32..995fecb 100644 (file)
@@ -1,3 +1,12 @@
+2018-12-19  Youenn Fablet  <youenn@apple.com>
+
+        Remove RTCRtpTransceiver.setDirection
+        https://bugs.webkit.org/show_bug.cgi?id=192869
+
+        Reviewed by Alex Christensen.
+
+        * web-platform-tests/webrtc/historical-expected.txt:
+
 2018-12-18  Justin Michaud  <justin_michaud@apple.com>
 
         Update CSS Properties and Values API to use new cycle fallback behaviour
index 543897c..c8c8984 100644 (file)
@@ -9,7 +9,7 @@ PASS RTCPeerConnection member onaddstream should not exist
 PASS RTCPeerConnection member onremovestream should not exist 
 PASS RTCPeerConnection member removeStream should not exist 
 PASS RTCPeerConnection member updateIce should not exist 
-FAIL RTCRtpTransceiver member setDirection should not exist assert_false: expected false got true
+PASS RTCRtpTransceiver member setDirection should not exist 
 PASS DataChannel interface should not exist 
 PASS mozRTCIceCandidate interface should not exist 
 PASS mozRTCPeerConnection interface should not exist 
index dd94ab1..483474e 100644 (file)
@@ -1,3 +1,14 @@
+2018-12-19  Youenn Fablet  <youenn@apple.com>
+
+        Remove RTCRtpTransceiver.setDirection
+        https://bugs.webkit.org/show_bug.cgi?id=192869
+
+        Reviewed by Alex Christensen.
+
+        Covered by rebased test.
+
+        * Modules/mediastream/RTCRtpTransceiver.idl:
+
 2018-12-19  Jer Noble  <jer.noble@apple.com>
 
         Force synchronous decode in WebCoreDecompressionSession::decodeSampleSync()
index cc640f4..ef59b02 100644 (file)
@@ -41,8 +41,6 @@ typedef RTCRtpTransceiverDirection RtpTransceiverDirection;
     readonly attribute boolean stopped;
     attribute RtpTransceiverDirection direction;
     [EnabledAtRuntime=WebRTCUnifiedPlan] readonly attribute RTCRtpTransceiverDirection? currentDirection;
-    // FIXME: Remove setDirection
-    void setDirection(RtpTransceiverDirection direction);
     void stop();
     // FIXME 169662: missing setCodecPreferences
 };