libWebCoreTestSupport should have explicit exports
authorfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Oct 2013 14:33:52 +0000 (14:33 +0000)
committerfpizlo@apple.com <fpizlo@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 19 Oct 2013 14:33:52 +0000 (14:33 +0000)
https://bugs.webkit.org/show_bug.cgi?id=123053

Reviewed by Oliver Hunt.

No new tests because there is no change in behavior.

* Configurations/WebCoreTestSupport.xcconfig:
* testing/js/WebCoreTestSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@157667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Configurations/WebCoreTestSupport.xcconfig
Source/WebCore/testing/js/WebCoreTestSupport.h

index b997a76..0568115 100644 (file)
@@ -1,3 +1,15 @@
+2013-10-19  Filip Pizlo  <fpizlo@apple.com>
+
+        libWebCoreTestSupport should have explicit exports
+        https://bugs.webkit.org/show_bug.cgi?id=123053
+
+        Reviewed by Oliver Hunt.
+
+        No new tests because there is no change in behavior.
+
+        * Configurations/WebCoreTestSupport.xcconfig:
+        * testing/js/WebCoreTestSupport.h:
+
 2013-10-18  Andreas Kling  <akling@apple.com>
 
         Start passing RenderStyle around with PassRef.
index a19600b..84be763 100644 (file)
@@ -44,5 +44,6 @@ DYLIB_INSTALL_NAME_BASE_Release = $(DYLIB_INSTALL_NAME_BASE_Debug);
 PRODUCT_NAME = WebCoreTestSupport;
 EXECUTABLE_PREFIX = lib;
 EXPORTED_SYMBOLS_FILE = ;
+GCC_SYMBOLS_PRIVATE_EXTERN = YES;
 OTHER_LDFLAGS = $(ASAN_OTHER_LDFLAGS);
 SECTORDER_FLAGS = ;
index bfd8a8b..de7fc74 100644 (file)
 
 typedef const struct OpaqueJSContext* JSContextRef;
 
+#if PLATFORM(MAC)
+#define TEST_SUPPORT_EXPORT WTF_EXPORT_PRIVATE
+#else
+#define TEST_SUPPORT_EXPORT
+#endif
+
 namespace WebCoreTestSupport {
 
-void injectInternalsObject(JSContextRef);
-void resetInternalsObject(JSContextRef);
+void injectInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
+void resetInternalsObject(JSContextRef) TEST_SUPPORT_EXPORT;
 
 } // namespace WebCore