[webkitpy] perf profiler does not understand --call-graph argument
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Apr 2014 09:55:00 +0000 (09:55 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 3 Apr 2014 09:55:00 +0000 (09:55 +0000)
https://bugs.webkit.org/show_bug.cgi?id=131132

Reviewed by Ryosuke Niwa.

New versions of perf profiler have changed the argument from --call-graph to -g.

* Scripts/webkitpy/common/system/profiler.py:
(Perf.wrapper_arguments): Use -g instead of --call-graph.
* Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_profiler_as_wrapper): Update test accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@166711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/common/system/profiler.py
Tools/Scripts/webkitpy/port/driver_unittest.py

index e1affc0..23a0f4d 100644 (file)
@@ -1,3 +1,17 @@
+2014-04-03  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [webkitpy] perf profiler does not understand --call-graph argument
+        https://bugs.webkit.org/show_bug.cgi?id=131132
+
+        Reviewed by Ryosuke Niwa.
+
+        New versions of perf profiler have changed the argument from --call-graph to -g.
+
+        * Scripts/webkitpy/common/system/profiler.py:
+        (Perf.wrapper_arguments): Use -g instead of --call-graph.
+        * Scripts/webkitpy/port/driver_unittest.py:
+        (DriverTest.test_profiler_as_wrapper): Update test accordingly.
+
 2014-04-03  Zsolt Borbely  <zsborbely.u-szeged@partner.samsung.com>
 
         Add EFL WK2 performance bot to build.webkit.org
index 9c09f07..69ef205 100644 (file)
@@ -148,7 +148,7 @@ class Perf(SingleFileOutputProfiler):
         self._wait_process = self._host.executive.popen(["wait", "%d" % pid], shell=True)
 
     def wrapper_arguments(self):
-        return [self._perf_path(), "record", "--call-graph", "--output", self._output_path]
+        return [self._perf_path(), "record", "-g", "--output", self._output_path]
 
     def _first_ten_lines_of_profile(self, perf_output):
         output_lines = re.finditer(r"^(?:( [^\n]*?)\s*\n)", perf_output, re.MULTILINE)
index 787f2dc..b2fc3fe 100644 (file)
@@ -101,7 +101,7 @@ class DriverTest(unittest.TestCase):
 
     def test_profiler_as_wrapper(self):
         driver = Driver(self.make_port(MockSystemHost(os_name='linux'), MockOptions(profile=True, profiler='perf')), None, False)
-        self.assertEqual(driver._command_wrapper(), ['perf', 'record', '--call-graph', '--output', '/mock-build/layout-test-results/test.data'])
+        self.assertEqual(driver._command_wrapper(), ['perf', 'record', '-g', '--output', '/mock-build/layout-test-results/test.data'])
 
     def test_test_to_uri(self):
         port = self.make_port()