2009-03-27 Dirk Schulze <krit@webkit.org>

        Reviewed by Eric Seidel.

        We don't support images for GtkCursors yet. We need a  placeholder to avoid crashes.
        I took crosshair to have a common behavior with firefox.

        [GTK] SVG - Crash on setting the cursor icon
        https://bugs.webkit.org/show_bug.cgi?id=24565

        * platform/gtk/CursorGtk.cpp:
        (WebCore::Cursor::Cursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
index e9e2451..2a8e9b0 100644 (file)
--- a/WebCore/ChangeLog
+++ b/WebCore/ChangeLog
@@ -1,3 +1,16 @@
+2009-03-27  Dirk Schulze  <krit@webkit.org>
+
+        Reviewed by Eric Seidel.
+
+        We don't support images for GtkCursors yet. We need a  placeholder to avoid crashes.
+        I took crosshair to have a common behavior with firefox.
+
+        [GTK] SVG - Crash on setting the cursor icon
+        https://bugs.webkit.org/show_bug.cgi?id=24565
+
+        * platform/gtk/CursorGtk.cpp:
+        (WebCore::Cursor::Cursor):
+
 2009-03-27  Timothy Hatcher  <timothy@apple.com>
 
         Remove redundant attributes and functions from IDL files that have the

diff --git a/WebCore/platform/gtk/CursorGtk.cpp b/WebCore/platform/gtk/CursorGtk.cpp
index 76f6d00..dcb5b63 100644 (file)
--- a/WebCore/platform/gtk/CursorGtk.cpp
+++ b/WebCore/platform/gtk/CursorGtk.cpp
@@ -63,7 +63,13 @@ Cursor::Cursor(const Cursor& other)
 
 Cursor::Cursor(Image*, const IntPoint&)
 {
-    notImplemented();
+    // FIXME: We don't support images for cursors yet.
+    // This is just a placeholder to avoid crashes.
+    Cursor other(crossCursor());
+    m_impl = other.m_impl;
+
+    if (m_impl)
+        gdk_cursor_ref(m_impl);
 }
 
 Cursor::~Cursor()