Remove runtime toggle for pointer-lock
authordino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Dec 2016 02:53:41 +0000 (02:53 +0000)
committerdino@apple.com <dino@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Dec 2016 02:53:41 +0000 (02:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=165577
<rdar://problems/29566996>

Reviewed by Jon Lee.

Source/WebCore:

Remove any runtime calls to check if pointer-lock is enabled. It's
either compiled in or out.

Covered by existing tests.

* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setPointerLockEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::pointerLockEnabled): Deleted.
* dom/Document.idl:
* dom/Element.idl:
* page/Page.h:
* page/PointerLockController.cpp:
(WebCore::PointerLockController::requestPointerLock):
(WebCore::PointerLockController::requestPointerUnlock):
(WebCore::PointerLockController::requestPointerUnlockAndForceCursorVisible):

Source/WebKit/mac:

Remove any runtime calls to check if pointer-lock is enabled. It's
either compiled in or out.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences pointerLockEnabled]): Deleted.
(-[WebPreferences setPointerLockEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Source/WebKit2:

Remove any runtime calls to check if pointer-lock is enabled. It's
either compiled in or out.

* Shared/WebPreferencesDefinitions.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetPointerLockEnabled): Deleted.
(WKPreferencesGetPointerLockEnabled): Deleted.
* UIProcess/API/C/WKPreferencesRefPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

Tools:

Remove any runtime calls to check if pointer-lock is enabled. It's
either compiled in or out.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebPreferencesToConsistentValues):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

Websites/webkit.org:

No need to have pointer-lock tested.

* experimental-features.html: Also sort the list alphabetically.

LayoutTests:

Remove any runtime calls to check if pointer-lock is enabled. It's
either compiled in or out.

* platform/mac/TestExpectations: Enable the pointer-lock tests that should work.
* pointer-lock/pointer-lock-api.html: Fix a bad DOM call.
* pointer-lock/pointerlock-interface-disabled-expected.txt: Removed.
* pointer-lock/pointerlock-interface-disabled.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

28 files changed:
LayoutTests/ChangeLog
LayoutTests/platform/mac/TestExpectations
LayoutTests/pointer-lock/lock-lost-on-esc-in-fullscreen.html
LayoutTests/pointer-lock/pointer-lock-api.html
LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt [deleted file]
LayoutTests/pointer-lock/pointerlock-interface-disabled.html [deleted file]
LayoutTests/pointer-lock/pointerlock-interface.html
Source/WebCore/ChangeLog
Source/WebCore/bindings/generic/RuntimeEnabledFeatures.h
Source/WebCore/dom/Document.idl
Source/WebCore/dom/Element.idl
Source/WebCore/page/Page.h
Source/WebCore/page/PointerLockController.cpp
Source/WebKit/mac/ChangeLog
Source/WebKit/mac/WebView/WebPreferenceKeysPrivate.h
Source/WebKit/mac/WebView/WebPreferences.mm
Source/WebKit/mac/WebView/WebPreferencesPrivate.h
Source/WebKit/mac/WebView/WebView.mm
Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebPreferencesDefinitions.h
Source/WebKit2/UIProcess/API/C/WKPreferences.cpp
Source/WebKit2/UIProcess/API/C/WKPreferencesRefPrivate.h
Source/WebKit2/WebProcess/WebPage/WebPage.cpp
Tools/ChangeLog
Tools/DumpRenderTree/mac/DumpRenderTree.mm
Tools/WebKitTestRunner/TestController.cpp
Websites/webkit.org/ChangeLog
Websites/webkit.org/experimental-features.html

index da5432d..780919b 100644 (file)
@@ -1,3 +1,19 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        Remove any runtime calls to check if pointer-lock is enabled. It's
+        either compiled in or out.
+
+        * platform/mac/TestExpectations: Enable the pointer-lock tests that should work.
+        * pointer-lock/pointer-lock-api.html: Fix a bad DOM call.
+        * pointer-lock/pointerlock-interface-disabled-expected.txt: Removed.
+        * pointer-lock/pointerlock-interface-disabled.html: Removed.
+
 2016-12-07  Dave Hyatt  <hyatt@apple.com>
 
         [CSS Parser] Unskip gradients tests
index 5693509..9b3f257 100644 (file)
@@ -278,8 +278,16 @@ fast/events/platform-wheelevent-paging-y-in-non-scrolling-page.html
 fast/events/platform-wheelevent-paging-y-in-scrolling-div.html
 fast/events/platform-wheelevent-paging-y-in-scrolling-page.html
 
-# Pointer Lock is not implemented.
-pointer-lock/
+# Pointer Lock can only check some of the API at the moment.
+pointer-lock/bug90391-move-then-window-open-crash.html
+pointer-lock/lock-already-locked.html
+pointer-lock/lock-element-not-in-dom.html
+pointer-lock/locked-element-iframe-removed-from-dom.html
+pointer-lock/locked-element-removed-from-dom.html
+pointer-lock/mouse-event-delivery.html
+pointer-lock/pointerlockchange-event-on-lock-lost.html
+pointer-lock/pointerlockchange-pointerlockerror-events.html
+pointer-lock/pointerlockelement-null-when-pending.html
 http/tests/pointer-lock/
 
 webkit.org/b/82763 fast/forms/textarea-placeholder-set-attribute.html
index 82cce50..5438286 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE HTML><!-- webkit-test-runner [ enablePointerLock=true ] -->
+<!DOCTYPE HTML>
 <html>
 <head>
 <script src="../http/tests/resources/js-test-pre.js"></script>
index e55869d..de7be3b 100644 (file)
@@ -11,7 +11,7 @@
     shouldBeDefined("document.onpointerlockerror");
     shouldBeDefined("document.exitPointerLock");
     shouldEvaluateTo("document.pointerLockElement", null);
-    element = document.createElement();
+    element = document.createElement("div");
     shouldBeDefined("element.requestPointerLock");
 </script>
 <script src="../http/tests/resources/js-test-post.js"></script>
diff --git a/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt b/LayoutTests/pointer-lock/pointerlock-interface-disabled-expected.txt
deleted file mode 100644 (file)
index 9305cbd..0000000
+++ /dev/null
@@ -1,7 +0,0 @@
-
-PASS Document.prototype.exitPointerLock does not exist 
-PASS Document.prototype.pointerLockElement does not exist 
-PASS Document.prototype.onpointerlockchange does not exist 
-PASS Document.prototype.onpointerlockerror does not exist 
-PASS Element.prototype.requestPointerLock does not exist 
-
diff --git a/LayoutTests/pointer-lock/pointerlock-interface-disabled.html b/LayoutTests/pointer-lock/pointerlock-interface-disabled.html
deleted file mode 100644 (file)
index cb0ada6..0000000
+++ /dev/null
@@ -1,32 +0,0 @@
-<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=false ] -->
-<head>
-    <title>PointerLock interface tests.</title>
-    <link rel="help" href="https://w3c.github.io/pointerlock/">
-    <script src="../resources/testharness.js"></script>
-    <script src="../resources/testharnessreport.js"></script>
-</head>
-<body>
-<div id="log"></div>
-<script>
-test(function() {
-    assert_false('exitPointerLock' in Document.prototype);
-},'Document.prototype.exitPointerLock does not exist');
-
-test(function() {
-    assert_false('pointerLockElement' in Document.prototype);
-},'Document.prototype.pointerLockElement does not exist');
-
-test(function() {
-    assert_false('onpointerlockchange' in Document.prototype);
-},'Document.prototype.onpointerlockchange does not exist');
-
-test(function() {
-    assert_false('onpointerlockerror' in Document.prototype);
-},'Document.prototype.onpointerlockerror does not exist');
-
-test(function() {
-    assert_false('requestPointerLock' in Element.prototype);
-},'Element.prototype.requestPointerLock does not exist');
-</script>
-</body>
-</html>
index ef8d913..af10c20 100644 (file)
@@ -1,4 +1,4 @@
-<!DOCTYPE html><!-- webkit-test-runner [ enablePointerLock=true ] -->
+<!DOCTYPE html>
 <head>
     <title>PointerLock interface tests.</title>
     <link rel="help" href="https://w3c.github.io/pointerlock/">
index cc80b2c..ab14bf9 100644 (file)
@@ -1,3 +1,27 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        Remove any runtime calls to check if pointer-lock is enabled. It's
+        either compiled in or out.
+
+        Covered by existing tests.
+
+        * bindings/generic/RuntimeEnabledFeatures.h:
+        (WebCore::RuntimeEnabledFeatures::setPointerLockEnabled): Deleted.
+        (WebCore::RuntimeEnabledFeatures::pointerLockEnabled): Deleted.
+        * dom/Document.idl:
+        * dom/Element.idl:
+        * page/Page.h:
+        * page/PointerLockController.cpp:
+        (WebCore::PointerLockController::requestPointerLock):
+        (WebCore::PointerLockController::requestPointerUnlock):
+        (WebCore::PointerLockController::requestPointerUnlockAndForceCursorVisible):
+
 2016-12-07  John Wilander  <wilander@apple.com>
 
         Allow commas in Accept, Accept-Language, and Content-Language request headers for simple CORS
index 16c88d3..26fa2a0 100644 (file)
@@ -212,11 +212,6 @@ public:
     bool webGL2Enabled() const { return m_isWebGL2Enabled; }
 #endif
 
-#if ENABLE(POINTER_LOCK)
-    void setPointerLockEnabled(bool isEnabled) { m_isPointerLockEnabled = isEnabled; }
-    bool pointerLockEnabled() const { return m_isPointerLockEnabled; }
-#endif
-
 #if ENABLE(FETCH_API)
     void setFetchAPIEnabled(bool isEnabled) { m_isFetchAPIEnabled = isEnabled; }
     bool fetchAPIEnabled() const { return m_isFetchAPIEnabled; }
@@ -352,10 +347,6 @@ private:
     bool m_isWebGL2Enabled;
 #endif
 
-#if ENABLE(POINTER_LOCK)
-    bool m_isPointerLockEnabled;
-#endif
-
 #if ENABLE(FETCH_API)
     bool m_isFetchAPIEnabled { false };
 #endif
index 4c21b9f..0bcc6e6 100644 (file)
     void webkitExitFullscreen();
 #endif
 
-    [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void exitPointerLock();
-    [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] readonly attribute Element? pointerLockElement;
+    [Conditional=POINTER_LOCK] void exitPointerLock();
+    [Conditional=POINTER_LOCK] readonly attribute Element? pointerLockElement;
 
     [Conditional=CSS_REGIONS] DOMNamedFlowCollection webkitGetNamedFlows();
 
     // Unique to Document
     [LenientThis] attribute EventHandler onreadystatechange;
     [NotEnumerable, Conditional=CSP_NEXT] attribute EventHandler onsecuritypolicyviolation;
-    [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockchange;
-    [NotEnumerable, Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] attribute EventHandler onpointerlockerror;
+    [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockchange;
+    [NotEnumerable, Conditional=POINTER_LOCK] attribute EventHandler onpointerlockerror;
 };
 
 Document implements ParentNode;
index 3e93c75..8197515 100644 (file)
     [CEReactions, MayThrowException] void insertAdjacentHTML(DOMString where, DOMString html);
     [MayThrowException] void insertAdjacentText(DOMString where, DOMString text);
 
-    [Conditional=POINTER_LOCK, EnabledAtRuntime=PointerLock] void requestPointerLock();
+    [Conditional=POINTER_LOCK] void requestPointerLock();
 
     // CSS Regions API
     [Conditional=CSS_REGIONS] readonly attribute DOMString webkitRegionOverset;
index 22834ff..9f86f34 100644 (file)
@@ -108,7 +108,9 @@ class PlugInClient;
 class PluginData;
 class PluginInfoProvider;
 class PluginViewBase;
+#if ENABLE(POINTER_LOCK)
 class PointerLockController;
+#endif
 class ProgressTracker;
 class ProgressTrackerClient;
 class Range;
index 0b0ba11..57001c5 100644 (file)
@@ -50,9 +50,6 @@ PointerLockController::PointerLockController(Page& page)
 
 void PointerLockController::requestPointerLock(Element* target)
 {
-    if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
-        return;
-
     if (!target || !target->inDocument() || m_documentOfRemovedElementWhileWaitingForUnlock) {
         enqueueEvent(eventNames().pointerlockerrorEvent, target);
         return;
@@ -93,15 +90,12 @@ void PointerLockController::requestPointerUnlock()
     if (!m_element)
         return;
 
-    if (!RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
-        return;
-
     m_page.chrome().client().requestPointerUnlock();
 }
 
 void PointerLockController::requestPointerUnlockAndForceCursorVisible()
 {
-    if (!m_element || !RuntimeEnabledFeatures::sharedFeatures().pointerLockEnabled())
+    if (!m_element)
         return;
 
     m_page.chrome().client().requestPointerUnlock();
index adc6734..0a4a11b 100644 (file)
@@ -1,3 +1,22 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        Remove any runtime calls to check if pointer-lock is enabled. It's
+        either compiled in or out.
+
+        * WebView/WebPreferenceKeysPrivate.h:
+        * WebView/WebPreferences.mm:
+        (-[WebPreferences pointerLockEnabled]): Deleted.
+        (-[WebPreferences setPointerLockEnabled:]): Deleted.
+        * WebView/WebPreferencesPrivate.h:
+        * WebView/WebView.mm:
+        (-[WebView _preferencesChanged:]):
+
 2016-12-06  Alexey Proskuryakov  <ap@apple.com>
 
         Correct SDKROOT values in xcconfig files
index 1f968f1..8003779 100644 (file)
 #define WebKitCSSGridLayoutEnabledPreferenceKey @"WebKitCSSGridLayoutEnabled"
 #define WebKitVisualViewportEnabledPreferenceKey @"WebKitVisualViewportEnabled"
 #define WebKitModernMediaControlsEnabledPreferenceKey @"WebKitModernMediaControlsEnabled"
-#define WebKitPointerLockEnabledPreferenceKey @"WebKitPointerLockEnabled"
 #define WebKitSubtleCryptoEnabledPreferenceKey @"WebKitSubtleCryptoEnabled"
 
 #if !TARGET_OS_IPHONE
index 96b8078..2dac1f7 100644 (file)
@@ -2380,16 +2380,6 @@ static NSString *classIBCreatorID = nil;
     [self _setBoolValue:flag forKey:WebKitAllowsPictureInPictureMediaPlaybackPreferenceKey];
 }
 
-- (BOOL)pointerLockEnabled
-{
-    return [self _boolValueForKey:WebKitPointerLockEnabledPreferenceKey];
-}
-
-- (void)setPointerLockEnabled:(BOOL)flag
-{
-    [self _setBoolValue:flag forKey:WebKitPointerLockEnabledPreferenceKey];
-}
-
 - (BOOL)mockScrollbarsEnabled
 {
     return [self _boolValueForKey:WebKitMockScrollbarsEnabledPreferenceKey];
index 2518c26..aab739e 100644 (file)
@@ -284,9 +284,6 @@ extern NSString *WebPreferencesCacheModelChangedInternalNotification;
 - (void)setAllowsPictureInPictureMediaPlayback:(BOOL)flag;
 - (BOOL)allowsPictureInPictureMediaPlayback;
 
-- (void)setPointerLockEnabled:(BOOL)flag;
-- (BOOL)pointerLockEnabled;
-
 - (NSString *)pictographFontFamily;
 - (void)setPictographFontFamily:(NSString *)family;
 
index 5e6b8df..b11d0e4 100644 (file)
@@ -2842,10 +2842,6 @@ static bool needsSelfRetainWhileLoadingQuirk()
 
     RuntimeEnabledFeatures::sharedFeatures().setCustomElementsEnabled([preferences customElementsEnabled]);
 
-#if ENABLE(POINTER_LOCK)
-    RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled([preferences pointerLockEnabled]);
-#endif
-
 #if ENABLE(FETCH_API)
     RuntimeEnabledFeatures::sharedFeatures().setFetchAPIEnabled([preferences fetchAPIEnabled]);
 #endif
index 2638d87..d9aa676 100644 (file)
@@ -1,3 +1,22 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        Remove any runtime calls to check if pointer-lock is enabled. It's
+        either compiled in or out.
+
+        * Shared/WebPreferencesDefinitions.h:
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetPointerLockEnabled): Deleted.
+        (WKPreferencesGetPointerLockEnabled): Deleted.
+        * UIProcess/API/C/WKPreferencesRefPrivate.h:
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences):
+
 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
 
         [MediaStream][Mac] Revoke sandbox extensions when capture ends
index c8bc252..6da614b 100644 (file)
     macro(SubtleCryptoEnabled, subtleCryptoEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "SubtleCrypto", "Enable SubtleCrypto support") \
     macro(WebGL2Enabled, webGL2Enabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "WebGL 2.0", "WebGL 2 prototype") \
     macro(ES6ModulesEnabled, es6ModulesEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "ES6 Modules", "Enable ES6 Modules support") \
-    macro(PointerLockEnabled, pointerLockEnabled, Bool, bool, DEFAULT_EXPERIMENTAL_FEATURES_ENABLED, "PointerLock", "Pointer Lock API support") \
     \
 
 #if PLATFORM(COCOA)
index 9c32841..bdfbd76 100644 (file)
@@ -832,16 +832,6 @@ bool WKPreferencesGetModernMediaControlsEnabled(WKPreferencesRef preferencesRef)
     return toImpl(preferencesRef)->modernMediaControlsEnabled();
 }
 
-void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag)
-{
-    toImpl(preferencesRef)->setPointerLockEnabled(flag);
-}
-
-bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef)
-{
-    return toImpl(preferencesRef)->pointerLockEnabled();
-}
-
 void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag)
 {
     toImpl(preferencesRef)->setShowsToolTipOverTruncatedText(flag);
index e8e5c38..4940b20 100644 (file)
@@ -209,10 +209,6 @@ WK_EXPORT void WKPreferencesSetModernMediaControlsEnabled(WKPreferencesRef prefe
 WK_EXPORT bool WKPreferencesGetModernMediaControlsEnabled(WKPreferencesRef preferencesRef);
 
 // Defaults to false.
-WK_EXPORT void WKPreferencesSetPointerLockEnabled(WKPreferencesRef preferencesRef, bool flag);
-WK_EXPORT bool WKPreferencesGetPointerLockEnabled(WKPreferencesRef preferencesRef);
-
-// Defaults to false.
 WK_EXPORT void WKPreferencesSetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef, bool flag);
 WK_EXPORT bool WKPreferencesGetShowsToolTipOverTruncatedText(WKPreferencesRef preferencesRef);
 
index 368c917..fab953e 100644 (file)
@@ -3185,10 +3185,6 @@ void WebPage::updatePreferences(const WebPreferencesStore& store)
     RuntimeEnabledFeatures::sharedFeatures().setWebGL2Enabled(store.getBoolValueForKey(WebPreferencesKey::webGL2EnabledKey()));
 #endif
 
-#if ENABLE(POINTER_LOCK)
-    RuntimeEnabledFeatures::sharedFeatures().setPointerLockEnabled(store.getBoolValueForKey(WebPreferencesKey::pointerLockEnabledKey()));
-#endif
-
     settings.setSpringTimingFunctionEnabled(store.getBoolValueForKey(WebPreferencesKey::springTimingFunctionEnabledKey()));
 
     settings.setVisualViewportEnabled(store.getBoolValueForKey(WebPreferencesKey::visualViewportEnabledKey()));
index 9dc685d..bc9dd1a 100644 (file)
@@ -1,3 +1,19 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        Remove any runtime calls to check if pointer-lock is enabled. It's
+        either compiled in or out.
+
+        * DumpRenderTree/mac/DumpRenderTree.mm:
+        (resetWebPreferencesToConsistentValues):
+        * WebKitTestRunner/TestController.cpp:
+        (WTR::TestController::resetPreferencesToConsistentValues):
+
 2016-12-07  Eric Carlson  <eric.carlson@apple.com>
 
         [MediaStream][Mac] Revoke sandbox extensions when capture ends
index fbc522a..dc5817e 100644 (file)
@@ -1000,7 +1000,6 @@ static void resetWebPreferencesToConsistentValues(const TestOptions& options)
 
     preferences.intersectionObserverEnabled = options.enableIntersectionObserver;
     preferences.modernMediaControlsEnabled = options.enableModernMediaControls;
-    preferences.pointerLockEnabled = options.enablePointerLock;
 
     [preferences setSubtleCryptoEnabled:YES];
 
index 082e692..d0bc249 100644 (file)
@@ -665,7 +665,6 @@ void TestController::resetPreferencesToConsistentValues(const TestOptions& optio
     WKPreferencesSetNeedsSiteSpecificQuirks(preferences, options.needsSiteSpecificQuirks);
     WKPreferencesSetIntersectionObserverEnabled(preferences, options.enableIntersectionObserver);
     WKPreferencesSetModernMediaControlsEnabled(preferences, options.enableModernMediaControls);
-    WKPreferencesSetPointerLockEnabled(preferences, options.enablePointerLock);
 
     static WKStringRef defaultTextEncoding = WKStringCreateWithUTF8CString("ISO-8859-1");
     WKPreferencesSetDefaultTextEncodingName(preferences, defaultTextEncoding);
index ad01653..c77eea6 100644 (file)
@@ -1,3 +1,15 @@
+2016-12-07  Dean Jackson  <dino@apple.com>
+
+        Remove runtime toggle for pointer-lock
+        https://bugs.webkit.org/show_bug.cgi?id=165577
+        <rdar://problems/29566996>
+
+        Reviewed by Jon Lee.
+
+        No need to have pointer-lock tested.
+
+        * experimental-features.html: Also sort the list alphabetically.
+
 2016-12-05  Dean Jackson  <dino@apple.com>
 
         pointer lock needs to be feature detectable
index c4553c9..0095416 100644 (file)
@@ -99,10 +99,6 @@ function testInputEvents() {
     return window.InputEvent;
 }
 
-function testPointerLock() {
-    return "exitPointerLock" in Document.prototype;
-}
-
 function testES6Modules() {
     return window.es6modules;
 }
@@ -124,14 +120,13 @@ window.addEventListener("load", function () {
         <p>These tests do not exercise actual functionality. They are just the most basic check to see if the feature claims to be available.</p>
 
         <div class="test" id="CSSGrid"><p>CSS Grid</p></div>
+        <div class="test" id="SpringAnimation"><p>CSS Spring Animations</p></div>
+        <div class="test" id="ES6Modules"><p>ES6 Modules in HTML</p></div>
         <div class="test" id="Gamepad"><p>Gamepad API</p></div>
-        <div class="test" id="VariationFonts"><p>Variation Fonts</p></div>
-        <div class="test" id="PointerLock"><p>Mouse Pointer Lock</p></div>
-        <div class="test" id="WebGL2"><p>WebGL 2.0</p></div>
         <div class="test" id="FormValidation"><p>HTML Form Validation</p></div>
         <div class="test" id="InputEvents"><p>HTML Input Events</p></div>
-        <div class="test" id="SpringAnimation"><p>CSS Spring Animations</p></div>
-        <div class="test" id="ES6Modules"><p>ES6 Modules in HTML</p></div>
+        <div class="test" id="VariationFonts"><p>Variation Fonts</p></div>
+        <div class="test" id="WebGL2"><p>WebGL 2.0</p></div>
     </div>
 </body>
 </html>