2011-06-20 Eric Seidel <eric@webkit.org>
authoreric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 20 Jun 2011 21:23:25 +0000 (21:23 +0000)
committereric@webkit.org <eric@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 20 Jun 2011 21:23:25 +0000 (21:23 +0000)
        Reviewed by Adam Barth.

        commit-queue/ews-bots should run run-bindings-tests for every patch
        https://bugs.webkit.org/show_bug.cgi?id=63010

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/steps/runtests.py:
        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
        * Scripts/webkitpy/tool/steps/steps_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/common/config/ports.py
Tools/Scripts/webkitpy/tool/commands/download_unittest.py
Tools/Scripts/webkitpy/tool/steps/runtests.py
Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py
Tools/Scripts/webkitpy/tool/steps/steps_unittest.py

index fe38e11..5e8ee1b 100644 (file)
@@ -1,3 +1,16 @@
+2011-06-20  Eric Seidel  <eric@webkit.org>
+
+        Reviewed by Adam Barth.
+
+        commit-queue/ews-bots should run run-bindings-tests for every patch
+        https://bugs.webkit.org/show_bug.cgi?id=63010
+
+        * Scripts/webkitpy/common/config/ports.py:
+        * Scripts/webkitpy/tool/commands/download_unittest.py:
+        * Scripts/webkitpy/tool/steps/runtests.py:
+        * Scripts/webkitpy/tool/steps/runtests_unittest.py:
+        * Scripts/webkitpy/tool/steps/steps_unittest.py:
+
 2011-06-20  Chang Shu  <cshu@webkit.org>
 
         Reviewed by Adam Barth.
index 63926d4..fa0004b 100644 (file)
@@ -118,6 +118,10 @@ class WebKitPort(object):
         return cls.script_shell_command("test-webkitperl")
 
     @classmethod
+    def run_bindings_tests_command(cls):
+        return cls.script_shell_command("run-bindings-tests")
+
+    @classmethod
     def layout_tests_results_path(cls):
         return "/tmp/layout-test-results/results.html"
 
index 15f3dfa..572ae78 100644 (file)
@@ -89,7 +89,7 @@ class DownloadCommandsTest(CommandsTest):
         self.assert_execute_outputs(Build(), [], options=self._default_options(), expected_stderr=expected_stderr)
 
     def test_build_and_test(self):
-        expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
+        expected_stderr = "Updating working directory\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\n"
         self.assert_execute_outputs(BuildAndTest(), [], options=self._default_options(), expected_stderr=expected_stderr)
 
     def test_apply_attachment(self):
@@ -107,7 +107,7 @@ class DownloadCommandsTest(CommandsTest):
         self.assert_execute_outputs(ApplyFromBug(), [42], options=options, expected_stderr=expected_stderr)
 
     def test_land_diff(self):
-        expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
+        expected_stderr = "Building WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n"
         mock_tool = MockTool()
         mock_tool.scm().create_patch = Mock(return_value="Patch1\nMockPatch\n")
         mock_tool.checkout().modified_changelogs = Mock(return_value=[])
@@ -117,7 +117,7 @@ class DownloadCommandsTest(CommandsTest):
         self.assertEqual(mock_tool.checkout().modified_changelogs.call_count, 1)
 
     def test_land_red_builders(self):
-        expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
+        expected_stderr = '\nWARNING: Builders ["Builder2"] are red, please watch your commit carefully.\nSee http://dummy_buildbot_host/console?category=core\n\nBuilding WebKit\nRunning Python unit tests\nRunning Perl unit tests\nRunning Bindings tests\nRunning JavaScriptCore tests\nRunning run-webkit-tests\nCommitted r49824: <http://trac.webkit.org/changeset/49824>\nUpdating bug 42\n'
         mock_tool = MockTool()
         mock_tool.buildbot.light_tree_on_fire()
         self.assert_execute_outputs(Land(), [42], options=self._default_options(), expected_stderr=expected_stderr, tool=mock_tool)
@@ -143,6 +143,7 @@ Processing patch 197 from bug 42.
 Building WebKit
 Running Python unit tests
 Running Perl unit tests
+Running Bindings tests
 Running JavaScriptCore tests
 Running run-webkit-tests
 Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -159,6 +160,7 @@ Processing patch 197 from bug 42.
 Building WebKit
 Running Python unit tests
 Running Perl unit tests
+Running Bindings tests
 Running JavaScriptCore tests
 Running run-webkit-tests
 Committed r49824: <http://trac.webkit.org/changeset/49824>
@@ -168,6 +170,7 @@ Processing patch 128 from bug 42.
 Building WebKit
 Running Python unit tests
 Running Perl unit tests
+Running Bindings tests
 Running JavaScriptCore tests
 Running run-webkit-tests
 Committed r49824: <http://trac.webkit.org/changeset/49824>
index 780b1ad..4cce376 100644 (file)
@@ -56,6 +56,11 @@ class RunTests(AbstractStep):
             log("Running Perl unit tests")
             self._tool.executive.run_and_throw_if_fail(perl_unittests_command)
 
+        bindings_tests_command = self._tool.port().run_bindings_tests_command()
+        if bindings_tests_command:
+            log("Running Bindings tests")
+            self._tool.executive.run_and_throw_if_fail(bindings_tests_command)
+
         javascriptcore_tests_command = self._tool.port().run_javascriptcore_tests_command()
         if javascriptcore_tests_command:
             log("Running JavaScriptCore tests")
index 35c1323..1996b7b 100644 (file)
@@ -38,7 +38,8 @@ class RunTestsTest(unittest.TestCase):
         tool._port.run_python_unittests_command = lambda: None
         tool._port.run_perl_unittests_command = lambda: None
         step = RunTests(tool, MockOptions(test=True, non_interactive=True, quiet=False))
-        expected_stderr = """Running JavaScriptCore tests
+        expected_stderr = """Running Bindings tests
+Running JavaScriptCore tests
 Running run-webkit-tests
 """
         OutputCapture().assert_outputs(self, step.run, [{}], expected_stderr=expected_stderr)
index 5373598..72e2762 100644 (file)
@@ -79,6 +79,8 @@ class StepsTest(unittest.TestCase):
 MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitpy']
 Running Perl unit tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/test-webkitperl']
+Running Bindings tests
+MOCK run_and_throw_if_fail: ['Tools/Scripts/run-bindings-tests']
 Running JavaScriptCore tests
 MOCK run_and_throw_if_fail: ['Tools/Scripts/run-javascriptcore-tests']
 Running run-webkit-tests