Fix more -Wunused-private-field violations
authorthakis@chromium.org <thakis@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Jul 2012 18:11:10 +0000 (18:11 +0000)
committerthakis@chromium.org <thakis@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 20 Jul 2012 18:11:10 +0000 (18:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=91876

Reviewed by Adam Barth.

As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
the warning finds more bugs. Fix them.

* html/FTPDirectoryDocument.cpp:
(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
* html/parser/HTMLTreeBuilder.h:
(HTMLTreeBuilder):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
* inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(Settings):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::CCThreadProxy):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* rendering/svg/RenderSVGTextPath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
Source/WebCore/ChangeLog
Source/WebCore/html/FTPDirectoryDocument.cpp
Source/WebCore/html/parser/HTMLTreeBuilder.cpp
Source/WebCore/html/parser/HTMLTreeBuilder.h
Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
Source/WebCore/html/shadow/MediaControlRootElementChromium.h
Source/WebCore/inspector/InspectorDOMStorageResource.cpp
Source/WebCore/inspector/InspectorDOMStorageResource.h
Source/WebCore/page/Settings.cpp
Source/WebCore/page/Settings.h
Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.cpp
Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
Source/WebCore/rendering/svg/RenderSVGTextPath.h

index 16558c6..0a18bcf 100644 (file)
@@ -1,3 +1,40 @@
+2012-07-20  Nico Weber  <thakis@chromium.org>
+
+        Fix more -Wunused-private-field violations
+        https://bugs.webkit.org/show_bug.cgi?id=91876
+
+        Reviewed by Adam Barth.
+
+        As of http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20120716/061102.html
+        the warning finds more bugs. Fix them.
+
+        * html/FTPDirectoryDocument.cpp:
+        (FTPDirectoryDocumentParser):
+        (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
+        * html/parser/HTMLTreeBuilder.cpp:
+        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
+        * html/parser/HTMLTreeBuilder.h:
+        (HTMLTreeBuilder):
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+        * html/shadow/MediaControlRootElementChromium.h:
+        (MediaControlRootElementChromium):
+        * inspector/InspectorDOMStorageResource.cpp:
+        (WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
+        * inspector/InspectorDOMStorageResource.h:
+        (InspectorDOMStorageResource):
+        * page/Settings.cpp:
+        (WebCore::Settings::Settings):
+        * page/Settings.h:
+        (Settings):
+        * platform/graphics/chromium/cc/CCThreadProxy.cpp:
+        (WebCore::CCThreadProxy::CCThreadProxy):
+        * platform/graphics/chromium/cc/CCThreadProxy.h:
+        (CCThreadProxy):
+        * rendering/svg/RenderSVGTextPath.cpp:
+        (WebCore::RenderSVGTextPath::RenderSVGTextPath):
+        * rendering/svg/RenderSVGTextPath.h:
+
 2012-07-20  Adam Klein  <adamk@chromium.org>
 
         CodeGeneratorInspector.py is unnecessarily chatty
index 412a1fe..18689c9 100644 (file)
@@ -88,7 +88,6 @@ private:
     RefPtr<HTMLTableElement> m_tableElement;
 
     bool m_skipLF;
-    bool m_parsedTemplate;
     
     int m_size;
     UChar* m_buffer;
@@ -101,7 +100,6 @@ private:
 FTPDirectoryDocumentParser::FTPDirectoryDocumentParser(HTMLDocument* document)
     : HTMLDocumentParser(document, false)
     , m_skipLF(false)
-    , m_parsedTemplate(false)
     , m_size(254)
     , m_buffer(static_cast<UChar*>(fastMalloc(sizeof(UChar) * m_size)))
     , m_dest(m_buffer)
index 803b0e7..f39a2a7 100644 (file)
@@ -346,11 +346,10 @@ private:
 };
 
 
-HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool reportErrors, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
+HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, HTMLDocument* document, bool, bool usePreHTML5ParserQuirks, unsigned maximumDOMTreeDepth)
     : m_framesetOk(true)
     , m_document(document)
     , m_tree(document, maximumDOMTreeDepth)
-    , m_reportErrors(reportErrors)
     , m_insertionMode(InitialMode)
     , m_originalInsertionMode(InitialMode)
     , m_shouldSkipLeadingNewline(false)
@@ -367,7 +366,6 @@ HTMLTreeBuilder::HTMLTreeBuilder(HTMLDocumentParser* parser, DocumentFragment* f
     , m_fragmentContext(fragment, contextElement, scriptingPermission)
     , m_document(fragment->document())
     , m_tree(fragment, scriptingPermission, maximumDOMTreeDepth)
-    , m_reportErrors(false) // FIXME: Why not report errors in fragments?
     , m_insertionMode(InitialMode)
     , m_originalInsertionMode(InitialMode)
     , m_shouldSkipLeadingNewline(false)
index e7c6890..6d8e719 100644 (file)
@@ -213,8 +213,6 @@ private:
     Document* m_document;
     HTMLConstructionSite m_tree;
 
-    bool m_reportErrors;
-
     // http://www.whatwg.org/specs/web-apps/current-work/multipage/parsing.html#insertion-mode
     InsertionMode m_insertionMode;
 
index 9edbd8a..d9dadef 100644 (file)
@@ -80,7 +80,6 @@ MediaControlRootElementChromium::MediaControlRootElementChromium(Document* docum
 #if ENABLE(VIDEO_TRACK)
     , m_textDisplayContainer(0)
 #endif
-    , m_opaque(true)
     , m_hideFullscreenControlsTimer(this, &MediaControlRootElementChromium::hideFullscreenControlsTimerFired)
     , m_isMouseOverControls(false)
     , m_isFullscreen(false)
index f86bc61..2fb4c3c 100644 (file)
@@ -149,7 +149,6 @@ private:
     MediaControlTextTrackContainerElement* m_textDisplayContainer;
 #endif
 
-    bool m_opaque;
     Timer<MediaControlRootElementChromium> m_hideFullscreenControlsTimer;
     bool m_isMouseOverControls;
     bool m_isFullscreen;
index 4c727bc..0ae1207 100644 (file)
@@ -57,7 +57,6 @@ InspectorDOMStorageResource::InspectorDOMStorageResource(StorageArea* storageAre
     , m_frame(frame)
     , m_frontend(0)
     , m_id(String::number(s_nextUnusedId++))
-    , m_reportingChangesToFrontend(false)
 {
 }
 
index 332ef28..9256949 100644 (file)
@@ -66,7 +66,6 @@ private:
     RefPtr<Frame> m_frame;
     InspectorFrontend::DOMStorage* m_frontend;
     String m_id;
-    bool m_reportingChangesToFrontend;
 
     static int s_nextUnusedId;
 };
index 6c3d373..d8823bd 100644 (file)
@@ -185,7 +185,9 @@ Settings::Settings(Page* page)
     , m_needsSiteSpecificQuirks(false)
     , m_fontRenderingMode(0)
     , m_frameFlatteningEnabled(false)
+#if ENABLE(WEB_ARCHIVE)
     , m_webArchiveDebugModeEnabled(false)
+#endif
     , m_localFileContentSniffingEnabled(false)
     , m_inApplicationChromeMode(false)
     , m_offlineWebApplicationCacheEnabled(false)
index 3b23d62..5be49df 100644 (file)
@@ -680,7 +680,9 @@ namespace WebCore {
         bool m_needsSiteSpecificQuirks : 1;
         unsigned m_fontRenderingMode : 1;
         bool m_frameFlatteningEnabled : 1;
+#if ENABLE(WEB_ARCHIVE)
         bool m_webArchiveDebugModeEnabled : 1;
+#endif
         bool m_localFileContentSniffingEnabled : 1;
         bool m_inApplicationChromeMode : 1;
         bool m_offlineWebApplicationCacheEnabled : 1;
index 44507c6..9b6dfe3 100644 (file)
@@ -75,7 +75,6 @@ CCThreadProxy::CCThreadProxy(CCLayerTreeHost* layerTreeHost)
     : m_animateRequested(false)
     , m_commitRequested(false)
     , m_forcedCommitRequested(false)
-    , m_contextLost(false)
     , m_layerTreeHost(layerTreeHost)
     , m_compositorIdentifier(-1)
     , m_layerRendererInitialized(false)
index e10c3dc..0f8a354 100644 (file)
@@ -152,7 +152,6 @@ private:
     bool m_animateRequested;
     bool m_commitRequested;
     bool m_forcedCommitRequested;
-    bool m_contextLost;
     OwnPtr<CCThreadProxyContextRecreationTimer> m_contextRecreationTimer;
     CCLayerTreeHost* m_layerTreeHost;
     int m_compositorIdentifier;
index 3ed63dd..15b48f5 100644 (file)
@@ -36,8 +36,6 @@ namespace WebCore {
 
 RenderSVGTextPath::RenderSVGTextPath(Node* n)
     : RenderSVGInline(n)
-    , m_exactAlignment(true)
-    , m_stretchMethod(false)
 {
 }
 
index be156ba..2758a06 100644 (file)
@@ -40,9 +40,6 @@ public:
 private:
     virtual const char* renderName() const { return "RenderSVGTextPath"; }
 
-    bool m_exactAlignment : 1;
-    bool m_stretchMethod : 1;
-
     Path m_layoutPath;
 };