AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
authorcfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2019 17:18:17 +0000 (17:18 +0000)
committercfleizach@apple.com <cfleizach@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 4 Jan 2019 17:18:17 +0000 (17:18 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193041
<rdar://problem/46954090>

Reviewed by Zalan Bujtas.

Source/WebCore:

* en.lproj/Localizable.strings:
* platform/cocoa/LocalizedStringsCocoa.mm:
(WebCore::AXHorizontalRuleDescriptionText):

LayoutTests:

* accessibility/mac/hr-element-expected.txt:
* platform/mac/accessibility/roles-exposed-expected.txt:
* platform/mac-wk2/accessibility/roles-exposed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@239613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/accessibility/mac/hr-element-expected.txt
LayoutTests/platform/mac-wk2/accessibility/roles-exposed-expected.txt
LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
Source/WebCore/ChangeLog
Source/WebCore/en.lproj/Localizable.strings
Source/WebCore/platform/cocoa/LocalizedStringsCocoa.mm

index 2d50423..6c934d6 100644 (file)
@@ -1,3 +1,15 @@
+2019-01-04  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+        https://bugs.webkit.org/show_bug.cgi?id=193041
+        <rdar://problem/46954090>
+
+        Reviewed by Zalan Bujtas.
+
+        * accessibility/mac/hr-element-expected.txt:
+        * platform/mac/accessibility/roles-exposed-expected.txt:
+        * platform/mac-wk2/accessibility/roles-exposed-expected.txt:
+
 2019-01-04  Frederic Wang  <fwang@igalia.com>
 
         Flaky Test: http/wpt/css/css-animations/start-animation-001.html
index 59be906..a7149a6 100644 (file)
@@ -5,7 +5,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 hr1 role: AXRole: AXSplitter
 hr1 subrole: AXSubrole: AXContentSeparator
-hr1 roleDescription: AXRoleDescription: rule
+hr1 roleDescription: AXRoleDescription: separator
 hr1 description: AXDescription: 
 hr1 is value settable: false
 hr1 orientation: AXOrientation: AXHorizontalOrientation
@@ -13,7 +13,7 @@ hr1 is enabled: false
 
 hr2 role: AXRole: AXSplitter
 hr2 subrole: AXSubrole: AXContentSeparator
-hr2 roleDescription: AXRoleDescription: rule
+hr2 roleDescription: AXRoleDescription: separator
 hr2 description: AXDescription: 
 hr2 is value settable: false
 hr2 orientation: AXOrientation: AXHorizontalOrientation
@@ -21,7 +21,7 @@ hr2 is enabled: false
 
 hr3 role: AXRole: AXSplitter
 hr3 subrole: AXSubrole: AXContentSeparator
-hr3 roleDescription: AXRoleDescription: rule
+hr3 roleDescription: AXRoleDescription: separator
 hr3 description: AXDescription: RULER
 hr3 is value settable: false
 hr3 orientation: AXOrientation: AXHorizontalOrientation
@@ -29,7 +29,7 @@ hr3 is enabled: false
 
 hr4 role: AXRole: AXSplitter
 hr4 subrole: AXSubrole: AXContentSeparator
-hr4 roleDescription: AXRoleDescription: rule
+hr4 roleDescription: AXRoleDescription: separator
 hr4 description: AXDescription: 
 hr4 is value settable: false
 hr4 orientation: AXOrientation: AXVerticalOrientation
index dd7b641..d2c6855 100644 (file)
@@ -182,7 +182,7 @@ h6
 hr
       AXRole: AXSplitter
       AXSubrole: AXContentSeparator
-      AXRoleDescription: rule
+      AXRoleDescription: separator
       
 i
       AXRole: 
index d5cd5d7..8fa0107 100644 (file)
@@ -182,7 +182,7 @@ h6
 hr
       AXRole: AXSplitter
       AXSubrole: AXContentSeparator
-      AXRoleDescription: rule
+      AXRoleDescription: separator
       
 i
       AXRole: 
index 92d1200..9c6713e 100644 (file)
@@ -1,3 +1,15 @@
+2019-01-04  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: String check: "Rule" does not reflect the meaning of the <hr> html tag
+        https://bugs.webkit.org/show_bug.cgi?id=193041
+        <rdar://problem/46954090>
+
+        Reviewed by Zalan Bujtas.
+
+        * en.lproj/Localizable.strings:
+        * platform/cocoa/LocalizedStringsCocoa.mm:
+        (WebCore::AXHorizontalRuleDescriptionText):
+
 2019-01-04  Zalan Bujtas  <zalan@apple.com>
 
         [LFC] ComputedHorizontalMargin should have optional members
index e3490d6..de7788b 100644 (file)
 "return to realtime" = "return to realtime";
 
 /* accessibility role description for a horizontal rule [<hr>] */
-"rule" = "rule";
+"separator" = "separator";
 
 /* An ARIA accessibility group that contains a search feature of a website. */
 "search" = "search";
index 27070ee..3b79b6c 100644 (file)
@@ -230,7 +230,7 @@ String AXARIAContentGroupText(const String& ariaType)
 
 String AXHorizontalRuleDescriptionText()
 {
-    return WEB_UI_STRING("rule", "accessibility role description for a horizontal rule [<hr>]");
+    return WEB_UI_STRING("separator", "accessibility role description for a horizontal rule [<hr>]");
 }
 
 String AXMarkText()